Add guards to SonarApiClient

Dan Rees · Dan Rees · commit 0e58f2471463 · 2018-05-01T15:02:58.000Z
diff --git a/jobs/sonarqube/templates/config/SonarApiClient.groovy.erb b/jobs/sonarqube/templates/config/SonarApiClient.groovy.erb
@@ -100,8 +100,8 @@ class SonarApiClient
                 println "Request failed with error: ${ioe}"
                 return false
             } finally {
-                writer.close()
-                connection.disconnect()
+                if (writer != null) writer.close()
+                if (connection != null) connection.disconnect()
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -100,8 +100,8 @@ class SonarApiClient`
`100`	`100`	`println "Request failed with error: ${ioe}"`
`101`	`101`	`return false`
`102`	`102`	`} finally {`
`103`		`- writer.close()`
`104`		`- connection.disconnect()`
	`103`	`+ if (writer != null) writer.close()`
	`104`	`+ if (connection != null) connection.disconnect()`
`105`	`105`	`}`
`106`	`106`	`}`
`107`	`107`