[orchestra2unified] repeating group attribute "required" obsolete?

[kleihan]

In the unified repository, both the group reference (per message where it is used) and the single numInGroup field definition have a required attribute. The new unified repository created from Orchestra always sets the required attribute to zero whereas the one created from Basic has a number of instances where this attribute is set to 1. These seem to be cases where the repeating group is only used once and where it is required.

Example: BidCompRspGrp only used in BidResponse(35=l)

            <componentRef id="2005" name="BidCompRspGrp" required="1" legacyPosition="4" legacyIndent="0"
                          inlined="0"
                          added="FIX.4.4"
                          textId="MSG_45_REF_BidCompRspGrp"/>

         <component name="BidCompRspGrp" id="2005" type="ImplicitBlockRepeating"
                    category="ProgramTrading"
                    added="FIX.4.4"
                    textId="COMP_BidCompRspGrp_TITLE"
                    abbrName="CompRsp"
                    notReqXML="0"
                    repeating="1">
            <repeatingGroup id="420" name="" required="1" legacyPosition="1" legacyIndent="0"
                            added="FIX.4.4"
                            textId="CMP_2005_REF_420">

Orchestra does not have a required attribute for the numInGroup field. Is it obsolete in Unified or should we replicate the previous settings? If so then orchestra2unified has a bug.

Here is the list of numInGroup fields affected, starting with NoBidComponents(420) (they occur more than once if they are used in more than one repeating group where they have required="1").

            <repeatingGroup id="420" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="936" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="862" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="146" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="428" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="555" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="33" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="73" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="268" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="268" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="267" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="73" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="295" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="146" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="146" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="296" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="146" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="552" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="552" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="552" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="552" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="386" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="1789" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="1791" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="1793" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="1795" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="2433" name="" required="1" legacyPosition="1" legacyIndent="0"
            <repeatingGroup id="2781" name="" required="1" legacyPosition="1" legacyIndent="0"

[donmendelson]

Repeating group references can be marked as required presence in both schemas.

Orchestra:

<fixr:groupRef id="2043" presence="required" added="FIX.4.4"> ...

Unified:

<componentRef id="2043" name="QuotEntryGrp" required="1" legacyPosition="7" legacyIndent="1"
                             inlined="0"
                             added="FIX.4.4"
                             textId="CMP_2049_REF_QuotEntryGrp"/>

A reason we changed the encoding of repeating groups in Orchestra was that the old format conflated the component and NumInGroup attributes. For all repeating groups, whether the NumInGroup field is required is always the same rule: "Required if [numingroup] > 0."

[kleihan]

The issue is about the repeating group attribute, not about references to it. Not sure what you are suggesting we do here.

[donmendelson]

Presence or required(0/1) is a property of a reference to something defined elsewhere.

In <repeatingGroup id="420" name="" required="1" the id is actually the tag of the NumInGroup field NoBidComponents.

BTW the name attribute is always empty.

[kleihan]

So I guess you are saying that the attribute required in the element repeatingGroup is not obsolete. Then we have a difference between old and new that should not occur. The following example is for BidCompRspGrp where required is set to 1 today but orchestra2unified sets it to 0:

            <repeatingGroup id="420" name="" required="1" legacyPosition="1" legacyIndent="0"
                            added="FIX.4.4"
                            textId="CMP_2005_REF_420">

                <repeatingGroup legacyIndent="0" legacyPosition="0" name="" required="0" id="420" textId="CMP_2005_REF_&lt;built-in function id&gt;">