Merge pull request gothinkster#51 from foopang/fix/constants

Use constants for action types

Author: EricSimons

src/components/App.js

@@ -2,6 +2,7 @@ import agent from '../agent';
 import Header from './Header';
 import React from 'react';
 import { connect } from 'react-redux';
+import { APP_LOAD, REDIRECT } from '../constants/actionTypes';
 
 const mapStateToProps = state => ({
   appLoaded: state.common.appLoaded,
@@ -12,9 +13,9 @@ const mapStateToProps = state => ({
 
 const mapDispatchToProps = dispatch => ({
   onLoad: (payload, token) =>
-    dispatch({ type: 'APP_LOAD', payload, token, skipTracking: true }),
+    dispatch({ type: APP_LOAD, payload, token, skipTracking: true }),
   onRedirect: () =>
-    dispatch({ type: 'REDIRECT' })
+    dispatch({ type: REDIRECT })
 });
 
 class App extends React.Component {

src/components/Article/ArticleActions.js

@@ -2,10 +2,11 @@ import { Link } from 'react-router';
 import React from 'react';
 import agent from '../../agent';
 import { connect } from 'react-redux';
+import { DELETE_ARTICLE } from '../../constants/actionTypes';
 
 const mapDispatchToProps = dispatch => ({
   onClickDelete: payload =>
-    dispatch({ type: 'DELETE_ARTICLE', payload })
+    dispatch({ type: DELETE_ARTICLE, payload })
 });
 
 const ArticleActions = props => {

src/components/Article/CommentInput.js

@@ -1,10 +1,11 @@
 import React from 'react';
 import agent from '../../agent';
 import { connect } from 'react-redux';
+import { ADD_COMMENT } from '../../constants/actionTypes';
 
 const mapDispatchToProps = dispatch => ({
   onSubmit: payload =>
-    dispatch({ type: 'ADD_COMMENT', payload })
+    dispatch({ type: ADD_COMMENT, payload })
 });
 
 class CommentInput extends React.Component {

src/components/Article/DeleteButton.js

@@ -1,10 +1,11 @@
 import React from 'react';
 import agent from '../../agent';
 import { connect } from 'react-redux';
+import { DELETE_COMMENT } from '../../constants/actionTypes';
 
 const mapDispatchToProps = dispatch => ({
   onClick: (payload, commentId) =>
-    dispatch({ type: 'DELETE_COMMENT', payload, commentId })
+    dispatch({ type: DELETE_COMMENT, payload, commentId })
 });
 
 const DeleteButton = props => {

src/components/Article/index.js

@@ -7,6 +7,7 @@ import React from 'react';
 import agent from '../../agent';
 import { connect } from 'react-redux';
 import marked from 'marked';
+import { ARTICLE_PAGE_LOADED, ARTICLE_PAGE_UNLOADED } from '../../constants/actionTypes';
 
 const mapStateToProps = state => ({
   ...state.article,
@@ -15,9 +16,9 @@ const mapStateToProps = state => ({
 
 const mapDispatchToProps = dispatch => ({
   onLoad: payload =>
-    dispatch({ type: 'ARTICLE_PAGE_LOADED', payload }),
+    dispatch({ type: ARTICLE_PAGE_LOADED, payload }),
   onUnload: () =>
-    dispatch({ type: 'ARTICLE_PAGE_UNLOADED' })
+    dispatch({ type: ARTICLE_PAGE_UNLOADED })
 });
 
 class Article extends React.Component {

src/components/ArticlePreview.js

@@ -4,17 +4,18 @@ import React from 'react';
 import { Link } from 'react-router';
 import agent from '../agent';
 import { connect } from 'react-redux';
+import { ARTICLE_FAVORITED, ARTICLE_UNFAVORITED } from '../constants/actionTypes';
 
 const FAVORITED_CLASS = 'btn btn-sm btn-primary';
 const NOT_FAVORITED_CLASS = 'btn btn-sm btn-outline-primary';
 
 const mapDispatchToProps = dispatch => ({
   favorite: slug => dispatch({
-    type: 'ARTICLE_FAVORITED',
+    type: ARTICLE_FAVORITED,
     payload: agent.Articles.favorite(slug)
   }),
   unfavorite: slug => dispatch({
-    type: 'ARTICLE_UNFAVORITED',
+    type: ARTICLE_UNFAVORITED,
     payload: agent.Articles.unfavorite(slug)
   })
 });

src/components/Editor.js

@@ -4,24 +4,32 @@ import ListErrors from './ListErrors';
 import React from 'react';
 import agent from '../agent';
 import { connect } from 'react-redux';
+import {
+  ADD_TAG,
+  EDITOR_PAGE_LOADED,
+  REMOVE_TAG,
+  ARTICLE_SUBMITTED,
+  EDITOR_PAGE_UNLOADED,
+  UPDATE_FIELD_EDITOR
+} from '../constants/actionTypes';
 
 const mapStateToProps = state => ({
   ...state.editor
 });
 
 const mapDispatchToProps = dispatch => ({
   onAddTag: () =>
-    dispatch({ type: 'ADD_TAG' }),
+    dispatch({ type: ADD_TAG }),
   onLoad: payload =>
-    dispatch({ type: 'EDITOR_PAGE_LOADED', payload }),
+    dispatch({ type: EDITOR_PAGE_LOADED, payload }),
   onRemoveTag: tag =>
-    dispatch({ type: 'REMOVE_TAG', tag }),
+    dispatch({ type: REMOVE_TAG, tag }),
   onSubmit: payload =>
-    dispatch({ type: 'ARTICLE_SUBMITTED', payload }),
+    dispatch({ type: ARTICLE_SUBMITTED, payload }),
   onUnload: payload =>
-    dispatch({ type: 'EDITOR_PAGE_UNLOADED' }),
+    dispatch({ type: EDITOR_PAGE_UNLOADED }),
   onUpdateField: (key, value) =>
-    dispatch({ type: 'UPDATE_FIELD_EDITOR', key, value })
+    dispatch({ type: UPDATE_FIELD_EDITOR, key, value })
 });
 
 class Editor extends React.Component {

src/components/Home/MainView.js

@@ -2,6 +2,7 @@ import ArticleList from '../ArticleList';
 import React from 'react';
 import agent from '../../agent';
 import { connect } from 'react-redux';
+import { CHANGE_TAB } from '../../constants/actionTypes';
 
 const YourFeedTab = props => {
   if (props.token) {

src/components/Home/index.js

@@ -4,6 +4,11 @@ import React from 'react';
 import Tags from './Tags';
 import agent from '../../agent';
 import { connect } from 'react-redux';
+import {
+  HOME_PAGE_LOADED,
+  HOME_PAGE_UNLOADED,
+  APPLY_TAG_FILTER
+} from '../../constants/actionTypes';
 
 const Promise = global.Promise;
 
@@ -19,7 +24,7 @@ const mapDispatchToProps = dispatch => ({
   onLoad: (tab, pager, payload) =>
     dispatch({ type: 'HOME_PAGE_LOADED', tab, pager, payload }),
   onUnload: () =>
-    dispatch({  type: 'HOME_PAGE_UNLOADED' })
+    dispatch({  type: HOME_PAGE_UNLOADED })
 });
 
 class Home extends React.Component {

src/components/ListPagination.js

@@ -1,10 +1,11 @@
 import React from 'react';
 import agent from '../agent';
 import { connect } from 'react-redux';
+import { SET_PAGE } from '../constants/actionTypes';
 
 const mapDispatchToProps = dispatch => ({
   onSetPage: (page, payload) =>
-    dispatch({ type: 'SET_PAGE', page, payload })
+    dispatch({ type: SET_PAGE, page, payload })
 });
 
 const ListPagination = props => {