Skip to content

Commit d64d80e

Browse files
authored
Merge pull request #671 from jbernal0019/master
Optimize plugin serializer validation of version
2 parents 772ae53 + 11282ab commit d64d80e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

chris_backend/plugins/serializers.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ def update(self, instance, validated_data):
4444

4545

4646
class PluginSerializer(serializers.HyperlinkedModelSerializer):
47+
VERSION_PATTERN = re.compile(r"^[0-9.]+$")
4748
name = serializers.ReadOnlyField(source='meta.name')
4849
title = serializers.ReadOnlyField(source='meta.title')
4950
public_repo = serializers.ReadOnlyField(source='meta.public_repo')
@@ -135,9 +136,9 @@ def validate_version(self, version):
135136
if not isinstance(version, str):
136137
raise serializers.ValidationError(["Invalid type for plugin app version "
137138
"field. Must be a string."])
138-
if not re.match(r"^[0-9.]+$", version):
139-
raise serializers.ValidationError(["Invalid plugin app version number "
140-
"format %s." % version])
139+
if not self.VERSION_PATTERN.match(version):
140+
raise serializers.ValidationError([f"Invalid plugin app version number "
141+
f"format {version}."])
141142
return version
142143

143144
@staticmethod

0 commit comments

Comments
 (0)