isisd: fix terminate() destruction order for DLIST callbacks

Move vrf_terminate() and prefix_list_reset() before isis_master_terminate().
Their callbacks (isis_vrf_disable, isis_prefix_list_update) iterate over
im->isis list which is finalized by isis_master_terminate(). With typesafe
DLIST, iterating a finalized list causes a SEGV crash.

Signed-off-by: Vincent Jardin <vjardin@free.fr>

Author: vjardin

isisd/isis_main.c

@@ -108,13 +108,20 @@ static FRR_NORETURN void terminate(int i)
 	mt_fini();
 	isis_zebra_stop();
 
-	isis_master_terminate();
+	/*
+	 * Must call vrf_terminate and prefix_list_reset before
+	 * isis_master_terminate, because their callbacks (isis_vrf_disable,
+	 * isis_prefix_list_update) iterate over im->isis which is finalized
+	 * by isis_master_terminate.
+	 */
 	route_map_finish();
 	prefix_list_reset();
+	vrf_terminate();
+
 #ifndef FABRICD
 	isis_affinity_map_terminate();
 #endif
-	vrf_terminate();
+	isis_master_terminate();
 
 	frr_fini();
 	exit(i);