refactor(bot.js): Updated Discord Attachment handle

Author: agntperfect

src/bot.js

@@ -1092,7 +1092,7 @@ class PulchowkBot {
                         .setFooter({ text: `Source: ${notice.source}` })
                         .setTimestamp(new Date(notice.date));
 
-                    let filesToSend = [];
+                    let allFilesForNotice = []; // Collect all files here
                     let tempFilesOnDisk = [];
                     let description = `A new notice has been published.`;
 
@@ -1160,7 +1160,7 @@ class PulchowkBot {
                                                     const pngFilePath = convertResponse.path;
                                                     const pngFileName = path.basename(pngFilePath);
                                                     tempFilesOnDisk.push(pngFilePath);
-                                                    filesToSend.push(new AttachmentBuilder(pngFilePath, { name: pngFileName }));
+                                                    allFilesForNotice.push(new AttachmentBuilder(pngFilePath, { name: pngFileName }));
                                                     console.log(`Converted PDF ${fileName} page ${pageNum} to PNG and prepared for sending.`);
                                                     pageConvertedCount++;
                                                 } else {
@@ -1177,7 +1177,7 @@ class PulchowkBot {
 
                                         if (pageConvertedCount === 0) {
                                             console.warn(`No pages converted for PDF ${fileName}. Sending original PDF.`);
-                                            filesToSend.push(new AttachmentBuilder(tempFilePath, { name: fileName }));
+                                            allFilesForNotice.push(new AttachmentBuilder(tempFilePath, { name: fileName }));
                                         } else if (pageConvertedCount < totalPdfPages) {
                                             console.log(`\n(Sent ${pageConvertedCount} of ${totalPdfPages} pages from ${fileName} as images.)`);
                                         } else {
@@ -1187,10 +1187,10 @@ class PulchowkBot {
                                     } catch (pdfProcessError) {
                                         console.error(`Error processing PDF ${fileName}:`, pdfProcessError.message);
                                         description += `\n\n⚠️ Could not process PDF attachment: ${fileName}`;
-                                        filesToSend.push(new AttachmentBuilder(tempFilePath, { name: fileName }));
+                                        allFilesForNotice.push(new AttachmentBuilder(tempFilePath, { name: fileName }));
                                     }
                                 } else {
-                                    filesToSend.push(new AttachmentBuilder(tempFilePath, { name: fileName }));
+                                    allFilesForNotice.push(new AttachmentBuilder(tempFilePath, { name: fileName }));
                                     console.log(`Prepared attachment: ${fileName}`);
                                 }
                             } catch (downloadError) {
@@ -1201,13 +1201,40 @@ class PulchowkBot {
                     }
                     noticeEmbed.setDescription(description);
 
-                    try {
-                        await noticeChannel.send({ embeds: [noticeEmbed], files: filesToSend });
-                        console.log(`Sent notice and attachments for "${notice.title}" to Discord.`);
-                    } catch (discordSendError) {
-                        console.error(`Error sending notice or files to channel ${TARGET_NOTICE_CHANNEL_ID}:`, discordSendError);
-                        if (adminChannel) await adminChannel.send(`❌ Error sending notice/files for "${notice.title}": ${discordSendError.message}`).catch(e => console.error("Error sending admin error:", e));
-                    } finally {
+                    // --- NEW LOGIC FOR SPLITTING ATTACHMENTS ---
+                    const ATTACHMENT_LIMIT = 10;
+                    if (allFilesForNotice.length > 0) {
+                        let sentFirstMessage = false;
+                        for (let i = 0; i < allFilesForNotice.length; i += ATTACHMENT_LIMIT) {
+                            const chunk = allFilesForNotice.slice(i, i + ATTACHMENT_LIMIT);
+                            try {
+                                if (!sentFirstMessage) {
+                                    // Send the initial embed with the first chunk of attachments
+                                    await noticeChannel.send({ embeds: [noticeEmbed], files: chunk });
+                                    sentFirstMessage = true;
+                                } else {
+                                    // For subsequent chunks, send only attachments with a follow-up message
+                                    await noticeChannel.send({ content: `(Continued attachments for "${notice.title}")`, files: chunk });
+                                }
+                                console.log(`Sent chunk of ${chunk.length} attachments for "${notice.title}" to Discord.`);
+                            } catch (discordSendError) {
+                                console.error(`Error sending notice or files to channel ${TARGET_NOTICE_CHANNEL_ID} (chunk ${i / ATTACHMENT_LIMIT + 1}):`, discordSendError);
+                                if (adminChannel) await adminChannel.send(`❌ Error sending notice/files for "${notice.title}" (chunk ${i / ATTACHMENT_LIMIT + 1}): ${discordSendError.message}`).catch(e => console.error("Error sending admin error:", e));
+                            }
+                        }
+                    } else {
+                        // If no attachments, just send the embed
+                        try {
+                            await noticeChannel.send({ embeds: [noticeEmbed] });
+                            console.log(`Sent notice for "${notice.title}" to Discord (no attachments).`);
+                        } catch (discordSendError) {
+                            console.error(`Error sending notice to channel ${TARGET_NOTICE_CHANNEL_ID}:`, discordSendError);
+                            if (adminChannel) await adminChannel.send(`❌ Error sending notice for "${notice.title}": ${discordSendError.message}`).catch(e => console.error("Error sending admin error:", e));
+                        }
+                    }
+                    // --- END NEW LOGIC ---
+
+                    finally {
                         for (const filePath of tempFilesOnDisk) {
                             try {
                                 await fsPromises.unlink(filePath);
@@ -1310,7 +1337,7 @@ class PulchowkBot {
                                 firstBirthdayUserAvatarUrl = member.user.displayAvatarURL({ dynamic: true, size: 128 });
                             }
                         } catch (fetchErr) {
-                            console.warn(`Could not fetch birthday user ${row.user_id}):`, fetchErr.message);
+                            console.warn(`Could not fetch birthday user ${row.user.id}):`, fetchErr.message);
                             birthdayUsers.push(`• Unknown User (ID: ${row.user.id})`);
                         }
                     }