fix: improve lookup time

Author: MichaelHillcox

common/src/main/java/dev/ftb/mods/ftbchunks/client/FTBChunksClientConfig.java

@@ -114,6 +114,8 @@ static void saveConfig() {
     }
 
     class ChunkPosCustomYSetValue extends BaseValue<Set<HeightUtils.ChunkPosWithMinY>> {
+        private final HashMap<Long, Integer> lookup = new HashMap<>();
+
         protected ChunkPosCustomYSetValue(@Nullable SNBTConfig c, String n, Set<HeightUtils.ChunkPosWithMinY> def) {
             super(c, n, def);
             super.set(new HashSet<>());
@@ -147,6 +149,16 @@ public void read(SNBTCompoundTag tag) {
             }
 
             set(set);
+
+            // Rebuild lookup
+            lookup.clear();
+            for (HeightUtils.ChunkPosWithMinY pos : set) {
+                lookup.put(ChunkPos.asLong(pos.chunkX(), pos.chunkZ()), pos.minY());
+            }
+        }
+
+        public HashMap<Long, Integer> lookup() {
+            return lookup;
         }
     }
 }

common/src/main/java/dev/ftb/mods/ftbchunks/util/HeightUtils.java

@@ -5,15 +5,14 @@
 import dev.ftb.mods.ftbchunks.core.BlockStateFTBC;
 import net.minecraft.core.BlockPos;
 import net.minecraft.util.Mth;
+import net.minecraft.world.level.ChunkPos;
 import net.minecraft.world.level.Level;
 import net.minecraft.world.level.block.Blocks;
 import net.minecraft.world.level.block.state.BlockState;
 import net.minecraft.world.level.chunk.ChunkAccess;
 import net.minecraft.world.level.material.Fluids;
 import org.jetbrains.annotations.Nullable;
 
-import java.util.Set;
-
 public class HeightUtils {
 	public static final int UNKNOWN = Short.MIN_VALUE + 1;
 
@@ -89,14 +88,10 @@ public static int getHeight(Level level, @Nullable ChunkAccess chunkAccess, Bloc
 	}
 
     private static int getMinYFromChunkOrConfig(int x, int z) {
-        Set<ChunkPosWithMinY> chunkPosWithMinY = FTBChunksClientConfig.CHUNKS_WITH_CUSTOM_Y.get();
-        for (ChunkPosWithMinY c : chunkPosWithMinY) {
-            if (c.chunkX == x && c.chunkZ == z) {
-                return c.minY;
-            }
-        }
-
-        return FTBChunksClientConfig.OVERRIDE_MIN_Y_LEVEL_VALUE.get();
+        Long chunkPos = ChunkPos.asLong(x, z);
+
+        return FTBChunksClientConfig.CHUNKS_WITH_CUSTOM_Y.lookup()
+                .getOrDefault(chunkPos, FTBChunksClientConfig.OVERRIDE_MIN_Y_LEVEL_VALUE.get());
     }
 
     public record ChunkPosWithMinY(int chunkX, int chunkZ, int minY) {}