fix: nullability, removed deprecated method in SNBT

Author: MichaelHillcox

common/src/main/java/dev/ftb/mods/ftblibrary/sidebar/RegisteredSidebarButton.java

@@ -9,6 +9,7 @@
 import net.minecraft.util.Util;
 import net.minecraft.network.chat.Component;
 import net.minecraft.resources.Identifier;
+import org.jspecify.annotations.Nullable;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -22,7 +23,7 @@ public class RegisteredSidebarButton implements SidebarButton {
     private final String langKey;
     private final Component tooltip;
     private final List<ButtonOverlayRender> extraRenderers;
-    private Supplier<List<Component>> tooltipOverride;
+    private @Nullable Supplier<List<Component>> tooltipOverride;
     private BooleanSupplier visible = () -> true;
     private boolean forceHidden = false;
 

common/src/main/java/dev/ftb/mods/ftblibrary/snbt/SNBT.java

@@ -9,6 +9,7 @@
 import java.nio.file.Path;
 import java.util.Collection;
 import java.util.List;
+import java.util.Optional;
 
 public class SNBT {
     private static boolean shouldSortKeysOnWrite = false;
@@ -23,10 +24,28 @@ public static SNBTCompoundTag readLines(List<String> lines) {
         return SNBTParser.read(lines);
     }
 
+    /**
+     * Attempt to read an SNBT compound from a file
+     * @param path the path to the SNBT file
+     * @return the SNBT compound tag
+     */
     public static SNBTCompoundTag tryRead(Path path) throws IOException {
         return readLines(Files.readAllLines(path, StandardCharsets.UTF_8));
     }
 
+    /**
+     * Same as {@link #tryRead(Path)} but returns an empty optional on failure instead of throwing an exception
+     * @param file the file to read
+     * @return an optional SNBT compound tag
+     */
+    public static Optional<SNBTCompoundTag> tryReadOptional(Path file) {
+        try {
+            return Optional.of(tryRead(file));
+        } catch (IOException ex) {
+            return Optional.empty();
+        }
+    }
+
     public static void tryWrite(Path path, CompoundTag tag) throws IOException {
         if (Files.notExists(path.getParent())) {
             Files.createDirectories(path.getParent());
@@ -55,27 +74,6 @@ public static List<String> writeLines(CompoundTag nbt) {
         return builder.lines;
     }
 
-    /**
-     * Don't use this anymore
-     * @param path path to write to
-     * @param nbt nbt compound to write
-     * @return true if config was written
-     * @deprecated use {@link #tryWrite(Path, CompoundTag)}
-     */
-    @Deprecated
-    public static boolean write(Path path, CompoundTag nbt) {
-        try {
-            if (Files.notExists(path.getParent())) {
-                Files.createDirectories(path.getParent());
-            }
-
-            Files.write(path, writeLines(nbt));
-            return true;
-        } catch (Exception ex) {
-            return false;
-        }
-    }
-
     private static void append(SNBTBuilder builder, @Nullable Tag nbt) {
         switch (nbt) {
             case null -> builder.print("null");