tom_modem: fix pdu decoding issue #124

Author: FUjr

application/tom_modem/src/operations.c

@@ -117,6 +117,7 @@ int sms_read(PROFILE_T *profile, void *transport_ptr)
                 sms->sms_pdu = (char *)malloc(strlen(pdu));
                 sms->sender = (char *)malloc(PHONE_NUMBER_SIZE);
                 sms->sms_text = (char *)malloc(SMS_TEXT_SIZE);
+                memset(sms->sms_text, 0, SMS_TEXT_SIZE);
                 sms->sms_index = get_sms_index(line);
                 memcpy(sms->sms_pdu, pdu, strlen(pdu));
                 int sms_len = decode_pdu(sms);
@@ -237,6 +238,7 @@ int sms_read_unread(PROFILE_T *profile, void *transport_ptr)
                 sms->sms_pdu = (char *)malloc(strlen(pdu));
                 sms->sender = (char *)malloc(PHONE_NUMBER_SIZE);
                 sms->sms_text = (char *)malloc(SMS_TEXT_SIZE);
+                memset(sms->sms_text, 0, SMS_TEXT_SIZE);
                 sms->sms_index = get_sms_index(line);
                 memcpy(sms->sms_pdu, pdu, strlen(pdu));
                 int sms_len = decode_pdu(sms);

application/tom_modem/src/utils.c

@@ -117,7 +117,7 @@ int decode_pdu(SMS_T *sms)
             // UCS2
             sms->type = SMS_CHARSET_UCS2;
             int offset = 0;
-            for (int i = skip_bytes; i < SMS_TEXT_SIZE; i += 2)
+            for (int i = skip_bytes; i < sms_len; i += 2)
             {
                 int ucs2_char = 0x000000FF & sms_text[i + 1];
                 ucs2_char |= (0x0000FF00 & (sms_text[i] << 8));