Floor taken damage for player instead casting to int. Avoid casting issues (#505)

FreeSlave · web-flow · commit e53009991a48 · 2025-01-03T02:19:28.000Z
diff --git a/dlls/player.cpp b/dlls/player.cpp
@@ -486,7 +486,7 @@ int CBasePlayer::TakeDamage( entvars_t *pevInflictor, entvars_t *pevAttacker, fl
 
 	// this cast to INT is critical!!! If a player ends up with 0.5 health, the engine will get that
 	// as an int (zero) and think the player is dead! (this will incite a clientside screentilt, etc)
-	fTookDamage = CBaseMonster::TakeDamage( pevInflictor, pevAttacker, (int)flDamage, bitsDamageType );
+	fTookDamage = CBaseMonster::TakeDamage( pevInflictor, pevAttacker, flDamage >= 0.0f ? floor(flDamage) : ceil(flDamage), bitsDamageType );
 
 	// reset damage time countdown for each type of time based damage player just sustained
 	{

Original file line number	Diff line number	Diff line change
`@@ -486,7 +486,7 @@ int CBasePlayer::TakeDamage( entvars_t pevInflictor, entvars_t pevAttacker, fl`
`486`	`486`
`487`	`487`	`// this cast to INT is critical!!! If a player ends up with 0.5 health, the engine will get that`
`488`	`488`	`// as an int (zero) and think the player is dead! (this will incite a clientside screentilt, etc)`
`489`		`- fTookDamage = CBaseMonster::TakeDamage( pevInflictor, pevAttacker, (int)flDamage, bitsDamageType );`
	`489`	`+ fTookDamage = CBaseMonster::TakeDamage( pevInflictor, pevAttacker, flDamage >= 0.0f ? floor(flDamage) : ceil(flDamage), bitsDamageType );`
`490`	`490`
`491`	`491`	`// reset damage time countdown for each type of time based damage player just sustained`
`492`	`492`	`{`