Skip to content

Commit 0005730

Browse files
committed
Revert "fetch website data through gecko fetch api"
This reverts commit a7d2cb7.
1 parent 5967c2a commit 0005730

File tree

4 files changed

+87
-37
lines changed

4 files changed

+87
-37
lines changed

app/lib/domain/services/generic_website.dart

Lines changed: 47 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,21 @@
1818
* along with this program. If not, see <http://www.gnu.org/licenses/>.
1919
*/
2020
import 'dart:async';
21-
import 'dart:convert';
2221
import 'dart:ui';
2322

24-
import 'package:collection/collection.dart';
2523
import 'package:exceptions/exceptions.dart';
2624
import 'package:flutter/foundation.dart';
2725
import 'package:flutter_mozilla_components/flutter_mozilla_components.dart';
2826
import 'package:html/dom.dart';
2927
import 'package:html/parser.dart' as html_parser;
28+
import 'package:http/io_client.dart';
3029
import 'package:nullability/nullability.dart';
3130
import 'package:riverpod_annotation/riverpod_annotation.dart';
31+
import 'package:socks5_proxy/socks_client.dart';
32+
import 'package:universal_io/io.dart';
3233
import 'package:weblibre/core/http_error_handler.dart';
33-
import 'package:weblibre/core/logger.dart';
3434
import 'package:weblibre/data/models/web_page_info.dart';
35+
import 'package:weblibre/extensions/http_encoding.dart';
3536
import 'package:weblibre/features/geckoview/domain/entities/browser_icon.dart';
3637
import 'package:weblibre/features/user/domain/repositories/cache.dart';
3738
import 'package:weblibre/features/web_feed/utils/feed_finder.dart';
@@ -210,42 +211,54 @@ class GenericWebsiteService extends _$GenericWebsiteService {
210211
Future<Result<WebPageInfo>> fetchPageInfo({
211212
required Uri url,
212213
required bool isImageRequest,
214+
required int? proxyPort,
213215
}) {
214216
return Result.fromAsync(() async {
215-
late final Map<String, Object?> result;
216-
final client = GeckoFetchService();
217-
try {
218-
final response = await client
219-
.fetch(url: url)
220-
.timeout(const Duration(seconds: 15));
221-
222-
//When this is a request for an icon and we hit an image, directly return it
223-
if (isImageRequest) {
224-
final contentType = response.headers
225-
.firstWhereOrNull((header) => header.key == 'content-type')
226-
?.value;
227-
if (contentType?.contains('image/') == true) {
228-
result = {
229-
'imageBytes': [response.body],
230-
};
231-
}
217+
final result = await compute((args) async {
218+
final [String urlString, bool isImageRequest, int? proxyPort] = args;
219+
220+
final httpClient = HttpClient();
221+
if (proxyPort != null) {
222+
SocksTCPClient.assignToHttpClient(httpClient, [
223+
ProxySettings(InternetAddress.loopbackIPv4, proxyPort),
224+
]);
232225
}
233226

234-
final document = html_parser.parse(utf8.decode(response.body));
235-
236-
final title = document.querySelector('title')?.text;
237-
final resources = _extractIcons(url, document);
238-
final feeds = await FeedFinder(url: url, document: document).parse();
227+
final client = IOClient(httpClient);
228+
try {
229+
final baseUri = Uri.parse(urlString);
230+
final response = await client
231+
.get(baseUri)
232+
.timeout(const Duration(seconds: 15));
233+
234+
//When this is a request for an icon and we hit an image, directly return it
235+
if (isImageRequest) {
236+
final contentType = response.headers['content-type'];
237+
if (contentType?.contains('image/') == true) {
238+
return {
239+
'imageBytes': [response.bodyBytes],
240+
};
241+
}
242+
}
239243

240-
result = {
241-
'title': title,
242-
'resources': resources.map(_serializeResource).toList(),
243-
'feeds': feeds.map((uri) => uri.toString()).toList(),
244-
};
245-
} catch (e, s) {
246-
logger.e('Error fetching page $url', error: e, stackTrace: s);
247-
result = {};
248-
}
244+
final document = html_parser.parse(response.bodyUnicodeFallback);
245+
246+
final title = document.querySelector('title')?.text;
247+
final resources = _extractIcons(baseUri, document);
248+
final feeds = await FeedFinder(
249+
url: baseUri,
250+
document: document,
251+
).parse();
252+
253+
return {
254+
'title': title,
255+
'resources': resources.map(_serializeResource).toList(),
256+
'feeds': feeds.map((uri) => uri.toString()).toList(),
257+
};
258+
} finally {
259+
client.close();
260+
}
261+
}, <dynamic>[url.toString(), isImageRequest, proxyPort]);
249262

250263
if (result['imageBytes'] case final Uint8List imageBytes) {
251264
return WebPageInfo(

app/lib/domain/services/generic_website.g.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/lib/presentation/controllers/website_title.dart

Lines changed: 38 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@ import 'package:weblibre/domain/services/generic_website.dart';
2626
import 'package:weblibre/extensions/ref_cache.dart';
2727
import 'package:weblibre/features/geckoview/domain/entities/states/tab.dart';
2828
import 'package:weblibre/features/geckoview/domain/providers/tab_state.dart';
29+
import 'package:weblibre/features/geckoview/features/tabs/domain/repositories/container.dart';
30+
import 'package:weblibre/features/geckoview/features/tabs/domain/repositories/tab.dart';
31+
import 'package:weblibre/features/tor/domain/services/tor_proxy.dart';
32+
import 'package:weblibre/features/user/data/models/tor_settings.dart';
33+
import 'package:weblibre/features/user/domain/repositories/tor_settings.dart';
2934

3035
part 'website_title.g.dart';
3136

@@ -104,9 +109,41 @@ Future<WebPageInfo> pageInfo(
104109
}) async {
105110
final link = ref.cacheFor(const Duration(minutes: 2));
106111

112+
final tabState = ref.read(selectedTabStateProvider);
113+
114+
int? proxyPort;
115+
if (tabState?.id != null) {
116+
final containerId = await ref
117+
.read(tabDataRepositoryProvider.notifier)
118+
.getContainerTabId(tabState!.id);
119+
120+
final containerData = await containerId.mapNotNull(
121+
(containerId) => ref
122+
.read(containerRepositoryProvider.notifier)
123+
.getContainerData(containerId),
124+
);
125+
126+
final torSettings = ref.read(torSettingsWithDefaultsProvider);
127+
128+
if (containerData?.metadata.useProxy == true ||
129+
(tabState.isPrivate == false &&
130+
torSettings.proxyRegularTabsMode == TorRegularTabProxyMode.all) ||
131+
(tabState.isPrivate == true && torSettings.proxyPrivateTabsTor)) {
132+
proxyPort = await ref.read(torProxyServiceProvider.future);
133+
134+
if (proxyPort == null) {
135+
throw Exception('Could not proxy request');
136+
}
137+
}
138+
}
139+
107140
final result = await ref
108141
.watch(genericWebsiteServiceProvider.notifier)
109-
.fetchPageInfo(url: url, isImageRequest: isImageRequest);
142+
.fetchPageInfo(
143+
url: url,
144+
isImageRequest: isImageRequest,
145+
proxyPort: proxyPort,
146+
);
110147

111148
if (!result.isSuccess) {
112149
link.close();

app/lib/presentation/controllers/website_title.g.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)