Skip to content

Commit 3dfd02d

Browse files
committed
use dedicated call for default bang url
1 parent 8f612f5 commit 3dfd02d

File tree

8 files changed

+12
-13
lines changed

8 files changed

+12
-13
lines changed

app/lib/features/bangs/data/models/bang.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,9 @@ class Bang with FastEquatable implements Insertable<Bang> {
9292
: Uri.encodeComponent(input)
9393
: input;
9494
}
95+
Uri getDefaultUrl() {
96+
return getTemplateUrl('');
97+
}
9598

9699
Uri getTemplateUrl(String? query) {
97100
final url = (query != null)

app/lib/features/bangs/presentation/widgets/bang_details.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class BangDetails extends HookConsumerWidget {
5858
children: [
5959
Row(
6060
children: [
61-
UrlIcon([bangData.getTemplateUrl('')], iconSize: 34.0),
61+
UrlIcon([bangData.getDefaultUrl()], iconSize: 34.0),
6262
const SizedBox(width: 12.0),
6363
Expanded(
6464
child: Column(
@@ -87,7 +87,7 @@ class BangDetails extends HookConsumerWidget {
8787
visualDensity: VisualDensity.compact,
8888
),
8989
onPressed: () async {
90-
final url = Uri.parse(bangData.getTemplateUrl('').origin);
90+
final url = Uri.parse(bangData.getDefaultUrl().origin);
9191
final isPrivate =
9292
ref
9393
.read(generalSettingsWithDefaultsProvider)

app/lib/features/bangs/presentation/widgets/site_search.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ class SiteSearch extends HookConsumerWidget {
128128
child: SelectableChips(
129129
itemId: (bang) => bang.trigger,
130130
itemAvatar: (bang) =>
131-
UrlIcon([bang.getTemplateUrl('')], iconSize: 20),
131+
UrlIcon([bang.getDefaultUrl()], iconSize: 20),
132132
itemLabel: (bang) => Text(bang.websiteName),
133133
itemTooltip: (bang) => bang.trigger,
134134
availableItems: availableBangs,

app/lib/features/geckoview/features/search/presentation/widgets/bang_chips.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class BangChips extends HookConsumerWidget {
9292
child: SelectableChips(
9393
itemId: (bang) => bang.trigger,
9494
itemAvatar: (bang) =>
95-
UrlIcon([bang.getTemplateUrl('')], iconSize: 20),
95+
UrlIcon([bang.getDefaultUrl()], iconSize: 20),
9696
itemLabel: (bang) => Text(bang.websiteName),
9797
itemTooltip: (bang) => bang.trigger,
9898
availableItems: availableBangs,

app/lib/features/geckoview/features/search/presentation/widgets/search_field.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,9 +110,7 @@ class SearchField extends HookConsumerWidget {
110110
prefixIcon: (showBangIcon && activeBang != null)
111111
? Padding(
112112
padding: const EdgeInsetsDirectional.all(12.0),
113-
child: UrlIcon([
114-
activeBang!.getTemplateUrl(''),
115-
], iconSize: 24.0),
113+
child: UrlIcon([activeBang!.getDefaultUrl()], iconSize: 24.0),
116114
)
117115
: null,
118116
label: label ?? const Text('Search'),

app/lib/features/onboarding/presentation/pages/default_search.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,7 @@ class DefaultSearchPage extends HookConsumerWidget {
8383
child: FilterChip(
8484
showCheckmark: false,
8585
label: Text(activeBang.websiteName),
86-
avatar: UrlIcon([
87-
activeBang.getTemplateUrl(''),
88-
], iconSize: 20),
86+
avatar: UrlIcon([activeBang.getDefaultUrl()], iconSize: 20),
8987
selected: true,
9088
onSelected: (value) {},
9189
),
@@ -98,7 +96,7 @@ class DefaultSearchPage extends HookConsumerWidget {
9896
(bang) => FilterChip(
9997
showCheckmark: false,
10098
label: Text(bang.websiteName),
101-
avatar: UrlIcon([bang.getTemplateUrl('')], iconSize: 20),
99+
avatar: UrlIcon([bang.getDefaultUrl()], iconSize: 20),
102100
selected: activeBang?.trigger == bang.trigger,
103101
onSelected: (selected) async {
104102
if (selected) {

app/lib/features/settings/presentation/widgets/bang_icon.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class BangIcon extends ConsumerWidget {
3636
);
3737

3838
return UrlIcon([
39-
if (bang != null) bang.getTemplateUrl(''),
39+
if (bang != null) bang.getDefaultUrl(),
4040
], iconSize: iconSize);
4141
}
4242
}

app/lib/features/settings/presentation/widgets/default_search_selector.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ class DefaultSearchSelector extends HookConsumerWidget {
5757
child: SelectableChips(
5858
itemId: (bang) => bang.trigger,
5959
itemAvatar: (bang) =>
60-
UrlIcon([bang.getTemplateUrl('')], iconSize: 20),
60+
UrlIcon([bang.getDefaultUrl()], iconSize: 20),
6161
itemLabel: (bang) => Text(bang.websiteName),
6262
itemTooltip: (bang) => bang.trigger,
6363
availableItems: availableBangs,

0 commit comments

Comments
 (0)