Make PlayerRequestControl cancelable (#823)

Author: deluvas1911

api/AltV.Net.Async/AsyncCore.cs

@@ -724,9 +724,9 @@ await ServerStartedAsyncEventHandler.CallAsync(@delegate =>
             });
         }
 
-        public override void OnPlayerRequestControlEvent(IEntity target, IPlayer player)
+        public override void OnPlayerRequestControlEvent(IntPtr eventPtr, IEntity target, IPlayer player)
         {
-           base.OnPlayerRequestControlEvent(target, player);
+           base.OnPlayerRequestControlEvent(eventPtr, target, player);
 
            if (!PlayerRequestControlAsyncEventHandler.HasEvents()) return;
            Task.Run(async () =>

api/AltV.Net.CApi/Native/AltV.Resource.cs

@@ -100,7 +100,7 @@ internal delegate void VehicleHornDelegate(IntPtr eventPointer, IntPtr targetPoi
 
             internal delegate void ServerStartedDelegate();
 
-            internal delegate void PlayerRequestControlDelegate(IntPtr target, BaseObjectType targetType, IntPtr player);
+            internal delegate void PlayerRequestControlDelegate(IntPtr eventPtr, IntPtr target, BaseObjectType targetType, IntPtr player);
             internal delegate void PlayerChangeAnimationDelegate(IntPtr target, uint oldDict, uint newDict, uint oldName, uint newName);
             internal delegate void PlayerChangeInteriorDelegate(IntPtr target, uint oldIntLoc, uint newIntLoc);
             internal delegate void PlayerDimensionChangeDelegate(IntPtr player, int oldDimension, int newDimension);

api/AltV.Net/Alt.RegisterEvents.cs

@@ -621,7 +621,12 @@ public static void RegisterEvents(object target)
                                         {
                                             scriptFunction.Set(entity);
                                             scriptFunction.Set(player);
-                                            scriptFunction.Call();
+                                            if (scriptFunction.Call() is bool value)
+                                            {
+                                                return value;
+                                            }
+
+                                            return true;
                                         };
                                     break;
                                 }

api/AltV.Net/Core.Events.cs

@@ -1433,7 +1433,7 @@ public virtual void OnServerStartedEvent()
             }
         }
 
-        public virtual void OnPlayerRequestControl(IntPtr targetPtr, BaseObjectType targetType, IntPtr playerPtr)
+        public virtual void OnPlayerRequestControl(IntPtr eventPtr, IntPtr targetPtr, BaseObjectType targetType, IntPtr playerPtr)
         {
             var target = (IEntity)PoolManager.Get(targetPtr, targetType);
             if (target is null)
@@ -1449,16 +1449,20 @@ public virtual void OnPlayerRequestControl(IntPtr targetPtr, BaseObjectType targ
                 return;
             }
 
-            OnPlayerRequestControlEvent(target, player);
+            OnPlayerRequestControlEvent(eventPtr, target, player);
         }
 
-        public virtual void OnPlayerRequestControlEvent(IEntity target, IPlayer player)
+        public virtual void OnPlayerRequestControlEvent(IntPtr eventPtr, IEntity target, IPlayer player)
         {
+            var cancel = false;
             foreach (var @delegate in PlayerRequestControlHandler.GetEvents())
             {
                 try
                 {
-                    @delegate(target, player);
+                    if (!@delegate(target, player))
+                    {
+                        cancel = true;
+                    }
                 }
                 catch (TargetInvocationException exception)
                 {
@@ -1469,6 +1473,14 @@ public virtual void OnPlayerRequestControlEvent(IEntity target, IPlayer player)
                     Alt.Log("exception at event:" + "OnPlayerRequestControlEvent" + ":" + exception);
                 }
             }
+
+            if (cancel)
+            {
+                unsafe
+                {
+                    Alt.Core.Library.Shared.Event_Cancel(eventPtr);
+                }
+            }
         }
 
         public virtual void OnPlayerChangeAnimation(IntPtr playerPtr, uint oldDict, uint newDict, uint oldName,

api/AltV.Net/Events/Events.cs

@@ -87,7 +87,7 @@ public delegate WeaponDamageResponse WeaponDamageDelegate(IPlayer player, IEntit
 
     public delegate void ServerStartedDelegate();
 
-    public delegate void PlayerRequestControlDelegate(IEntity target, IPlayer player);
+    public delegate bool PlayerRequestControlDelegate(IEntity target, IPlayer player);
 
     public delegate void PlayerChangeAnimationDelegate(IPlayer player, uint oldDict, uint newDict, uint oldName, uint newName);
 

api/AltV.Net/ModuleWrapper.cs

@@ -398,9 +398,9 @@ public static void OnServerStarted()
             _core.OnServerStarted();
         }
 
-        public static void OnPlayerRequestControl(IntPtr target, BaseObjectType targetType, IntPtr player)
+        public static void OnPlayerRequestControl(IntPtr eventPtr, IntPtr target, BaseObjectType targetType, IntPtr player)
         {
-            _core.OnPlayerRequestControl(target, targetType, player);
+            _core.OnPlayerRequestControl(eventPtr, target, targetType, player);
         }
 
         public static void OnPlayerChangeAnimation(IntPtr player, uint oldDict, uint newDict, uint oldName, uint newName)