Proper cloud auth impl

Author: zziger

api/AltV.Net.Async/Elements/Entities/AsyncConnectionInfo.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Threading.Tasks;
 using AltV.Net.Elements.Entities;
 
 namespace AltV.Net.Async.Elements.Entities;
@@ -216,7 +217,7 @@ public Task<string> RequestCloudId()
         lock (ConnectionInfo)
         {
             if (!AsyncContext.CheckIfExistsNullable(ConnectionInfo)) return Task.FromResult<string>(default);
-            return Task.FromResult(ConnectionInfo.RequestCloudId().Result);
+            return ConnectionInfo.RequestCloudId();
         }
     }
 

api/AltV.Net.Async/Elements/Entities/AsyncPlayer.cs

@@ -1281,18 +1281,6 @@ public string SocialClubName
             }
         }
 
-        public string CloudAuthHash
-        {
-            get
-            {
-                lock (Player)
-                {
-                    if (!AsyncContext.CheckIfExistsOrCachedNullable(Player)) return default;
-                    return Player.CloudAuthHash;
-                }
-            }
-        }
-
         public void SetAmmo(uint ammoHash, ushort ammo)
         {
             lock (Player)
@@ -1469,7 +1457,7 @@ public Task<string> RequestCloudId()
             lock (Player)
             {
                 if (!AsyncContext.CheckIfExistsNullable(Player)) return Task.FromResult<string>(default);
-                return Task.FromResult(Player.RequestCloudId().Result);
+                return Player.RequestCloudId();
             }
         }
 

api/AltV.Net.Mock/MockConnectionInfo.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Threading.Tasks;
 using AltV.Net.Elements.Args;
 using AltV.Net.Elements.Entities;
 using AltV.Net.Shared.Elements.Entities;
@@ -26,7 +27,6 @@ public MockConnectionInfo(ICore core, IntPtr nativePointer, uint id) : base(core
         public string Ip { get; }
         public long DiscordUserId { get; }
         public string SocialName { get; }
-        public string CloudAuthHash { get; }
         public string Text { get; set; }
         public bool IsAccepted { get; }
 
@@ -39,5 +39,10 @@ public void Decline(string reason)
         {
             throw new NotImplementedException();
         }
+
+        public Task<string> RequestCloudId()
+        {
+            throw new NotImplementedException();
+        }
     }
 }

api/AltV.Net/Elements/Entities/ConnectionInfo.cs

@@ -1,5 +1,8 @@
 using System;
 using System.Runtime.InteropServices;
+using System.Threading;
+using System.Threading.Tasks;
+using AltV.Net.CApi.ServerEvents;
 using AltV.Net.Native;
 
 namespace AltV.Net.Elements.Entities;

api/AltV.Net/Elements/Entities/IConnectionInfo.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Threading.Tasks;
 using AltV.Net.Elements.Entities;
 
 namespace AltV.Net.Elements.Entities;

api/AltV.Net/Elements/Entities/IPlayer.cs

@@ -434,7 +434,6 @@ void PlayAnimation(string animDict, string animName, float blendInSpeed, float b
         void ClearTasks();
 
         string SocialClubName { get; }
-        string CloudAuthHash { get; }
         void SetAmmo(uint ammoHash, ushort ammo);
         ushort GetAmmo(uint ammoHash);
         void SetWeaponAmmo(uint weaponHash, ushort ammo);

api/AltV.Net/Elements/Entities/Player.cs

@@ -192,21 +192,7 @@ public string SocialClubName
                 }
             }
         }
-
-        public string CloudAuthHash
-        {
-            get
-            {
-                unsafe
-                {
-                    CheckIfEntityExistsOrCached();
-                    var size = 0;
-                    return Core.PtrToStringUtf8AndFree(
-                        Core.Library.Server.Player_GetCloudAuthHash(PlayerNativePointer, &size), size);
-                }
-            }
-        }
-
+        
         public void SetAmmo(uint ammoHash, ushort ammo)
         {
             unsafe