Editor Mode

[garrynewman]

I'm merging editor mode to main. This is an attempt to make the -tools mode less of a games window with a bunch of tools that can open, and more of an editor view that wraps the game window, like Unity and Unreal and every other game engine made in the last 10 years.

Minimal

This is the minimal amount of features I thought I could get away with shipping. It's missing a bunch of stuff from the in-game console.. But I've been in a feature branch for about 2-3 weeks, so wanted to get this shipped so I can start iterating. If it's missing stuff you want/need please reply to this discussion and I'll get it fixed.

Game Window

Let me know how you get on with the game window. Is it too small, too big? What size do you want it? Do you want it to zoom to full screen when switching to the game?

Annoyances

I made it so when you press the console key in game or in a tool/editor window it'll toggle between them nicely. Have I fucked something up there?

Tools

As part of this I updated Qt and edited it so the dock widgets don't have a titlebar and can be dragged around using the tabs instead (like every other UI in the past 10 years). Did I break a tool? Does something now not work that previously did?

Affected non tool mode

Did I affect the non -tools mode? Everything should work the same to non tools - let me know if I fucked it.

Make it an option

I know people are going to ask for an option to use the old window mode and the new editor mode. Nope. That's not how I do shit. Lets make the editor awesome.

[DevulTj]

I get this crash on non tools launch

[garrynewman]

I know what this is - fixing

[conneath]

the game preview is tiny, maybe it's because im using a 4K screen?

[garrynewman]

Fix coming for this one thanks

[BlockBuilder57]

The status bar of the game window eats into the whole frame a bit, and trying to change the console height doesn't change the game window height

[BlockBuilder57]

Oh and the clear command in console no longer works.

[garrynewman]

I think you might be hitting the minimum resolution (720p) - I'll reduce it

[BlockBuilder57]

Yeah I've only got a 1080p (but ultrawide) screen, ain't in fancy 4k land yet. I usually run the tools at 1600x900, maybe let the game window be a separate dockable widget/tab if possible?

[walllable]

Noticed that the game treats resizing a popped out window as if you're dragging it, makes it so that if you're resizing you have a chance of just docking it back to the main window

2021-12-10_10-52-51.mp4

[walllable]

In addition, I also noticed that having the game maximized on my main monitor put a white line on my second monitor

2021-12-10_11-02-23.mp4

[BlockBuilder57]

KIzXwh.mp4

The game window will lock the mouse input but won't focus the actual editor window

[garrynewman]

That's not new though right?

[BlockBuilder57]

Not certain, but all the other tools (asset browser, Hammer, ModelDoc) focus the whole window

[KayaDLX]

I'd love to see the tab completion in the console, that stuff is really useful and truly missing from the console right now.
As in using tab to complete the command from top to bottom of the suggested list, instead of using arrow keys then enter to complete it.

[KayaDLX]

Yeah but you still have to use your arrow keys first then press either space or enter to complete the command.

I would expect the console to let me use tab to directly select one of the suggested command rather than using the arrow keys first, that's how it also works in the vconsole2 and source 1 games, I find it easier and intuitive to use.

[garrynewman]

How do you mean use tab? Tab changes between the options?

[KayaDLX]

Yeah basically, it's just a tiny QOL thing and I think many are used to it
https://user-images.githubusercontent.com/67245359/145627548-2b2ad770-e56b-4b26-bc3e-db4ed8441250.mp4

[garrynewman]

So use tab instead of pressing down?

[KayaDLX]

Yup, could still keep the arrow keys though if people are also using that

[NotGaylien]

I would just like a way to focus or maximise the game window (make the game take full focus of the editor window, like switching in and out of console before)
currently it makes it harder to get up close to look at and view mistakes on models and test materials and such ingame (since in modeldoc and so on it can look way different, so its nice to get up close ingame with them.)

[garrynewman]

So, just to get it right, you'd like the option so if you focus the window it'll go the full size of the window, right? Hide the console and the properties and everything and go full screen windowed?

[NotGaylien]

Yes that would be splendid

[NotGaylien]

Kinda like if you turned the window to show only the game (as if it kinda turned into a normal game window)

[garrynewman]

maybe we have a key to toggle would be best

[NotGaylien]

Yeah that would be cool
Whatever you think would work best

[DoctorGurke]

I have weird inconsistent black bars and artifacts in the game window. playing on 1440p
in the first image it actually cuts off the bottom of the viewport and hides hud elements

[DoctorGurke]

actually seems to be related to my post processing? did anything change about the uv calculation with the new viewport? I'm using the one that's provided with the post processing example shader

[DoctorGurke]

only happens if I have my console or something else docked below the game viewport

[garrynewman]

Looks like the top image is the only one with the problem right? Nothing changed with the UV layout. It's just equivalent of resizing the window to that size.

[DoctorGurke]

Second image seems to have a weird border on the bottom of the Esc menu, last image shows the fucked uvs with the frame texture in the game viewport

[DoctorGurke]

styling on panels is a bit weird when they're free floating (see close button) also missing minimize/maximize

[DoctorGurke]

also would be neat if free floating windows can have a separate tray window thing so you can find them again

[DoctorGurke]

it also feels weird that the tabs while docked are below the panels but you grab them like normal windows when free floating. I think the tabs should just be at the top of the panel, too.

[ShadowBrian]

Pressing arrow key up used to let you input the last command you put in- that doesn't seem to be working currently?
I used to use it a lot when repeating the same commands during dev so it feels weird when it's missing.

[garrynewman]

Yep - that's on my list

[Oppossome]

Would be super useful if it remembered what pane was focused when you tabbed out. Currently running into the issue where I tab out to edit code and have to click back into the game pane once I tab back in.

[xezno]

The editor itself is awesome, I love it so far - but I do have a couple of (minor) issues:

It's pretty hard to describe and demonstrate, but currently, the title bar button actions fire on mouse down rather than mouse up, which
means input gets passed to the game - so even if you're only clicking once, you'll close the window and click in-game simultaneously.
I think the easiest way to fix this is probably just to have the title bar buttons have their actions fire on mouse up, which would also make them consistent with other Windows apps.

Here's a video - I'm only clicking once here, but it does two things - it closes the window on mouse down, but presses a button in-game on mouse up:

ef81dc42.mp4

Additionally, resizing should be available from all corners and edges of the windows, rather than just the bottom right.

[garrynewman]

Should be fixed in next build

[xezno]

Awesome, thanks <3

[DoctorGurke]

drop down styles don't work well with the tight options in the particle editor

[DoctorGurke]

Can we get the close button to extend all the way into the corners like win 10 buttons, again? kinda useful to quickly snap to the top right of your screen and be able to hit the close button

[garrynewman]

Should be fixed in next build

[DoctorGurke]

I feel like the editor mode doesn't do well with the little steam overlay popup if you do fullscreen before it pops up lmfao

[garrynewman]

Should be fixed in next build

[DoctorGurke]

got it again just now. Think it's related to using the fullscreen button before the window is fully initialized

[DoctorGurke]

still happening if you fullscreen the game viewport before it's fully loaded

[DoctorGurke]

text highlight styling is weird in the console text entry when it's focused

non focused/selected looks fine

[DoctorGurke]

Panel selector/inspector is missing a tab for the window name

[DoctorGurke]

seems this was just weird and broken on my end? got it to work now

[DoctorGurke]

Bottom row in hammer is still a little cramped for everything

[DevulTj]

sbox_HRt54LXeO7.mp4

Game viewport doesn't seem to want to grab focus like the editor does

[dch-GH]

Several icons stopped working after a couple updates to the tools UI. I don't have an exact date or anything, seemed like it happened within a week after the new tools UI was introduced.

Fixed after reinstalling Material Icons font.

[DoctorGurke]

Running game sounds fade out when you focus the editor, but not when focusing something outside of the editor (like desktop). Fades in again when focusing the game view port