Input Changes

[garrynewman]

So I'm updating how Input works.

Before

Input was a class on each client. To access it you grabbed it from Client or from one of the helper redirect functions (Entity.Input).

Now

Input is a global. On the client it is always available. On the server it is available only during Simulate for that specific client.

Why

This is simpler. A single global static class where you can get access to everything Input related. It also punishes doing naughty things on the server like using the player input outside of the Simulate loop, which is an indication that you're doing something wrong.

Example

// old
SetClass( "open", Local.Client?.Input.Down( InputButton.Score ) ?? false );

// new
SetClass( "open", Input.Down( InputButton.Score ) );

// old
bool wants = Controller.Input.Down( InputButton.Duck );

// new
bool wants = Input.Down( InputButton.Duck );

// old
return Local.Client.Input.Rotation.Forward * (-130 * 1) + Vector3.Up * (20 * 1);

// new
return Input.Rotation.Forward * (-130 * 1) + Vector3.Up * (20 * 1);