-
Notifications
You must be signed in to change notification settings - Fork 0
Password hashers need some hardening #36
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is neededsecurityIssues related to the security of the code. PLEASE READ SECURITY POLICY BEFORE USING.Issues related to the security of the code. PLEASE READ SECURITY POLICY BEFORE USING.
Milestone
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is neededsecurityIssues related to the security of the code. PLEASE READ SECURITY POLICY BEFORE USING.Issues related to the security of the code. PLEASE READ SECURITY POLICY BEFORE USING.
Is your feature request related to a problem? Please describe.
Right now, although we use PBKDF2 with a SHA512 hash, we use a static salt and static iteration count. This makes things not quite as secure as they could/should be. We also can't easily increase the iteration count for future purposes.
Describe the solution you'd like
We need something more like what Django does: https://github.com/django/django/blob/136ec9b62bd0b105f281218d7cad54b7db7a4bab/django/contrib/auth/hashers.py#L247-L299
In the
decodemethod you can see:This indicates that passwords are stored in the format:
Currently, we only share the last part of that; the
hashed_password.