Experiment with migration

Author: cdauth

server/src/database-backend/migrations.ts

@@ -819,23 +819,25 @@ export default class DatabaseBackendMigrations {
 		if (mapIdMigrationCompleted === "1") {
 			console.log("DB migration: Generate values for Map.id");
 
-			// Copy back readId to id, in case the last ID generation failed (otherwise we might create duplicate IDs below).
-			await queryInterface.bulkUpdate("Maps", { id: col("readId") }, {});
+			// Copy back readId to id, in case the last ID generation failed (otherwise the ID generation below would crash with duplicate
+			// primary keys).
+			// We prefix the ID so that existing IDs that happen to be a number don't collide with the IDs we generate.
+			await queryInterface.bulkUpdate("Maps", { id: fn("concat", "-", col("readId")) }, {});
 
 			const maps = await this.backend.maps.MapModel.findAll({
 				attributes: ["id"]
 			});
 
 			// First generate increasing ID numbers as strings in the existing column
-			// for (let i = 0; i < maps.length; i++) {
-			// 	await this.backend.maps.MapModel.update({
-			// 		id: `${i + 1}` as any
-			// 	}, {
-			// 		where: {
-			// 			id: maps[i].id
-			// 		}
-			// 	});
-			// }
+			for (let i = 0; i < maps.length; i++) {
+				await this.backend.maps.MapModel.update({
+					id: `${i + 1}` as any
+				}, {
+					where: {
+						id: maps[i].id
+					}
+				});
+			}
 
 			await this.backend.meta.setMeta("mapIdMigrationCompleted", "2");
 			mapIdMigrationCompleted = "2";