Skip to content

chore: disable assignee and label triggers until instruct mode is implemented#4

Merged
factory-arman merged 1 commit intomainfrom
varin/disable-assignee-label-triggers
Dec 16, 2025
Merged

chore: disable assignee and label triggers until instruct mode is implemented#4
factory-arman merged 1 commit intomainfrom
varin/disable-assignee-label-triggers

Conversation

@varin-nair-factory
Copy link
Copy Markdown
Collaborator

Assignee and label triggers were routing to review mode, which throws on non-PR contexts. Commented out the trigger logic until instruct mode can handle issue contexts.

  • Disabled trigger detection in src/github/validation/trigger.ts
  • Updated tests to expect triggers to be no-ops
  • Updated PRD to reflect planned status

@varin-nair-factory varin-nair-factory self-assigned this Dec 11, 2025
@factory-droid
Copy link
Copy Markdown
Contributor

factory-droid bot commented Dec 11, 2025

Droid finished @varin-nair-factory's task —— View job


Code Review Complete

No issues found in this PR. The changes cleanly disable the assignee and label triggers with:

  • Proper removal of unused imports (isIssuesAssignedEvent)
  • Updated destructuring to exclude unused inputs
  • Clear TODO comments explaining the rationale
  • Test updates reflecting the new expected behavior

All tests pass and TypeScript compiles without errors.

@factory-arman factory-arman merged commit 6ebe3b9 into main Dec 16, 2025
3 checks passed
@factory-arman factory-arman deleted the varin/disable-assignee-label-triggers branch December 16, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants