Skip to content

Commit d111d1a

Browse files
committed
Adds basic test for collector
1 parent 1f74911 commit d111d1a

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

factory/django.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ def _refresh_database_pks(cls, model_cls, objs):
226226
@classmethod
227227
def _bulk_create(cls, size, **kwargs):
228228
models_to_create = cls.build_batch(size, **kwargs)
229-
collector = Collector()
229+
collector = DependencyInsertOrderCollector()
230230
collector.collect(cls, models_to_create)
231231
collector.sort()
232232
for model_cls, objs in collector.data.items():
@@ -339,7 +339,7 @@ def _make_data(self, params):
339339
return thumb_io.getvalue()
340340

341341

342-
class Collector:
342+
class DependencyInsertOrderCollector:
343343
def __init__(self):
344344
# Initially, {model: {instances}}, later values become lists.
345345
self.data = defaultdict(list)

tests/test_django.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,16 @@ class Meta:
175175
level_2 = factory.SubFactory(Level2Factory)
176176

177177

178+
class DependencyInsertOrderCollector(django_test.TestCase):
179+
180+
def test_empty(self):
181+
collector = factory.django.DependencyInsertOrderCollector()
182+
collector.collect(Level2Factory, [])
183+
collector.sort()
184+
185+
self.assertEqual(collector.data, {})
186+
187+
178188
@unittest.skipIf(SKIP_BULK_INSERT, "bulk insert not supported by current db.")
179189
class DjangoBulkInsert(django_test.TestCase):
180190

0 commit comments

Comments
 (0)