Fix reading invalid configuration

Author: FalconNL93

WslToolbox.UI/App.xaml.cs

@@ -18,6 +18,7 @@
 using WslToolbox.UI.Core.Services;
 using WslToolbox.UI.Core.Sinks;
 using WslToolbox.UI.Extensions;
+using WslToolbox.UI.Helpers;
 using WslToolbox.UI.Services;
 using WslToolbox.UI.ViewModels;
 using WslToolbox.UI.Views.Modals;
@@ -130,7 +131,11 @@ public App()
 
         GetService<AppNotificationService>().Initialize();
 
+#if DEBUG
+        UnhandledException += App_DebugUnhandledException;
+#else
         UnhandledException += App_UnhandledException;
+#endif
     }
 
     private IHost Host { get; }
@@ -172,20 +177,37 @@ private void App_UnhandledException(object sender, UnhandledExceptionEventArgs e
         try
         {
             _logger.LogError(e.Exception, "An UI exception has occurred: {Message}", e.Message);
+            ShowExceptionDialog(e);
         }
         catch (Exception)
         {
             throw new Exception($"Unexpected error {e.Message}");
         }
+    }
 
 #if DEBUG
-        throw new Exception($"Unexpected error {e.Message}");
-#endif
+    private void App_DebugUnhandledException(object sender, UnhandledExceptionEventArgs e)
+    {
+        _logger.LogError(e.Exception, "An UI exception has occurred: {Message}", e.Message);
+        ShowExceptionDialog(e);
     }
+#endif
 
     protected override async void OnLaunched(LaunchActivatedEventArgs args)
     {
         base.OnLaunched(args);
         await GetService<IActivationService>().ActivateAsync(args);
     }
+
+    private void ShowExceptionDialog(UnhandledExceptionEventArgs e)
+    {
+        _logger.LogError(e.Exception, "An UI exception has occurred: {Message}", e.Message);
+        var errorMessage = $"An unhandled exception has occurred and the application must close.{Environment.NewLine}{Environment.NewLine}Log file is written to:{Environment.NewLine}{Toolbox.LogFile}, open log file?";
+
+        var messageboxResult = MessageBoxHelper.ShowError(errorMessage);
+        if (messageboxResult == MessageBoxResult.Yes)
+        {
+            ShellHelper.OpenFile(Toolbox.LogFile);
+        }
+    }
 }

WslToolbox.UI/Helpers/MessageBoxHelper.cs

@@ -0,0 +1,51 @@
+using System.Runtime.InteropServices;
+
+namespace WslToolbox.UI.Helpers;
+
+public static class MessageBoxHelper
+{
+    [DllImport("user32.dll", CharSet = CharSet.Unicode)]
+    static extern int MessageBox(IntPtr hInstance,
+        string lpText,
+        string lpCaption,
+        uint type
+    );
+
+    public static MessageBoxResult Show(string text, string title, uint type = MessageBoxTypes.MbOk)
+    {
+        var messagebox = MessageBox(0, text, title, type);
+
+        return (MessageBoxResult) messagebox;
+    }
+
+    public static MessageBoxResult Show(string text, uint type = MessageBoxTypes.MbOk)
+    {
+        return Show(text, string.Empty, type);
+    }
+
+    public static MessageBoxResult Show(string text)
+    {
+        return Show(text, string.Empty);
+    }
+
+    public static MessageBoxResult ShowError(string text, string title = "")
+    {
+        return Show(text, title, MessageBoxTypes.MbIconError + MessageBoxTypes.MbYesNo);
+    }
+}
+
+public static class MessageBoxTypes
+{
+    public const uint MbOk = 0x0;
+    public const uint MbIconAsterisk = 0x00000040;
+    public const uint MbYesNo = 0x00000004;
+    public const uint MbIconError = 0x00000010;
+}
+
+public enum MessageBoxResult
+{
+    Unknown = 0,
+    Ok = 1,
+    No = 7,
+    Yes = 6
+}

WslToolbox.UI/Services/WslConfigurationService.cs

@@ -31,20 +31,23 @@ public WslConfigModel GetConfig()
         var wsl2Section = new Wsl2ConfigSection();
         var wsl2SectionConfig = data.Sections.GetSectionData("wsl2")?.Keys.ToDictionary(x => x.KeyName, x => x.Value);
 
-        foreach (var wsl2SectionItem in wsl2SectionConfig)
+        if (wsl2SectionConfig != null)
         {
-            var configKey = wsl2Section.Settings.FirstOrDefault(x => string.Equals(x.Key, wsl2SectionItem.Key, StringComparison.CurrentCultureIgnoreCase));
-            if (configKey == null)
+            foreach (var wsl2SectionItem in wsl2SectionConfig)
             {
-                continue;
-            }
+                var configKey = wsl2Section.Settings.FirstOrDefault(x => string.Equals(x.Key, wsl2SectionItem.Key, StringComparison.CurrentCultureIgnoreCase));
+                if (configKey == null)
+                {
+                    continue;
+                }
 
-            configKey.Value = wsl2SectionItem.Value;
+                configKey.Value = wsl2SectionItem.Value;
+            }
         }
-
+        
         return new WslConfigModel
         {
-            Wsl2Section = wsl2Section,
+            Wsl2Section = wsl2Section
         };
     }