change compose files and removed the need for docker compose down

Author: MuhammadQadora

.github/workflows/test.yml

@@ -58,11 +58,25 @@ jobs:
         run: poetry install --no-interaction
 
       - name: install docker module for python
-        run: pip install docker
+        run: poetry add docker
 
+      - name: wait for nodes to connect to each other
+        run: while true;do (docker logs node0 | grep succeeded ) && ( docker logs node1 | grep succeeded ) && break ;done
+
+      - name: Get logs from node1
+        run: docker logs node0
+        
+      - name: Get logs from node1
+        run: docker logs node1
+
+      - name: Get logs from node5
+        run: docker logs node5
+
+      - name: Get logs from redis-server-2
+        run: docker logs redis-server-2
       - name: Run Tests
         run: poetry run pytest --cov --cov-report=xml
-
+          
       - name: Upload coverage
         uses: codecov/codecov-action@v5
         if: matrix.python == '3.10' && matrix.platform != 'macos-11'

docker/cluster-compose.yml

@@ -16,7 +16,7 @@ services:
           interval: 3s
           timeout: 10s
           retries: 10
-          start_period: 2s
+          start_period: 1s
     environment:
       REDIS_ARGS: "--port 5000 --cluster-enabled yes --cluster-port 16379 --cluster-preferred-endpoint-type hostname --cluster-config-file /data/nodes.conf --cluster-node-timeout 500 --cluster-announce-hostname node0"
 

docker/sentinel-compose.yml

@@ -84,7 +84,7 @@ services:
     networks:
       - redis-sentinel
     environment:
-      REDIS_ARGS:  "--port 6381 --replica-announce-ip redis-server-1 --replica-announce-port 6381 --replicaof redis-server-1 6380"
+      REDIS_ARGS:  "--port 6381 --replica-announce-ip redis-server-2 --replica-announce-port 6381 --replicaof redis-server-1 6380"
       BROWSER: 0
 
 networks:

tests/test_get_replica_connections.py

@@ -4,6 +4,7 @@
 from falkordb import FalkorDB
 import docker
 
+
 CLUSTER_PORT    = 5000
 STANDALONE_PORT = 6379
 SENTINEL_PORT   = 26379
@@ -43,9 +44,8 @@ def stop_replicas(client):
         stop_container(name)
 
 def start_replicas(replicas: list):
-    for i in replicas:
-        name = i[0]
-        start_container(name)
+    for replica in replicas:
+        start_container(replica)
 
 def test_get_replica_connections_cluster():
     c = cluster_client()
@@ -77,7 +77,7 @@ def test_get_replica_connections_cluster_no_replicas():
 def test_get_replica_connections_sentinel_no_replicas():
     # Assume this Sentinel setup has no replicas
     stop_replicas(sentinel_client())
-    time.sleep(40)
+    time.sleep(2)
     c = sentinel_client()
     assert c.get_replica_connections() == []
     start_replicas(["redis-server-2"])