Memory Snapshot Refactor (Metafiles)

Author: FallenDev

Zolian.Server.Base/Meta/Metafile.cs

@@ -22,13 +22,20 @@ protected override void Load(MemoryStream stream)
 
             for (var i = 0; i < length; i++)
             {
-                var node = new MetafileNode(reader.ReadStringA());
+                var name = reader.ReadStringA();
                 var atomSize = reader.ReadUInt16();
 
+                if (atomSize == 0)
+                {
+                    Nodes.Add(new MetafileNode(name));
+                    continue;
+                }
+
+                var atoms = new string[atomSize];
                 for (var j = 0; j < atomSize; j++)
-                    node.Atoms.Add(reader.ReadStringB());
+                    atoms[j] = reader.ReadStringB();
 
-                Nodes.Add(node);
+                Nodes.Add(new MetafileNode(name, atoms));
             }
         }
 
@@ -44,7 +51,7 @@ public override Stream Save(MemoryStream stream)
         foreach (var node in Nodes)
         {
             writer.WriteStringA(node.Name);
-            writer.Write((ushort)node.Atoms.Count);
+            writer.Write((ushort)node.Atoms.Length);
 
             foreach (var atom in node.Atoms)
                 writer.WriteStringB(atom);

Zolian.Server.Base/Models/MetafileNode.cs

@@ -1,16 +1,13 @@
-using System.Collections.Specialized;
-
-namespace Darkages.Models;
+namespace Darkages.Models;
 
 public class MetafileNode
 {
     public MetafileNode(string name, params string[] atoms)
     {
         Name = name;
-        Atoms = new StringCollection();
-        Atoms.AddRange(atoms);
+        Atoms = atoms ?? [];
     }
 
-    public StringCollection Atoms { get; }
+    public string[] Atoms { get; }
     public string Name { get; }
 }