BodyAnimation Coalescer

Author: FallenDev

Zolian.Server.Base/Network/Client/Coalescer/BodyAnimationCoalescer.cs

@@ -0,0 +1,97 @@
+using System.Collections.Concurrent;
+
+using Chaos.Networking.Entities.Server;
+
+namespace Darkages.Network.Client.Coalescer;
+
+public sealed class BodyAnimationCoalescer : IDisposable
+{
+    private readonly Action<BodyAnimationArgs> _sendImmediate;
+    private readonly int _windowMs;
+    private readonly int _maxPerWindow;
+
+    // Latest-wins per SourceId
+    private readonly ConcurrentDictionary<uint, BodyAnimationArgs> _pending = new();
+
+    private int _flushScheduled; // 0/1
+    private CancellationTokenSource? _cts;
+
+    public BodyAnimationCoalescer(Action<BodyAnimationArgs>? sendImmediate, int windowMs = 50, int maxPerWindow = 32)
+    {
+        // Default no-op
+        sendImmediate ??= static _ => { };
+
+        _sendImmediate = sendImmediate;
+        _windowMs = windowMs <= 0 ? 30 : windowMs;
+        _maxPerWindow = maxPerWindow <= 0 ? 64 : maxPerWindow;
+    }
+
+    public void Enqueue(BodyAnimationArgs args)
+    {
+        // Dedupe: if the newest is identical to what we already have pending for this SourceId, kick out
+        if (_pending.TryGetValue(args.SourceId, out var existing) && AreEquivalent(existing, args))
+            return;
+
+        // Latest wins for this SourceId
+        _pending[args.SourceId] = args;
+
+        // Schedule one flush task per window
+        if (Interlocked.Exchange(ref _flushScheduled, 1) == 0)
+        {
+            _cts ??= new CancellationTokenSource();
+            _ = FlushAfterDelayAsync(_cts.Token);
+        }
+    }
+
+    private static bool AreEquivalent(BodyAnimationArgs a, BodyAnimationArgs b)
+        => a.BodyAnimation == b.BodyAnimation
+           && a.AnimationSpeed == b.AnimationSpeed
+           && a.Sound == b.Sound;
+
+    private async Task FlushAfterDelayAsync(CancellationToken ct)
+    {
+        try
+        {
+            await Task.Delay(_windowMs, ct).ConfigureAwait(false);
+
+            // Send at most _maxPerWindow unique SourceIds this tick
+            var sent = 0;
+
+            foreach (var kv in _pending)
+            {
+                if (sent >= _maxPerWindow)
+                    break;
+
+                if (_pending.TryRemove(kv.Key, out var args))
+                {
+                    _sendImmediate(args);
+                    sent++;
+                }
+            }
+
+            // Hard cap protection: drop any remaining this window
+            if (!_pending.IsEmpty)
+                _pending.Clear();
+        }
+        catch (OperationCanceledException) { }
+        finally
+        {
+            // Allow another window to schedule
+            Interlocked.Exchange(ref _flushScheduled, 0);
+
+            // If more arrived after finished, schedule again
+            if (!_pending.IsEmpty && Interlocked.Exchange(ref _flushScheduled, 1) == 0)
+            {
+                _ = FlushAfterDelayAsync(ct);
+            }
+        }
+    }
+
+    public void Dispose()
+    {
+        _cts?.Cancel();
+        _cts?.Dispose();
+        _cts = null;
+        _pending.Clear();
+    }
+}

Zolian.Server.Base/Network/Client/Coalescer/SoundCoalescer.cs

@@ -75,7 +75,7 @@ private async Task FlushAfterDelayAsync(CancellationToken ct)
                 }
             }
 
-            // Hard cap protection: drop anything still pending this window
+            // Hard cap protection: drop any remaining this window
             if (!_pending.IsEmpty)
                 _pending.Clear();
         }

Zolian.Server.Base/Network/Client/WorldClient.cs

@@ -62,6 +62,7 @@ public class WorldClient : WorldClientBase, IWorldClient
     private readonly IWorldServer<WorldClient> _server;
     private readonly SoundCoalescer _soundCoalescer;
     private readonly HealthBarCoalescer _healthBarCoalescer;
+    private readonly BodyAnimationCoalescer _bodyAnimationCoalescer;
 
     public readonly WorldServerTimer SkillSpellTimer = new(TimeSpan.FromMilliseconds(1000));
     public readonly Stopwatch CooldownControl = new();
@@ -172,6 +173,7 @@ public WorldClient([NotNull] IWorldServer<IWorldClient> server, [NotNull] Socket
         _server = server;
         _soundCoalescer = new SoundCoalescer(SendSoundImmediate, 150, 32);
         _healthBarCoalescer = new HealthBarCoalescer(SendHealthBarCoalesced, 150, 32);
+        _bodyAnimationCoalescer = new BodyAnimationCoalescer(SendBodyAnimationCoalesced, 150, 32);
 
         // Event-Driven Tasks
         Task.Factory.StartNew(ProcessExperienceEvents, TaskCreationOptions.LongRunning);
@@ -1720,6 +1722,11 @@ public void SendBoardResponse(BoardOrResponseType responseType, string message,
         Send(args);
     }
 
+    /// <summary>
+    /// 0x1A - Player Body Animation - Coalesced Send
+    /// </summary>
+    private void SendBodyAnimationCoalesced(BodyAnimationArgs args) => Send(args);
+
     /// <summary>
     /// 0x1A - Player Body Animation
     /// </summary>
@@ -1735,7 +1742,7 @@ public void SendBodyAnimation(uint id, BodyAnimation bodyAnimation, ushort speed
             AnimationSpeed = speed
         };
 
-        Send(args);
+        _bodyAnimationCoalescer.Enqueue(args);
     }
 
     /// <summary>