Refactor bank stack withdraw logic

- Reworked bank stacked withdraw flow to be DB-authoritative with cache reconciliation
- Added inventory rails to prevent over-withdraw, slot overflow, and multi-stack loss
- Implemented merge-first logic with fallback to empty inventory slot when required
- Ensured consistent behavior across NPC withdraw, bundled withdraw, and edge cases
- Left SQL procedures unchanged; correctness enforced at code boundary

- Introduced PlayerSaveDirty flag on Aisling to track unsaved state
- Added PlayerDirtySaveComponent to persist only dirty players on a short interval
- Dirty flag is set on GiveTo() and cleared after successful DB commit
- Avoids unnecessary full-server saves while preserving crash safety guarantees

Overall:
- Banking is now deterministic, loss-safe, and MMO-consistent
- Player saving is more granular, efficient, and intention-driven

Author: FallenDev

Server.Configurations/ZolianPlayers/PlayersDatabaseBuild.sql

@@ -402,6 +402,9 @@ private async Task PlayerSaveRoutine(Aisling player, CancellationToken ct)
             await ExecTvpAsync(conn, tx, "DeBuffSave", "@Debuffs", "dbo.DebuffType", debuffDt, ct).ConfigureAwait(false);
 
             await tx.CommitAsync(ct).ConfigureAwait(false);
+
+            // Player has a synced database state
+            player.PlayerSaveDirty = false;
         }
         catch (Exception e)
         {

Zolian.Server.Base/Database/AislingStorage.cs

@@ -22,6 +22,24 @@ public static string QualityToString(Item.Quality e)
         };
     }
 
+    public static Item.Quality StringToQuality(string? value)
+    {
+        return value switch
+        {
+            "Damaged" => Item.Quality.Damaged,
+            "Common" => Item.Quality.Common,
+            "Uncommon" => Item.Quality.Uncommon,
+            "Rare" => Item.Quality.Rare,
+            "Epic" => Item.Quality.Epic,
+            "Legendary" => Item.Quality.Legendary,
+            "Forsaken" => Item.Quality.Forsaken,
+            "Mythic" => Item.Quality.Mythic,
+            "Primordial" => Item.Quality.Primordial,
+            "Transcendent" => Item.Quality.Transcendent,
+            _ => Item.Quality.Common
+        };
+    }
+
     public static string PaneToString(Item.ItemPanes e)
     {
         return e switch
@@ -35,6 +53,19 @@ public static string PaneToString(Item.ItemPanes e)
         };
     }
 
+    public static Item.ItemPanes StringToPane(string? value)
+    {
+        return value switch
+        {
+            "Ground" => Item.ItemPanes.Ground,
+            "Inventory" => Item.ItemPanes.Inventory,
+            "Equip" => Item.ItemPanes.Equip,
+            "Bank" => Item.ItemPanes.Bank,
+            "Archived" => Item.ItemPanes.Archived,
+            _ => Item.ItemPanes.Ground
+        };
+    }
+
     public static string ArmorVarianceToString(Item.Variance e)
     {
         return e switch
@@ -57,6 +88,28 @@ public static string ArmorVarianceToString(Item.Variance e)
         };
     }
 
+    public static Item.Variance StringToArmorVariance(string? value)
+    {
+        return value switch
+        {
+            "None" => Item.Variance.None,
+            "Embunement" => Item.Variance.Embunement,
+            "Blessing" => Item.Variance.Blessing,
+            "Mana" => Item.Variance.Mana,
+            "Gramail" => Item.Variance.Gramail,
+            "Deoch" => Item.Variance.Deoch,
+            "Ceannlaidir" => Item.Variance.Ceannlaidir,
+            "Cail" => Item.Variance.Cail,
+            "Fiosachd" => Item.Variance.Fiosachd,
+            "Glioca" => Item.Variance.Glioca,
+            "Luathas" => Item.Variance.Luathas,
+            "Sgrios" => Item.Variance.Sgrios,
+            "Reinforcement" => Item.Variance.Reinforcement,
+            "Spikes" => Item.Variance.Spikes,
+            _ => Item.Variance.None
+        };
+    }
+
     public static string WeaponVarianceToString(Item.WeaponVariance e)
     {
         return e switch
@@ -79,6 +132,28 @@ public static string WeaponVarianceToString(Item.WeaponVariance e)
         };
     }
 
+    public static Item.WeaponVariance StringToWeaponVariance(string? value)
+    {
+        return value switch
+        {
+            "None" => Item.WeaponVariance.None,
+            "Bleeding" => Item.WeaponVariance.Bleeding,
+            "Rending" => Item.WeaponVariance.Rending,
+            "Aegis" => Item.WeaponVariance.Aegis,
+            "Reaping" => Item.WeaponVariance.Reaping,
+            "Vampirism" => Item.WeaponVariance.Vampirism,
+            "Ghosting" => Item.WeaponVariance.Ghosting,
+            "Haste" => Item.WeaponVariance.Haste,
+            "Gust" => Item.WeaponVariance.Gust,
+            "Quake" => Item.WeaponVariance.Quake,
+            "Rain" => Item.WeaponVariance.Rain,
+            "Flame" => Item.WeaponVariance.Flame,
+            "Dusk" => Item.WeaponVariance.Dusk,
+            "Dawn" => Item.WeaponVariance.Dawn,
+            _ => Item.WeaponVariance.None
+        };
+    }
+
     public static string GearEnhancementToString(Item.GearEnhancements e)
     {
         return e switch
@@ -94,6 +169,21 @@ public static string GearEnhancementToString(Item.GearEnhancements e)
         };
     }
 
+    public static Item.GearEnhancements StringToGearEnhancement(string? value)
+    {
+        return value switch
+        {
+            "None" => Item.GearEnhancements.None,
+            "One" => Item.GearEnhancements.One,
+            "Two" => Item.GearEnhancements.Two,
+            "Three" => Item.GearEnhancements.Three,
+            "Four" => Item.GearEnhancements.Four,
+            "Five" => Item.GearEnhancements.Five,
+            "Six" => Item.GearEnhancements.Six,
+            _ => Item.GearEnhancements.None
+        };
+    }
+
     public static string ItemMaterialToString(Item.ItemMaterials e)
     {
         return e switch
@@ -115,4 +205,26 @@ public static string ItemMaterialToString(Item.ItemMaterials e)
             _ => "None"
         };
     }
+
+    public static Item.ItemMaterials StringToItemMaterial(string? value)
+    {
+        return value switch
+        {
+            "None" => Item.ItemMaterials.None,
+            "Copper" => Item.ItemMaterials.Copper,
+            "Iron" => Item.ItemMaterials.Iron,
+            "Steel" => Item.ItemMaterials.Steel,
+            "Forged" => Item.ItemMaterials.Forged,
+            "Elven" => Item.ItemMaterials.Elven,
+            "Dwarven" => Item.ItemMaterials.Dwarven,
+            "Mythril" => Item.ItemMaterials.Mythril,
+            "Hybrasyl" => Item.ItemMaterials.Hybrasyl,
+            "Ebony" => Item.ItemMaterials.Ebony,
+            "Chaos" => Item.ItemMaterials.Chaos,
+            "MoonStone" => Item.ItemMaterials.MoonStone,
+            "SunStone" => Item.ItemMaterials.SunStone,
+            "Runic" => Item.ItemMaterials.Runic,
+            _ => Item.ItemMaterials.None
+        };
+    }
 }