Skip to content

Mishap for "no placeable block in hotbar" is both untranslated and misleadingΒ #977

@Robotgiggle

Description

@Robotgiggle

Minecraft version

1.20.1

Hex Casting version

0.11.3

Issue description

If no placeable item can be found in your hotbar, Place Block will throw MishapBadOffhandItem.of(ItemStack.EMPTY, "placeable"). The lang key this generates, hexcasting.mishap.bad_item.placeable, does not exist, leading to the following mishap message:
Image
Furthermore, even if the lang key did exist, this message would still be misleading. It claims that the spell needed something in the offhand that wasn't present, but Place Block checks through your entire hotbar, not just the offhand.

Steps to reproduce

  1. Have no placeable items in your hotbar
  2. Try to cast Place Block
  3. Observe broken mishap message

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    πŸ“‹ Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions