Skip to content

Media Consumption Modifier attribute affects non-player proxy castersΒ #983

@Robotgiggle

Description

@Robotgiggle

Minecraft version

1.20.1

Hex Casting version

0.11.3

Issue description

The newly added media_consumption_modifier attribute applies to any cast where getCastingEntity() isn't null. This means that if a player has a modified media consumption value, the modification will also apply to spell circles that they activate or are bound to, and to Hexal wisps that they own.

This is rather unintuitive - why should a player attribute have any effect on the media consumption of automated constructs like circles? Furthermore, it can allow media duping when combined with addon patterns like Export Media that extract or transfer media from proxy casters.

I encountered this exact problem when adding a media discount effect to Hierophantics (Robotgiggle/hierophantics#11) and solved it by only applying the discount if the current environment is a PlayerBasedCastEnv. I would recommend a similar solution here.

Steps to reproduce

  1. Apply a media discount to yourself using the media_consumption_modifier attribute
  2. Observe that the discount also applies to spell circles that you activate
  3. Observe that the discount also applies to Hexal wisps that you own

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    πŸ“‹ Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions