-
Notifications
You must be signed in to change notification settings - Fork 110
Description
Minecraft version
1.20.1
Hex Casting version
0.11.3
Issue description
The newly added media_consumption_modifier attribute applies to any cast where getCastingEntity() isn't null. This means that if a player has a modified media consumption value, the modification will also apply to spell circles that they activate or are bound to, and to Hexal wisps that they own.
This is rather unintuitive - why should a player attribute have any effect on the media consumption of automated constructs like circles? Furthermore, it can allow media duping when combined with addon patterns like Export Media that extract or transfer media from proxy casters.
I encountered this exact problem when adding a media discount effect to Hierophantics (Robotgiggle/hierophantics#11) and solved it by only applying the discount if the current environment is a PlayerBasedCastEnv. I would recommend a similar solution here.
Steps to reproduce
- Apply a media discount to yourself using the
media_consumption_modifierattribute - Observe that the discount also applies to spell circles that you activate
- Observe that the discount also applies to Hexal wisps that you own
Metadata
Metadata
Assignees
Labels
Type
Projects
Status