Skip to content

Commit 203f3a6

Browse files
committed
move mod metadata to mcmod.info and dynamically load it in the code
1 parent b8985d8 commit 203f3a6

File tree

3 files changed

+20
-16
lines changed

3 files changed

+20
-16
lines changed

src/main/java/com/falsepattern/lib/internal/FalsePatternLib.java

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
package com.falsepattern.lib.internal;
22

3+
import com.falsepattern.lib.util.ResourceUtil;
34
import com.google.common.eventbus.EventBus;
45
import cpw.mods.fml.common.DummyModContainer;
56
import cpw.mods.fml.common.LoadController;
7+
import cpw.mods.fml.common.MetadataCollection;
68
import cpw.mods.fml.common.ModMetadata;
79
import lombok.Getter;
810
import lombok.val;
@@ -23,17 +25,8 @@ public class FalsePatternLib extends DummyModContainer {
2325
private static final boolean developerEnvironment = (boolean) Launch.blackboard.get("fml.deobfuscatedEnvironment");
2426

2527
public FalsePatternLib() {
26-
super(new ModMetadata());
27-
log.info("All your libraries are belong to us!");
28-
val meta = getMetadata();
29-
meta.modId = Tags.MODID;
30-
meta.name = Tags.MODNAME;
31-
meta.version = Tags.VERSION;
32-
meta.url = Tags.URL;
33-
meta.credits = Tags.CREDITS;
34-
meta.authorList = Arrays.asList(Tags.AUTHORS);
35-
meta.description = Tags.DESCRIPTION;
36-
meta.useDependencyInformation = true;
28+
super(MetadataCollection.from(ResourceUtil.getResourceFromJar("/mcmod.info", FalsePatternLib.class), Tags.MODID).getMetadataForId(Tags.MODID, null));
29+
log.info("Version " + Tags.VERSION + " initialized!");
3730
}
3831

3932
@SuppressWarnings("UnstableApiUsage")

src/main/java/com/falsepattern/lib/internal/Tags.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,4 @@ public class Tags {
55
public static final String MODNAME = "GRADLETOKEN_MODNAME";
66
public static final String VERSION = "GRADLETOKEN_VERSION";
77
public static final String GROUPNAME = "GRADLETOKEN_GROUPNAME";
8-
9-
public static final String URL = "https://github.com/FalsePattern/FalsePatternLib";
10-
public static final String CREDITS = "";
11-
public static final String[] AUTHORS = new String[]{"FalsePattern"};
12-
public static final String DESCRIPTION = "FalsePattern's library mod.";
138
}

src/main/resources/mcmod.info

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
[
2+
{
3+
"modid": "${modId}",
4+
"name": "${modName}",
5+
"description": "FalsePattern's library.",
6+
"version": "${modVersion}",
7+
"mcversion": "${minecraftVersion}",
8+
"url": "https://github.com/FalsePattern/FalsePatternLib",
9+
"updateUrl": "",
10+
"authorList": ["FalsePattern"],
11+
"credits": "",
12+
"logoFile": "",
13+
"screenshots": [],
14+
"dependencies": []
15+
}
16+
]

0 commit comments

Comments
 (0)