update tracing enable flag

Author: asadkovich

cmd/opera/launcher/launcher.go

@@ -158,13 +158,12 @@ func initFlags() {
 		utils.MetricsInfluxDBUsernameFlag,
 		utils.MetricsInfluxDBPasswordFlag,
 		utils.MetricsInfluxDBTagsFlag,
-		tracing.EnableFlag,
 	}
 
 	tracingFlags = []cli.Flag{
 		tracing.EnableFlag,
 		tracing.AgentEndpointFlag,
-		tracing.DevelopmentFlag,
+		tracing.EnableDevFlag,
 	}
 
 	nodeFlags = []cli.Flag{}

cmd/opera/launcher/tracing/tracing.go

@@ -19,22 +19,22 @@ var (
 		Usage: "Enable traces collection and reporting",
 	}
 
+	EnableDevFlag = cli.BoolFlag{
+		Name:  "tracing.dev",
+		Usage: "Enable traces collection and reporting in development mode",
+	}
+
 	AgentEndpointFlag = cli.StringFlag{
 		Name:  "tracing.agent",
 		Usage: "Jaeger agent endpoint. Default is localhost:6831",
 		Value: "localhost:6831",
 	}
 
-	DevelopmentFlag = cli.BoolFlag{
-		Name:  "tracing.dev",
-		Usage: "Use development Jaeger configuration",
-	}
-
 	ErrInvalidEndpoint = errors.New("invalid agent endpoint")
 )
 
 func Start(ctx *cli.Context) (func(), error) {
-	if !ctx.Bool(EnableFlag.Name) {
+	if !ctx.Bool(EnableFlag.Name) && !ctx.Bool(EnableDevFlag.Name) {
 		return func() {}, nil
 	}
 
@@ -51,7 +51,7 @@ func Start(ctx *cli.Context) (func(), error) {
 		},
 	}
 
-	if ctx.Bool(DevelopmentFlag.Name) {
+	if ctx.Bool(EnableDevFlag.Name) {
 		// Makes sampler collect and report all traces
 		cfg.Sampler = &jaegercfg.SamplerConfig{
 			Type:  jaeger.SamplerTypeConst,

demo/start.sh

@@ -24,6 +24,7 @@ do
 	--fakenet=${ACC}/$N \
 	--port=${PORT} \
 	--nat extip:127.0.0.1 \
+  --tracing.dev \
 	--http --http.addr="127.0.0.1" --http.port=${RPCP} --http.corsdomain="*" --http.api="eth,debug,net,admin,web3,personal,txpool,ftm,dag" \
 	--ws --ws.addr="127.0.0.1" --ws.port=${WSP} --ws.origins="*" --ws.api="eth,debug,net,admin,web3,personal,txpool,ftm,dag" \
 	--nousb --verbosity=3 --tracing &>> opera$i.log)&