Remove unnecessary virtual methods

Mike-CZ · Mike-CZ · commit 395cb5aef7d9 · 2025-01-31T15:01:14.000+01:00
diff --git a/contracts/sfc/ConstantsManager.sol b/contracts/sfc/ConstantsManager.sol
@@ -139,7 +139,7 @@ contract ConstantsManager is Ownable {
         offlinePenaltyThresholdBlocksNum = v;
     }
 
-    function updateAverageUptimeEpochWindow(uint32 v) external virtual onlyOwner {
+    function updateAverageUptimeEpochWindow(uint32 v) external onlyOwner {
         if (v < 10) {
             // needs to be long enough to allow permissible downtime for validators maintenance
             revert ValueTooSmall();
@@ -157,7 +157,7 @@ contract ConstantsManager is Ownable {
         minAverageUptime = v;
     }
 
-    function updateIssuedTokensRecipient(address v) external virtual onlyOwner {
+    function updateIssuedTokensRecipient(address v) external onlyOwner {
         issuedTokensRecipient = v;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ contract ConstantsManager is Ownable {`
`139`	`139`	`offlinePenaltyThresholdBlocksNum = v;`
`140`	`140`	`}`
`141`	`141`
`142`		`- function updateAverageUptimeEpochWindow(uint32 v) external virtual onlyOwner {`
	`142`	`+ function updateAverageUptimeEpochWindow(uint32 v) external onlyOwner {`
`143`	`143`	`if (v < 10) {`
`144`	`144`	`// needs to be long enough to allow permissible downtime for validators maintenance`
`145`	`145`	`revert ValueTooSmall();`
`@@ -157,7 +157,7 @@ contract ConstantsManager is Ownable {`
`157`	`157`	`minAverageUptime = v;`
`158`	`158`	`}`
`159`	`159`
`160`		`- function updateIssuedTokensRecipient(address v) external virtual onlyOwner {`
	`160`	`+ function updateIssuedTokensRecipient(address v) external onlyOwner {`
`161`	`161`	`issuedTokensRecipient = v;`
`162`	`162`	`}`
`163`	`163`	`}`