[OZ][L-02] Transfer and send Calls Are No Longer Considered Best Practice (#111)

Mike-CZ · web-flow · commit 86add7e79f9b · 2025-01-31T14:55:24.000+01:00
diff --git a/contracts/sfc/SFC.sol b/contracts/sfc/SFC.sol
@@ -835,7 +835,10 @@ contract SFC is OwnableUpgradeable, UUPSUpgradeable, Version {
                 revert ValueTooLarge();
             }
             totalSupply -= amount;
-            payable(address(0)).transfer(amount);
+            (bool sent, ) = payable(address(0)).call{value: amount}("");
+            if (!sent) {
+                revert TransferFailed();
+            }
             emit BurntNativeTokens(amount);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -835,7 +835,10 @@ contract SFC is OwnableUpgradeable, UUPSUpgradeable, Version {`
`835`	`835`	`revert ValueTooLarge();`
`836`	`836`	`}`
`837`	`837`	`totalSupply -= amount;`
`838`		`- payable(address(0)).transfer(amount);`
	`838`	`+ (bool sent, ) = payable(address(0)).call{value: amount}("");`
	`839`	`+ if (!sent) {`
	`840`	`+ revert TransferFailed();`
	`841`	`+ }`
`839`	`842`	`emit BurntNativeTokens(amount);`
`840`	`843`	`}`
`841`	`844`	`}`