[fix] : Fixed shellcheck warnings

Author: Hayao0819

tools/docker-build.sh

@@ -14,7 +14,7 @@ EOF
     exit 1
 fi
 
-script_path="$(cd -P $(dirname $(readlink -f ${0})) && cd .. && pwd)"
+script_path="$( cd -P "$( dirname "$(readlink -f "$0")" )" && cd .. && pwd )"
 
 _usage () {
     echo "usage ${0} [options]"

tools/fullbuild.sh

@@ -156,7 +156,7 @@ unset OPT OPTS OPTL ARGUMENT
 while true; do
     case "${1}" in
         -a)
-            share_options+=(${2})
+            IFS=" " read -r -a share_options <<< "${2}"
             shift 2
             ;;
         -c)
@@ -172,7 +172,7 @@ while true; do
             shift 1
             ;;
         -m)
-            architectures=(${2})
+            IFS=" " read -r -a architectures <<< "${2}"
             shift 2
             ;;
         -o)
@@ -200,7 +200,7 @@ while true; do
             share_options+=("--tarball")
             ;;
         -l)
-            locale_list=(${2})
+            IFS=" " read -r -a locale_list <<< "${2}"
             shift 2
             ;;
         -w)
@@ -238,7 +238,7 @@ if [[ "${all_channel}" = true  ]]; then
     if [[ -n "${*}" ]]; then
         msg_error "Do not specify the channel." "1"
     else
-        channels=($("${script_path}/tools/channel.sh" -b show))
+        readarray -t channels < <("${script_path}/tools/channel.sh" -b show)
     fi
 elif [[ -n "${*}" ]]; then
     channels=("${@}")
@@ -267,7 +267,7 @@ mkdir -p "${fullbuild_dir}"
 
 if [[ "$(find "${fullbuild_dir}" -maxdepth 1 -mindepth 1 -name "fullbuild.*" 2> /dev/null)" ]]; then
     msg_info "Do you want to reset lock files ? (y/N)"
-    read -n 1 _yes_or_no
+    read -r -n 1 _yes_or_no
     echo
     if [[ "${_yes_or_no}" = "y" ]] || [[ "${_yes_or_no}" = "Y" ]]; then
         find "${fullbuild_dir}" -maxdepth 1 -mindepth 1 -name "fullbuild.*" -delete 2> /dev/null
@@ -279,7 +279,7 @@ share_options+=("--work" "${work_dir}")
 msg_info "Options: ${share_options[*]}"
 if [[ "${noconfirm}" = false ]]; then
     msg_info "Press Enter to continue or Ctrl + C to cancel."
-    read
+    read -r
 fi
 
 
@@ -289,7 +289,7 @@ for arch in "${architectures[@]}"; do
     for cha in "${channels[@]}"; do
         for lang in "${locale_list[@]}"; do
             for retry_count in $(seq 1 "${retry}"); do
-                if [[ -n "$(cat "${script_path}/channels/${cha}/architecture" | grep -h -v ^'#' | grep -x "${arch}")" ]]; then
+                if grep -h -v ^'#' "${script_path}/channels/${cha}/architecture" | grep -x "${arch}" 1> /dev/null 2>&1; then
                     build
                 fi
             done

tools/kernel.sh

@@ -28,14 +28,12 @@ _help() {
     echo
     echo " Script mode usage:"
     echo "     check                    Returns 0 if the check was successful, 1 otherwise."
-    printf '     get                      eval $(%s -s -a <arch> -c <channel> get <kernel>)\n' "$(basename ${0})"
+    printf '     get                      eval $(%s -s -a <arch> -c <channel> get <kernel>)\n' "$(basename "${0}")"
 }
 
 # Usage: getclm <number>
 # 標準入力から値を受けとり、引数で指定された列を抽出します。
-getclm() {
-    echo "$(cat -)" | cut -d " " -f "${1}"
-}
+getclm() { cut -d " " -f "${1}"; }
 
 # Message functions
 msg_error() {
@@ -55,7 +53,7 @@ gen_kernel_list() {
     else
         _list="${script_path}/system/kernel-${arch}"
     fi
-    for _kernel in $(grep -h -v ^'#' ${_list} | getclm 1); do 
+    for _kernel in $(grep -h -v ^'#' "${_list}" | getclm 1); do 
         kernellist+=("${_kernel}")
     done
 }
@@ -98,12 +96,12 @@ get() {
     else
         _kernel_config_file="${script_path}/system/kernel-${arch}"
     fi
-    _kernel_name_list=($(cat "${_kernel_config_file}" | grep -h -v ^'#' | getclm 1))
+    readarray -t _kernel_name_list < <(grep -h -v ^'#' "${_kernel_config_file}" | getclm 1)
     _get_kernel_line() {
         local _kernel _count=0
         for _kernel in "${_kernel_name_list[@]}"; do
             _count=$(( _count + 1 ))
-            if [[ "${_kernel}" = "${1}" ]]; then echo "${_count}"; return 0; fi
+            [[ "${_kernel}" = "${1}" ]] && echo "${_count}"
         done
         echo -n "failed"
         return 0
@@ -120,7 +118,7 @@ get() {
     fi
 
     # カーネル設定ファイルから該当の行を抽出
-    _kernel_config_line=($(cat "${_kernel_config_file}" | grep -h -v ^'#' | grep -v ^$ | head -n "${_kernel_line}" | tail -n 1))
+    readarray -t _kernel_config_line < <(grep -h -v ^'#' "${_kernel_config_file}" | grep -v ^$ | head -n "${_kernel_line}" | tail -n 1)
 
     # 抽出された行に書かれた設定をそれぞれの変数に代入
     # ここで定義された変数のみがグローバル変数