[fix] : Fixed SC2068

Author: Hayao0819

channels/i3/airootfs.any/etc/skel/.config/rofi/power.sh

@@ -22,7 +22,7 @@ declare -A menu_list=(
 
 function main() {
   local -r IFS=$'\n'
-  [[ $# -ne 0 ]] && eval "${menu_list[$1]}" || echo "${!menu_list[*]}"
+  [[ "${#}" -ne 0 ]] && eval "${menu_list[$1]}" || echo "${!menu_list[*]}"
 }
 
-main $@
+main "${@}"

modules/lightdm/airootfs.any/root/customize_airootfs_lightdm.sh

@@ -34,7 +34,7 @@ if [[ -f "/etc/lightdm/lightdm.conf.d/02-autologin-session.conf" ]] && cat "/etc
     else
         echo "Failed to set the session.Multiple sessions were found." >&2
         echo "Please set the session of automatic login in /etc/lightdm/lightdm.conf.d/02-autologin-session.conf"
-        echo "Found session: $(printf "%s " ${session_list[@]})"
+        echo "Found session: $(printf "%s " "${session_list[@]}")"
         sleep 0.5
         exit 1
     fi

system/pkgbuild.sh

@@ -66,7 +66,7 @@ function user_check () {
 
 # 一般ユーザーで実行します
 function run_user () {
-    sudo -u "${build_username}" ${@}
+    sudo -u "${build_username}" "${@}"
 }
 
 # 引数を確認
@@ -106,12 +106,12 @@ pacman -Syy "${pacman_args[@]}"
 cd "${pkgbuild_dir}"
 pkgbuild_dirs=($(ls "${pkgbuild_dir}" 2> /dev/null))
 if (( "${#pkgbuild_dirs[@]}" != 0 )); then
-    for _dir in ${pkgbuild_dirs[@]}; do
+    for _dir in "${pkgbuild_dirs[@]}"; do
         cd "${_dir}"
         depends=($(source "${pkgbuild_dir}/${_dir}/PKGBUILD"; echo "${depends[@]}"))
         makedepends=($(source "${pkgbuild_dir}/${_dir}/PKGBUILD"; echo "${makedepends[@]}"))
         if (( ${#depends[@]} + ${#makedepends[@]} != 0 )); then
-            for _pkg in ${depends[@]} ${makedepends[@]}; do
+            for _pkg in "${depends[@]}" "${makedepends[@]}"; do
                 if pacman -Ssq "${_pkg}" | grep -x "${_pkg}" 1> /dev/null; then
                     pacman -S --asdeps --needed "${pacman_args[@]}" "${_pkg}"
                 fi

tools/allpkglist.sh

@@ -79,7 +79,7 @@ fi
 
 load_config() {
     local _file
-    for _file in ${@}; do
+    for _file in "${@}"; do
         if [[ -f "${_file}" ]]; then
             source "${_file}"
         fi
@@ -89,7 +89,7 @@ load_config() {
 for_module(){
     local module
     for module in ${modules[@]}; do
-        eval $(echo ${@} | sed "s|{}|${module}|g")
+        eval $(echo "${@}" | sed "s|{}|${module}|g")
     done
 }
 
@@ -105,7 +105,7 @@ for arch in ${archs[@]}; do
                     modules=("share")
                 fi
             fi
-            for module in ${modules[@]}; do
+            for module in "${modules[@]}"; do
                 dependent="${module_dir}/${module}/dependent"
                 if [[ -f "${dependent}" ]]; then
                     modules+=($(grep -h -v ^'#' "${dependent}" | tr -d "\n" ))

tools/alteriso-info.sh

@@ -97,7 +97,7 @@ variable_list=(
     "iso_version"
 )
 
-for var in ${variable_list[@]}; do
+for var in "${variable_list[@]}"; do
     if [[ -z "$(eval echo '$'${var})" ]]; then
         echo "${var} is empty" >&2
         exit 1

tools/channel.sh

@@ -237,10 +237,10 @@ else
 fi
 
 case "${mode}" in
-    "check" ) check ${@}                  ;;
+    "check" ) check "${@}"                ;;
     "show"  ) show                        ;;
-    "desc"  ) desc ${@}                   ;;
-    "ver"   ) get_alteriso_version ${@}   ;;
+    "desc"  ) desc "${@}"                 ;;
+    "ver"   ) get_alteriso_version "${@}" ;;
     "help"  ) _help; exit 0               ;;
     *       ) _help; exit 1               ;;
 esac

tools/clean.sh

@@ -14,7 +14,7 @@ noconfirm=false
 # load_config [file1] [file2] ...
 load_config() {
     local _file
-    for _file in ${@}; do
+    for _file in "${@}"; do
         if [[ -f "${_file}" ]]; then
             source "${_file}"
         fi

tools/kernel-choice-conf-gen.sh

@@ -6,25 +6,9 @@ arch_list=(
     "i686"
 )
 
-# rm helper
-# Delete the file if it exists.
-# For directories, rm -rf is used.
-# If the file does not exist, skip it.
-# remove <file> <file> ...
-remove() {
-    local _list=($(echo "$@")) _file
-    for _file in "${_list[@]}"; do
-        if [[ -f "${_file}" ]]; then    
-            rm -f "${_file}"
-        elif [[ -d "${_file}" ]]; then
-            rm -rf "${_file}"
-        fi
-    done
-}
-
 #cd "${script_path}"
-for arch in ${arch_list[@]}; do
-    remove "${script_path}/menuconfig-script/kernel_choice_${arch}"
+for arch in "${arch_list[@]}"; do
+    rm -rf "${script_path}/menuconfig-script/kernel_choice_${arch}"
     for kernel in $(bash "${script_path}/tools/kernel.sh" -a "${arch}" show ); do
         echo "config KERNEL_N_A_M_E_${kernel}" >> "${script_path}/menuconfig-script/kernel_choice_${arch}"
         echo -e "\tbool ${kernel}" >> "${script_path}/menuconfig-script/kernel_choice_${arch}"

tools/kernel.sh

@@ -101,7 +101,7 @@ get() {
     _kernel_name_list=($(cat "${_kernel_config_file}" | grep -h -v ^'#' | getclm 1))
     _get_kernel_line() {
         local _kernel _count=0
-        for _kernel in ${_kernel_name_list[@]}; do
+        for _kernel in "${_kernel_name_list[@]}"; do
             _count=$(( _count + 1 ))
             if [[ "${_kernel}" = "${1}" ]]; then echo "${_count}"; return 0; fi
         done
@@ -175,9 +175,9 @@ else
 fi
 
 case "${mode}" in
-    "check" ) check ${@}    ;;
+    "check" ) check "${@}"  ;;
     "show"  ) show          ;;
-    "get"   ) get ${@}      ;;
+    "get"   ) get "${@}"    ;;
     "help"  ) _help; exit 0 ;;
     *       ) _help; exit 1 ;;
 esac

tools/keyring.sh

@@ -171,7 +171,7 @@ checkpkg() {
 
 run() {
     msg_info "Running ${*}"
-    ${@}
+    eval "${@}"
 }