small CI improvements

Author: FaserF

.github/scripts/check_relevance.py

@@ -1,6 +1,12 @@
 import subprocess
 import sys
 import os
+
+# Ensure the script's directory is in sys.path for git_utils import
+script_dir = os.path.dirname(os.path.abspath(__file__))
+if script_dir not in sys.path:
+    sys.path.insert(0, script_dir)
+
 from git_utils import get_last_tag
 
 def has_relevant_changes(since_tag):

.github/scripts/generate_changelog.py

@@ -1,4 +1,14 @@
 import argparse
+import subprocess
+import os
+import re
+import sys
+
+# Ensure the script's directory is in sys.path for git_utils import
+script_dir = os.path.dirname(os.path.abspath(__file__))
+if script_dir not in sys.path:
+    sys.path.insert(0, script_dir)
+
 from git_utils import get_last_tag
 
 
@@ -47,7 +57,7 @@ def parse_commits(commits):
             categories["Styling"].append(commit)
         elif lower_commit.startswith("docs"):
             categories["Documentation"].append(commit)
-        elif lower_commit.startswith(tuple(["chore", "refactor", "test", "ci", "build"])):
+        elif lower_commit.startswith(("chore", "refactor", "test", "ci", "build")):
             categories["Maintenance"].append(commit)
         else:
             # Filter out merge commits from "Other" list if we want clean output

.github/workflows/weekly.yml

@@ -20,15 +20,17 @@ jobs:
           python-version: '3.14'
       - name: Check for relevant changes
         id: check
-        run: |
-          RELEVANCE=$(python .github/scripts/check_relevance.py | grep "relevance=" | cut -d= -f2)
-          echo "relevance=$RELEVANCE" >> "$GITHUB_OUTPUT"
+        run: python .github/scripts/check_relevance.py
 
   trigger_release:
     needs: check_relevance
     if: needs.check_relevance.outputs.relevance == 'true'
     runs-on: ubuntu-latest
+    permissions:
+      workflows: write
     steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
       - name: Trigger Release Workflow
         run: |
           gh workflow run release.yml -f release_type=development

src/switchcraft/gui_modern/utils/view_utils.py

@@ -41,7 +41,9 @@ def _open_path(self, path):
         except Exception as e:
             logger.debug(f"Default opener failed, falling back to webbrowser: {e}")
             try:
-                webbrowser.open(f"file:///{path}")
+                from pathlib import Path
+                uri = Path(path).as_uri()
+                webbrowser.open(uri)
             except Exception as e2:
                 self._show_snack(f"Failed to open path: {path}", "RED")
                 logger.error(f"Failed to open path: {e2}")
@@ -60,12 +62,12 @@ def _close_dialog(self, dialog=None):
             if hasattr(page, "close"):
                 try:
                     page.close(dialog)
-                except:
+                except Exception:
                     pass
             elif hasattr(page, "close_dialog"):
                 try:
                     page.close_dialog()
-                except:
+                except Exception:
                     pass
 
             page.update()

src/switchcraft/gui_modern/views/addon_manager_view.py

@@ -140,22 +140,21 @@ def _bg():
                     if self.addon_service.delete_addon(aid) is False:
                          self._show_snack("Delete failed (File in use?)", "RED")
                     else:
-                        self._show_snack("Addon deleted.", "GREEN")
-                        self.selected_addon = None
-                        self._close_dialog(self.import_dlg)
-                        self._load_data()
+                         self._show_snack("Addon deleted.", "GREEN")
+                         self.selected_addon = None
+                         self._close_dialog(self.import_dlg)
+                         self._load_data()
                 except Exception as ex:
                      self._show_snack(f"Delete failed: {ex}", "RED")
             threading.Thread(target=_bg, daemon=True).start()
 
-        dlg = ft.AlertDialog(
+        self.import_dlg = ft.AlertDialog(
             title=ft.Text("Confirm Deletion"),
             content=ft.Text(f"Delete addon '{self.selected_addon.get('name')}'?"),
             actions=[
                 ft.TextButton("Cancel", on_click=close_dlg),
                 ft.Button("Delete", on_click=delete, bgcolor="RED", color="WHITE")
             ]
         )
-        self.app_page.dialog = dlg
-        dlg.open = True
+        self.app_page.open(self.import_dlg)
         self.app_page.update()

src/switchcraft/gui_modern/views/analyzer_view.py

@@ -950,7 +950,12 @@ def open_winget_manager(e):
             content=ft.Column([
                 ft.Text("Quickly generate a local manifest structure based on analysis results."),
                 ft.Text(f"Target: {info.manufacturer}.{info.product_name}", size=12, italic=True),
-            ], height=80, tight=True),
+                ft.Container(height=5),
+                ft.Row([
+                    ft.Icon(ft.Icons.WARNING_AMBER, color="ORANGE", size=16),
+                    ft.Text("Note: Manifests use a placeholder SHA256. Manual update required before submission.", size=11, color="ORANGE", italic=True)
+                ], vertical_alignment=ft.CrossAxisAlignment.CENTER)
+            ], height=110, tight=True),
             actions=[
                 ft.TextButton("Cancel", on_click=lambda _: setattr(dlg, "open", False) or self.app_page.update()),
                 ft.TextButton("Open Manager", on_click=open_winget_manager),
@@ -1026,17 +1031,8 @@ def _bg():
 
                 # Show success dialog
                 def open_folder(e):
-                    import os
-                    import sys
-                    import subprocess
-
                     try:
-                        if sys.platform == "win32":
-                            self._open_path(str(source))
-                        elif sys.platform == "darwin":
-                            subprocess.call(["open", str(source)])
-                        else:
-                            subprocess.call(["xdg-open", str(source)])
+                        self._open_path(str(source))
                     except Exception as ex:
                         self._show_snack(f"Failed to open folder: {ex}", "RED")
 

src/switchcraft/gui_modern/views/group_manager_view.py

@@ -424,12 +424,12 @@ def _bg():
                         self._show_snack(f"Failed to add member: {ex}", "RED")
                 threading.Thread(target=_bg, daemon=True).start()
 
-            add_dlg = ft.AlertDialog(
+            self.dlg_add_member = ft.AlertDialog(
                 title=ft.Text(i18n.get("dlg_add_member") or "Add Member"),
                 content=ft.Column([search_box, results_list], height=300, width=400),
-                actions=[ft.TextButton(i18n.get("btn_close") or "Close", on_click=lambda e: self._close_dialog(self.app_page.dialog))]
+                actions=[ft.TextButton(i18n.get("btn_close") or "Close", on_click=lambda e: self._close_dialog(self.dlg_add_member))]
             )
-            self.app_page.open(add_dlg)
+            self.app_page.open(self.dlg_add_member)
             self.app_page.update()
 
         title_tmpl = i18n.get("members_title") or "Members: {group}"

src/switchcraft/gui_modern/views/library_view.py

@@ -1,6 +1,7 @@
 import flet as ft
 from switchcraft.utils.config import SwitchCraftConfig
 from switchcraft.utils.i18n import i18n
+from switchcraft.gui_modern.utils.view_utils import ViewMixin
 
 import logging
 from datetime import datetime
@@ -11,7 +12,7 @@
 logger = logging.getLogger(__name__)
 
 
-class LibraryView(ft.Column):
+class LibraryView(ft.Column, ViewMixin):
     """Library view that displays recent .intunewin packages."""
 
     def __init__(self, page: ft.Page):
@@ -301,16 +302,9 @@ def _on_tile_click(self, item):
 
     def _open_folder(self, path):
         """Open the folder containing the file."""
-
-        import subprocess
         try:
             folder = os.path.dirname(path)
-            if sys.platform == "win32":
-                self._open_path(folder)
-            elif sys.platform == "darwin":
-                subprocess.call(["open", folder])
-            else:
-                subprocess.call(["xdg-open", folder])
+            self._open_path(folder)
         except Exception as ex:
             logger.error(f"Failed to open folder: {ex}")
 

src/switchcraft/gui_modern/views/wingetcreate_view.py

@@ -688,11 +688,6 @@ def _open_manifest_dir(self, e):
         """Open the manifest directory in file explorer."""
         try:
             path = str(self.manifest_dir)
-            if sys.platform == "win32":
-                self._open_path(path)
-            elif sys.platform == "darwin":
-                subprocess.Popen(["open", path])
-            else:
-                subprocess.Popen(["xdg-open", path])
+            self._open_path(path)
         except Exception as ex:
             logger.error(f"Failed to open manifest dir: {ex}")

src/switchcraft/services/ai_service.py

@@ -1,4 +1,5 @@
 import logging
+import re
 from switchcraft.services.addon_service import AddonService
 from switchcraft.utils.i18n import i18n
 
@@ -22,7 +23,6 @@ def __init__(self):
         @staticmethod
         def _is_greeting(query: str) -> bool:
             """Check if the query is a greeting using regex word boundaries."""
-            import re
             q = query.lower()
             return bool(re.search(r'\b(hi|hello|hallo|hey|moin|servus)\b', q))