more CI fixes

Author: FaserF

.github/workflows/test.yml

@@ -15,7 +15,6 @@ jobs:
       fail-fast: true
       max-parallel: 1
       matrix:
-        os: [windows-latest]
         python-version: ["3.13", "3.14"]
 
     steps:
@@ -51,10 +50,7 @@ jobs:
       - name: Install Core (No GUI)
         run: |
            python -m pip install --upgrade pip
-           pip install .
-           # pip install pytest  <-- Included in .[test] or separate step if needed, but here we installed core only.
-           # Assuming we need pytest for testing:
-           pip install pytest
+           pip install .[test]
 
       - name: Run CLI Dynamic Tests
         run: |

src/switchcraft/assets/lang/de.json

@@ -558,7 +558,7 @@
     "deploying_apps": "Bereitstellen",
     "deploy_stack_note": "Hinweis: Diese Funktion erfordert konfigurierte Intune-Integration.",
     "btn_deploy": "Bereitstellen",
-    "deploy_stack_started": "Bereitstellung gestartet! Prüfen Sie Intune für den Fortschritt.",
+    "deploy_stack_started": "Bereitstellung gestartet! Prüfe Intune auf den Fortschritt.",
     "stacks_saved": "Stacks gespeichert!",
     "save_failed": "Speichern fehlgeschlagen",
     "script_management_title": "Script Management Center",
@@ -621,7 +621,7 @@
     "wingetcreate_info": "Manifeste werden im SwitchCraft-Datenverzeichnis gespeichert",
     "create_new_manifest": "Neues Winget-Manifest erstellen",
     "update_existing_manifest": "Bestehendes Winget-Paket aktualisieren",
-    "update_manifest_desc": "Aktualisieren Sie ein bestehendes Paket im winget-pkgs Repository mit einer neuen Version.",
+    "update_manifest_desc": "Aktualisiere ein bestehendes Paket im winget-pkgs Repository mit einer neuen Version.",
     "installer_urls": "Installer-URLs",
     "new_installer_urls": "Neue Installer-URL(s)",
     "package_id": "Paket-ID",
@@ -808,7 +808,7 @@
     "notif_test_sent": "Test-Benachrichtigung gesendet!",
     "ai_addon_required_title": "AI-Addon Erforderlich",
     "entra_group_manager_title": "Entra Gruppenmanager",
-    "entra_group_manager_desc": "Verwalten Sie Ihre Microsoft Entra ID (Azure AD) Gruppen.",
+    "entra_group_manager_desc": "Verwalte deine Microsoft Entra ID (Azure AD) Gruppen.",
     "col_name": "Name",
     "col_description": "Beschreibung",
     "col_id": "ID",
@@ -833,5 +833,6 @@
     "no_members": "Keine Mitglieder gefunden.",
     "no_users_found": "Keine Benutzer gefunden.",
     "error_loading_members": "Fehler beim Laden der Mitglieder: {error}",
-    "error_search_failed": "Suche fehlgeschlagen: {error}"
+    "error_search_failed": "Suche fehlgeschlagen: {error}",
+    "store_deploy_soon": "Deployment-Logik kommt bald in die Store-Ansicht!"
 }

src/switchcraft/assets/lang/en.json

@@ -833,5 +833,6 @@
     "no_members": "No members found.",
     "no_users_found": "No users found.",
     "error_loading_members": "Error loading members: {error}",
-    "error_search_failed": "Search failed: {error}"
+    "error_search_failed": "Search failed: {error}",
+    "store_deploy_soon": "Deployment logic coming soon to Store view!"
 }

src/switchcraft/gui_modern/app.py

@@ -290,9 +290,9 @@ def setup_page(self):
         import sys
         if "--wizard" in sys.argv:
             # We need to defer this until UI is built
-            self._pending_nav_index = 2 # Wizard index
+            self._pending_nav_index = NavIndex.PACKAGING_WIZARD
         elif "--analyzer" in sys.argv or "--all-in-one" in sys.argv:
-             self._pending_nav_index = 3 # Analyzer index
+             self._pending_nav_index = NavIndex.ANALYZER
         else:
             self._pending_nav_index = None
 
@@ -1059,8 +1059,8 @@ def _f():
         fade_container.opacity = 1
         try:
             fade_container.update()
-        except RuntimeError:
-            pass
+        except RuntimeError as re:
+             logger.debug(f"Fade container update failed: {re}")
 
     def _on_notification_update(self):
         """Update notification icon based on unread count and trigger Windows toast."""
@@ -1082,8 +1082,8 @@ def _on_notification_update(self):
                  self.notif_btn.tooltip = "Notifications"
              try:
                  self.notif_btn.update()
-             except RuntimeError:
-                 pass
+             except RuntimeError as re:
+                 logger.debug(f"Notification update failed (control likely detached): {re}")
 
              # 2. Windows Toast Logic
              if notifs and WINOTIFY_AVAILABLE:

src/switchcraft/gui_modern/utils/flet_compat.py

@@ -12,8 +12,11 @@ def create_tabs(tabs, **kwargs):
     Falls back to ft.Tabs(content=ft.TabBar(tabs=...), length=...) if needed.
     """
     try:
-        # Standard Flet
-        return ft.Tabs(tabs=tabs, **kwargs)
+        # Try with length (required by some versions/environments)
+        try:
+            return ft.Tabs(tabs=tabs, length=len(tabs) if tabs else 0, **kwargs)
+        except TypeError:
+            return ft.Tabs(tabs=tabs, **kwargs)
     except TypeError as te:
         # Fallback for environments where Tabs requires content/length (e.g. tests)
         logger.debug(f"Standard Tabs failed (likely compat mode needed): {te}")
@@ -46,12 +49,29 @@ def create_tabs(tabs, **kwargs):
                 # If that failed above (TypeError), it implies signature mismatch.
 
                 # Re-try assuming it's the `content` argument issue or similar.
-                # If we really need a fallback:
-
+                # Fallback: manually construct TabBar and use positional Tabs
+                # Flet versions around 0.7.x/0.8.x might require this structure.
+                tab_bar = ft.TabBar(tabs=tabs)
                 length = len(tabs) if tabs else 0
-                return ft.Tabs(content=ft.TabBar(tabs=tabs), length=length, **kwargs)
+
+                try:
+                    # Attempt positional Tabs wrapper - this supports on_change and selected_index
+                    return ft.Tabs(tab_bar, length, **kwargs)
+                except (TypeError, ValueError):
+                    # Second Fallback: Column with TabBar and TabBarView
+                    # Note: Column does NOT support on_change, so this is a last resort.
+                    return ft.Column(
+                        controls=[
+                            tab_bar,
+                            ft.Container(
+                                content=ft.TabBarView(controls=tab_contents),
+                                expand=True
+                            )
+                        ],
+                        **kwargs
+                    )
             else:
-                # No TabBar, maybe properties assignment?
+                # No TabBar available, try property assignment as last resort
                 t = ft.Tabs(**kwargs)
                 if tabs is not None:
                     t.tabs = tabs

src/switchcraft/gui_modern/utils/view_utils.py

@@ -0,0 +1,22 @@
+import flet as ft
+import logging
+
+logger = logging.getLogger(__name__)
+
+class ViewMixin:
+    """Mixin for common view functionality."""
+
+    def _show_snack(self, msg, color="GREEN"):
+        """Show a snackbar message on the page."""
+        try:
+            # Check if self has app_page or page
+            page = getattr(self, "app_page", getattr(self, "page", None))
+            if not page:
+                logger.debug("Cannot show snackbar: No page reference found")
+                return
+
+            page.snack_bar = ft.SnackBar(ft.Text(msg), bgcolor=color)
+            page.snack_bar.open = True
+            page.update()
+        except Exception as e:
+            logger.debug(f"Failed to show snackbar: {e}")

src/switchcraft/gui_modern/views/addon_manager_view.py

@@ -4,10 +4,11 @@
 
 from switchcraft.services.addon_service import AddonService
 from switchcraft.gui_modern.utils.file_picker_helper import FilePickerHelper
+from switchcraft.gui_modern.utils.view_utils import ViewMixin
 
 logger = logging.getLogger(__name__)
 
-class AddonManagerView(ft.Column):
+class AddonManagerView(ft.Column, ViewMixin):
     def __init__(self, page: ft.Page):
         super().__init__(expand=True)
         self.app_page = page
@@ -158,11 +159,3 @@ def _bg():
         self.app_page.dialog = dlg
         dlg.open = True
         self.app_page.update()
-
-    def _show_snack(self, msg, color="GREEN"):
-        try:
-            self.app_page.snack_bar = ft.SnackBar(ft.Text(msg), bgcolor=color)
-            self.app_page.snack_bar.open = True
-            self.app_page.update()
-        except Exception:
-            pass

src/switchcraft/gui_modern/views/analyzer_view.py

@@ -18,6 +18,7 @@
 from switchcraft.services.addon_service import AddonService
 from switchcraft.gui_modern.utils.file_picker_helper import FilePickerHelper
 from switchcraft.gui_modern.utils.flet_compat import create_tabs
+from switchcraft.gui_modern.utils.view_utils import ViewMixin
 
 # Try to import flet_dropzone for native file DnD
 try:
@@ -29,7 +30,7 @@
 
 logger = logging.getLogger(__name__)
 
-class ModernAnalyzerView(ft.Column):
+class ModernAnalyzerView(ft.Column, ViewMixin):
     def __init__(self, page: ft.Page):
         super().__init__(expand=True)
         self.app_page = page
@@ -224,7 +225,7 @@ def _start_url_download(self, e):
             return
 
         # Validate URL
-        # Validate URL
+
         if not url.startswith(("http://", "https://")):
             self._show_snack(i18n.get("invalid_url_format") or "Invalid URL format", "RED")
             return
@@ -240,8 +241,12 @@ def _bg():
             analysis_started = False
             try:
                 # Get filename from URL
-                filename = url.split("/")[-1].split("?")[0]
-                if not filename.lower().endswith((".exe", ".msi")):
+                raw_filename = url.split("/")[-1].split("?")[0]
+                # Sanitize filename (basic)
+                keep_chars = ("-", "_", ".")
+                filename = "".join(c for c in raw_filename if c.isalnum() or c in keep_chars).strip()
+
+                if not filename or not filename.lower().endswith((".exe", ".msi")):
                     filename = "installer.exe"
 
                 # Create temp directory
@@ -1047,13 +1052,7 @@ def _copy_to_clipboard(self, text: str):
             except Exception:
                 self._show_snack("Failed to copy", "RED")
 
-    def _show_snack(self, msg, color="GREEN"):
-        try:
-            self.app_page.snack_bar = ft.SnackBar(ft.Text(msg), bgcolor=color)
-            self.app_page.snack_bar.open = True
-            self.app_page.update()
-        except Exception as e:
-            logger.debug(f"Failed to show snackbar: {e}")
+
 
     def _add_history_entry(self, info, status):
         try:

src/switchcraft/gui_modern/views/group_manager_view.py

@@ -6,10 +6,11 @@
 import requests
 from switchcraft.services.intune_service import IntuneService
 from switchcraft.utils.config import SwitchCraftConfig
+from switchcraft.gui_modern.utils.view_utils import ViewMixin
 
 logger = logging.getLogger(__name__)
 
-class GroupManagerView(ft.Column):
+class GroupManagerView(ft.Column, ViewMixin):
     def __init__(self, page: ft.Page):
         super().__init__(expand=True)
         self.app_page = page
@@ -99,7 +100,7 @@ def _init_ui(self):
                 ft.DataColumn(ft.Text(i18n.get("col_type") or "Type")),
             ],
             rows=[],
-            border=ft.border.all(1, "GREY_400"),
+            border=ft.Border.all(1, "GREY_400"),
             vertical_lines=ft.border.BorderSide(1, "GREY_400"),
             horizontal_lines=ft.border.BorderSide(1, "GREY_400"),
             heading_row_color="BLACK12",
@@ -287,13 +288,7 @@ def _bg():
         self.app_page.open(dlg)
         self.app_page.update()
 
-    def _show_snack(self, msg, color="GREEN"):
-        try:
-            self.app_page.snack_bar = ft.SnackBar(ft.Text(msg), bgcolor=color)
-            self.app_page.snack_bar.open = True
-            self.app_page.update()
-        except Exception:
-            pass
+
 
     def _has_credentials(self):
         """Check if Graph API credentials are configured."""
@@ -387,7 +382,7 @@ def show_add_dialog(e):
 
             def search_users(e):
                 query = search_box.value
-                if not query: return
+                if not query or not query.strip(): return
 
                 results_list.controls.clear()
                 results_list.controls.append(ft.ProgressBar())

src/switchcraft/gui_modern/views/intune_store_view.py

@@ -5,10 +5,11 @@
 from switchcraft.utils.config import SwitchCraftConfig
 from switchcraft.utils.i18n import i18n
 from switchcraft.gui_modern.nav_constants import NavIndex
+from switchcraft.gui_modern.utils.view_utils import ViewMixin
 
 logger = logging.getLogger(__name__)
 
-class ModernIntuneStoreView(ft.Column):
+class ModernIntuneStoreView(ft.Column, ViewMixin):
     def __init__(self, page: ft.Page):
         super().__init__(expand=True)
         self.app_page = page
@@ -196,17 +197,9 @@ def _show_details(self, app):
                     icon=ft.Icons.CLOUD_UPLOAD,
                     bgcolor="BLUE",
                     color="WHITE",
-                    on_click=lambda _: self._show_snack("Deployment logic coming soon to Store view!", "BLUE")
+                    on_click=lambda _: self._show_snack(i18n.get("store_deploy_soon") or "Deployment logic coming soon to Store view!", "BLUE")
                 )
             ])
         )
 
         self.update()
-
-    def _show_snack(self, msg, color="GREEN"):
-        try:
-            self.app_page.snack_bar = ft.SnackBar(ft.Text(msg), bgcolor=color)
-            self.app_page.snack_bar.open = True
-            self.app_page.update()
-        except Exception as e:
-             logger.debug(f"Failed to show snackbar: {e}")