small fixes

Author: FaserF

src/switchcraft/gui_modern/views/packaging_wizard_view.py

@@ -860,7 +860,7 @@ def _run_autopilot(self, e):
                 ft.Text("Please wait, performing magic...", key="status_txt")
             ], height=100, tight=True),
             modal=True,
-            on_dismiss=lambda e: print("Autopilot finished")
+            on_dismiss=lambda e: logger.debug("Autopilot finished")
         )
         if hasattr(self.app_page, "open"):
             self.app_page.open(self.autopilot_dlg)

src/switchcraft/gui_modern/views/settings_view.py

@@ -812,17 +812,28 @@ def _show_permission_dialog(self, callback):
         self._show_snack("Preparing GitHub Permissions...", "BLUE")
 
         def proceed(e):
-            logger.debug("User clicked 'Continue'")
-            if hasattr(dlg, "open"):
-                dlg.open = False
-            self.app_page.update()
-            callback(None)
+            try:
+                logger.info("User clicked 'Continue' in permission dialog [INSTRUMENTED]")
+                self._close_dialog(dlg)
+
+                # Check page before update to avoid ghosts
+                if self.app_page:
+                    self.app_page.update()
+
+                logger.info("Calling callback from permission dialog...")
+                callback(e) # Pass event 'e' instead of None, though _start_github_login handles None too
+            except Exception as ex:
+                logger.exception(f"Critical error in proceed handler: {ex}")
+                self._show_snack(f"Error continuing: {ex}", "RED")
 
         def cancel(e):
-            logger.debug("User clicked 'Cancel' in permission dialog")
-            if hasattr(dlg, "open"):
-                dlg.open = False
-            self.app_page.update()
+            try:
+                logger.info("User clicked 'Cancel' in permission dialog [INSTRUMENTED]")
+                self._close_dialog(dlg)
+                if self.app_page:
+                    self.app_page.update()
+            except Exception as ex:
+                logger.error(f"Error in cancel handler: {ex}")
 
         explanation = i18n.get("github_permissions_explanation") or (
             "SwitchCraft requests the following GitHub permissions:\n\n"
@@ -833,6 +844,7 @@ def cancel(e):
         )
 
         dlg = ft.AlertDialog(
+            modal=True, # Force user interaction
             title=ft.Text(i18n.get("github_permissions_title") or "GitHub Permissions"),
             content=ft.Column([
                 ft.Text(explanation),

switchcraft.iss

@@ -94,11 +94,11 @@ Source: "src\switchcraft\assets\switchcraft_logo.png"; DestDir: "{app}"; Flags:
 
 [Icons]
 ; Start Menu
-Name: "{group}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Comment: "{#MyAppDescription}"
+Name: "{group}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Comment: "{#MyAppDescription}"; AppUserModelID: "FaserF.SwitchCraft.Modern.Release"
 Name: "{group}\{cm:UninstallProgram,{#MyAppName}}"; Filename: "{uninstallexe}"
 
 ; Desktop (optional)
-Name: "{autodesktop}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Tasks: desktopicon; Comment: "{#MyAppDescription}"
+Name: "{autodesktop}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Tasks: desktopicon; Comment: "{#MyAppDescription}"; AppUserModelID: "FaserF.SwitchCraft.Modern.Release"
 
 [Registry]
 ; Add to Add/Remove Programs with additional info