fixed some btns and enhanced CI tests

Author: FaserF

.github/workflows/ci.yml

@@ -1,21 +1,20 @@
 name: CI
 
-# on:
-#   push:
-#     branches: [ main ]
-#     paths-ignore:
-#       - '**.md'
-#       - 'docs/**'
-#       - 'LICENSE'
-#       - '.github/ISSUE_TEMPLATE/**'
-#   pull_request:
-#     branches: [ main ]
-#     paths-ignore:
-#       - '**.md'
-#       - 'docs/**'
-#       - 'LICENSE'
-#       - '.github/ISSUE_TEMPLATE/**'
 on:
+  push:
+    branches: [ main ]
+    paths-ignore:
+      - '**.md'
+      - 'docs/**'
+      - 'LICENSE'
+      - '.github/ISSUE_TEMPLATE/**'
+  pull_request:
+    branches: [ main ]
+    paths-ignore:
+      - '**.md'
+      - 'docs/**'
+      - 'LICENSE'
+      - '.github/ISSUE_TEMPLATE/**'
   workflow_dispatch:
 
 concurrency:
@@ -26,10 +25,14 @@ jobs:
   test:
     name: Run Tests
     runs-on: ${{ matrix.os }}
+    # Python 3.15 only on main branch push (not PRs) to save time
+    if: |
+      matrix.python-version == '3.14' ||
+      (matrix.python-version == '3.15' && github.event_name == 'push' && github.ref == 'refs/heads/main')
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
-        python-version: ["3.11", "3.12"]
+        python-version: ["3.14", "3.15"]
 
     steps:
     - uses: actions/checkout@v6
@@ -49,6 +52,8 @@ jobs:
     - name: Run Tests
       run: |
         export PYTHONPATH=$PYTHONPATH:$(pwd)/src:$(pwd)/src/switchcraft:$(pwd)/src/switchcraft_advanced:$(pwd)/src/switchcraft_ai:$(pwd)/src/switchcraft_winget:$(pwd)/src/switchcraft_debug
+        export CI=true
+        export GITHUB_ACTIONS=true
         python -m pytest tests
       shell: bash
 

.github/workflows/docs_preview.yml

@@ -51,6 +51,7 @@ jobs:
           source-dir: docs/.vitepress/dist
           preview-branch: gh-pages
           umbrella-dir: pr-preview
+          pages-base-path: /SwitchCraft
           action: auto
 
   cleanup-preview:

.github/workflows/test.yml

@@ -10,12 +10,17 @@ on:
 jobs:
   test-backend:
     runs-on: windows-latest
-    if: inputs.component == 'backend'
+    if: |
+      inputs.component == 'backend' &&
+      (
+        matrix.python-version == '3.14' ||
+        (matrix.python-version == '3.15' && github.event_name == 'push' && github.ref == 'refs/heads/main')
+      )
     strategy:
       fail-fast: true
       max-parallel: 1
       matrix:
-        python-version: ["3.13", "3.14"]
+        python-version: ["3.14", "3.15"]
 
     steps:
       - uses: actions/checkout@v6
@@ -35,6 +40,8 @@ jobs:
           pytest tests/ -v --tb=short
         env:
           PYTHONPATH: ${{ github.workspace }}/src
+          CI: true
+          GITHUB_ACTIONS: true
 
   test-cli-core:
     runs-on: windows-latest
@@ -45,7 +52,7 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v6
         with:
-          python-version: "3.13"
+          python-version: "3.14"
 
       - name: Install Core (No GUI)
         run: |

docs/.vitepress/config.mts

@@ -149,6 +149,9 @@ export default defineConfig({
 
     vite: {
         publicDir: 'public',
+        server: {
+            cors: false
+        },
         build: {
             rollupOptions: {
                 output: {

docs/INTUNE.md

@@ -15,7 +15,7 @@ Pro-Users can enable the **"All-in-One"** button in the Analyzer result pane to
 ## ⚙️ Configuration & Settings
 
 SwitchCraft supports extensive configuration via the GUI or Registry/GPO for enterprise environments.
-w
+
 > [!IMPORTANT]
 > **Intune OMA-URI Configuration**: For detailed instructions on configuring Intune Custom Profiles (OMA-URI), please refer to the **[Intune Configuration Guide](Intune_Configuration_Guide.md)**.
 > **Critical**: Ensure you use the **String (XML)** Data Type for all ADMX-backed policies.

docs/Intune_Configuration_Guide.md

@@ -191,7 +191,7 @@ All settings below use the base path:
 
 ---
 
-### Top Level Settings
+### Top-Level Settings
 
 #### 1. Debug Mode (`DebugMode_Enf`)
 - **OMA-URI**: `./User/Vendor/MSFT/Policy/Config/SwitchCraft~Policy~SwitchCraft~Enforced/DebugMode_Enf`

scripts/build_release.ps1

@@ -225,11 +225,35 @@ function Run-PyInstaller {
             exit 1
         }
     }
+
     else {
         Write-Error "Spec file not found: $SpecFile"
     }
 }
 
+function Get-InnoSetupPath {
+    $IsccPath = (Get-Command "iscc" -ErrorAction SilentlyContinue).Source
+    if ($IsccPath) {
+        Write-Host "Found Inno Setup in PATH: $IsccPath" -ForegroundColor Gray
+        return $IsccPath
+    }
+
+    # Search in common installation paths for Inno Setup (multiple versions)
+    $PossiblePaths = @(
+        "${env:ProgramFiles(x86)}\Inno Setup 6\ISCC.exe",
+        "$env:ProgramFiles\Inno Setup 6\ISCC.exe",
+        "${env:ProgramFiles(x86)}\Inno Setup 5\ISCC.exe",
+        "$env:ProgramFiles\Inno Setup 5\ISCC.exe"
+    )
+    foreach ($p in $PossiblePaths) {
+        if (Test-Path $p) {
+            Write-Host "Found Inno Setup at: $p" -ForegroundColor Gray
+            return $p
+        }
+    }
+    return $null
+}
+
 # --- 0. PREPARE ASSETS ---
 if ($LocalDev) {
     Write-Host "`nGenerating Bundled Addons (Local Dev Mode)..." -ForegroundColor Cyan
@@ -327,29 +351,7 @@ if ($Pip) {
 # --- 5. INSTALLERS (Windows Only) ---
 if ($Installer -and $IsWinBuild) {
     Write-Host "`nBuilding Modern Installer..." -ForegroundColor Cyan
-    $IsccPath = (Get-Command "iscc" -ErrorAction SilentlyContinue).Source
-    if (-not $IsccPath) {
-        # Search in common installation paths for Inno Setup (multiple versions)
-        $PossiblePaths = @(
-            "C:\Program Files (x86)\Inno Setup 6\ISCC.exe",
-            "C:\Program Files\Inno Setup 6\ISCC.exe",
-            "C:\Program Files (x86)\Inno Setup 5\ISCC.exe",
-            "C:\Program Files\Inno Setup 5\ISCC.exe",
-            "${env:ProgramFiles(x86)}\Inno Setup 6\ISCC.exe",
-            "$env:ProgramFiles\Inno Setup 6\ISCC.exe",
-            "${env:ProgramFiles(x86)}\Inno Setup 5\ISCC.exe",
-            "$env:ProgramFiles\Inno Setup 5\ISCC.exe"
-        )
-        foreach ($p in $PossiblePaths) {
-            if (Test-Path $p) {
-                $IsccPath = $p
-                Write-Host "Found Inno Setup at: $IsccPath" -ForegroundColor Gray
-                break
-            }
-        }
-    } else {
-        Write-Host "Found Inno Setup in PATH: $IsccPath" -ForegroundColor Gray
-    }
+    $IsccPath = Get-InnoSetupPath
 
     if ($IsccPath) {
         $ModernExe = Join-Path $DistDir "SwitchCraft.exe"
@@ -401,26 +403,7 @@ if ($Legacy -and $IsWinBuild) {
 
     if ($Installer) {
         Write-Host "`nBuilding Legacy Installer..." -ForegroundColor Cyan
-        $IsccPath = (Get-Command "iscc" -ErrorAction SilentlyContinue).Source
-        if (-not $IsccPath) {
-            # Search in common installation paths for Inno Setup (multiple versions)
-            $PossiblePaths = @(
-                "C:\Program Files (x86)\Inno Setup 6\ISCC.exe",
-                "C:\Program Files\Inno Setup 6\ISCC.exe",
-                "C:\Program Files (x86)\Inno Setup 5\ISCC.exe",
-                "C:\Program Files\Inno Setup 5\ISCC.exe",
-                "${env:ProgramFiles(x86)}\Inno Setup 6\ISCC.exe",
-                "$env:ProgramFiles\Inno Setup 6\ISCC.exe",
-                "${env:ProgramFiles(x86)}\Inno Setup 5\ISCC.exe",
-                "$env:ProgramFiles\Inno Setup 5\ISCC.exe"
-            )
-            foreach ($p in $PossiblePaths) {
-                if (Test-Path $p) {
-                    $IsccPath = $p
-                    break
-                }
-            }
-        }
+        $IsccPath = Get-InnoSetupPath
         if ($IsccPath -and (Test-Path "switchcraft_legacy.iss")) {
             & $IsccPath "/DMyAppVersion=$AppVersion" "/DMyAppVersionNumeric=$AppVersionNumeric" "switchcraft_legacy.iss" | Out-Null
             Write-Host "Installer Created: SwitchCraft-Legacy-Setup.exe" -ForegroundColor Green

src/switchcraft/gui_modern/app.py

@@ -191,18 +191,12 @@ def _toggle_notification_drawer(self, e):
                     self.page.update()
                 except Exception as ex:
                     logger.exception(f"Error opening notification drawer: {ex}")
-                    # Try again with simpler approach
-                    try:
-                        self._open_notifications_drawer(e)
-                        self.page.update()
-                    except Exception as ex2:
-                        logger.error(f"Failed to open drawer after retry: {ex2}")
-                        self.page.snack_bar = ft.SnackBar(
-                            content=ft.Text(f"Failed to open notifications: {ex2}"),
-                            bgcolor="RED"
-                        )
-                        self.page.snack_bar.open = True
-                        self.page.update()
+                    self.page.snack_bar = ft.SnackBar(
+                        content=ft.Text(f"Failed to open notifications: {ex}"),
+                        bgcolor="RED"
+                    )
+                    self.page.snack_bar.open = True
+                    self.page.update()
         except Exception as ex:
             logger.exception(f"Error toggling notification drawer: {ex}")
             # Try to open anyway
@@ -281,13 +275,13 @@ def _open_notifications_drawer(self, e):
                 on_dismiss=self._on_drawer_dismiss
             )
 
-            # Set drawer and open it
+            # Set drawer on page FIRST
             self.page.end_drawer = drawer
 
-            # Force update BEFORE setting open to ensure drawer is attached
+            # Force update to attach drawer to page
             self.page.update()
 
-            # Now set open and update again
+            # Now set open BEFORE updating (Flet needs this order)
             drawer.open = True
             self.page.update()
 
@@ -299,9 +293,17 @@ def _open_notifications_drawer(self, e):
             except Exception as ex:
                 logger.debug(f"page.open() not available or failed: {ex}, using direct assignment")
 
+            # Final verification and update
+            if not drawer.open:
+                logger.warning("Drawer open flag is False, forcing it to True")
+                drawer.open = True
+                self.page.update()
+
             # Final update to ensure drawer is visible
             self.page.update()
 
+            logger.info(f"Notification drawer should now be visible. open={drawer.open}, page.end_drawer={self.page.end_drawer is not None}")
+
             # Mark all as read after opening
             self.notification_service.mark_all_read()
             logger.debug("Notification drawer opened successfully")
@@ -1003,10 +1005,8 @@ def nav_to_analyzer():
         self.page.add(
              ft.Column(layout_controls, expand=True, spacing=0)
         )
-        # Force multiple updates to ensure UI is visible and rendered
+        # Force update to ensure UI is visible and rendered
         self.page.update()
-        self.page.update()  # Second update to ensure rendering
-        self.page.update()  # Third update for good measure
 
         # Setup responsive UI (hide/show sidebar and menu button based on window size)
         self._update_responsive_ui()

src/switchcraft/gui_modern/views/analyzer_view.py

@@ -489,7 +489,11 @@ def _show_results(self, result: AnalysisResult):
                 ft.Container(
                     content=ft.Column([
                         ft.Row([ft.Icon(ft.Icons.INFO_OUTLINE, color="WHITE"), ft.Text("7-ZIP SFX DETECTED", weight=ft.FontWeight.BOLD)]),
-                        ft.Text(i18n.get("sfx_notice_msg") or "This is a self-extracting archive. Silent switches might apply to the wrapper or the content inside.", size=12),
+                        ft.Container(
+                            content=ft.Text(i18n.get("sfx_notice_msg") or "This is a self-extracting archive. Silent switches might apply to the wrapper or the content inside.", size=12),
+                            expand=True,
+                            width=None
+                        ),
                     ]),
                     bgcolor="BLUE_900", padding=10, border_radius=5
                 )

src/switchcraft/gui_modern/views/intune_store_view.py

@@ -211,17 +211,23 @@ def _update_ui():
                     logger.exception(f"Error in _update_ui: {ex}")
                     self._show_error(f"Error updating UI: {ex}")
 
-            # Always call directly - Flet's update() is thread-safe
-            try:
-                _update_ui()
-            except Exception as ex:
-                logger.exception(f"Failed to update UI: {ex}")
-                # Try with run_task as fallback
-                if hasattr(self.app_page, 'run_task'):
+            # Use run_task as primary method to marshal UI updates to the page event loop
+            if hasattr(self.app_page, 'run_task'):
+                try:
+                    self.app_page.run_task(_update_ui)
+                except Exception as ex:
+                    logger.exception(f"Error in run_task for UI update: {ex}")
+                    # Fallback to direct call if run_task fails
                     try:
-                        self.app_page.run_task(_update_ui)
-                    except Exception:
-                        pass
+                        _update_ui()
+                    except Exception as ex2:
+                        logger.exception(f"Failed to update UI directly: {ex2}")
+            else:
+                # Fallback to direct call if run_task is not available
+                try:
+                    _update_ui()
+                except Exception as ex:
+                    logger.exception(f"Failed to update UI: {ex}")
 
         threading.Thread(target=_bg, daemon=True).start()