Skip to content

Commit dff0289

Browse files
committed
Use non-empty test files in AuthMonitor unit tests
1 parent 35dba0c commit dff0289

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

src/auth_monitor.test.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const MAX_FAILED_ATTEMPTS_TEST_RANGE: Range<i32> = 2..15;
4141

4242
#[test]
4343
fn when_file_does_not_exist_then_changes_are_monitored_after_it_is_created() {
44-
let mut file = TestFile::with_unique_name();
44+
let mut file = TestFile::empty();
4545
file.remove();
4646

4747
let options = AuthMonitorOptions::default();
@@ -62,7 +62,7 @@ fn when_file_does_not_exist_then_changes_are_monitored_after_it_is_created() {
6262
#[test]
6363
pub fn when_auth_failure_limit_is_reached_then_update_callback_is_invoked() {
6464
for max_failed_attempts in MAX_FAILED_ATTEMPTS_TEST_RANGE {
65-
let mut file = TestFile::with_unique_name();
65+
let mut file = TestFile::not_empty();
6666
let options = AuthMonitorOptions {
6767
max_failed_attempts,
6868
..AuthMonitorOptions::default()
@@ -88,7 +88,7 @@ pub fn when_auth_failure_limit_is_reached_then_update_callback_is_invoked() {
8888
#[test]
8989
pub fn when_auth_failure_limit_is_reached_between_updates_then_next_update_invokes_callback() {
9090
for max_failed_attempts in MAX_FAILED_ATTEMPTS_TEST_RANGE {
91-
let mut file = TestFile::with_unique_name();
91+
let mut file = TestFile::not_empty();
9292
let options = AuthMonitorOptions {
9393
max_failed_attempts,
9494
..AuthMonitorOptions::default()
@@ -105,7 +105,7 @@ pub fn when_auth_failure_limit_is_reached_between_updates_then_next_update_invok
105105

106106
#[test]
107107
pub fn when_reset_time_has_passed_then_reset_failed_attempt_counter() {
108-
let mut file = TestFile::with_unique_name();
108+
let mut file = TestFile::not_empty();
109109
let options = AuthMonitorOptions {
110110
reset_after_seconds: 5,
111111
..AuthMonitorOptions::default()
@@ -135,7 +135,7 @@ pub fn when_reset_time_has_passed_then_reset_failed_attempt_counter() {
135135

136136
#[test]
137137
fn when_file_is_deleted_and_new_one_is_created_then_changes_are_still_monitored() {
138-
let mut file = TestFile::with_unique_name();
138+
let mut file = TestFile::not_empty();
139139
let options = AuthMonitorOptions::default();
140140
let mut test = AuthMonitorTest::new(file.path(), options);
141141
file.remove();
@@ -150,7 +150,7 @@ fn when_file_is_deleted_and_new_one_is_created_then_changes_are_still_monitored(
150150

151151
#[test]
152152
fn when_file_is_renamed_and_new_one_is_created_then_changes_are_still_monitored() {
153-
let mut file = TestFile::with_unique_name();
153+
let mut file = TestFile::not_empty();
154154
let options = AuthMonitorOptions::default();
155155
let mut test = AuthMonitorTest::new(file.path(), options);
156156

@@ -167,7 +167,7 @@ fn when_file_is_renamed_and_new_one_is_created_then_changes_are_still_monitored(
167167

168168
#[test]
169169
fn when_file_is_truncated_then_changes_are_still_monitored() {
170-
let mut file = TestFile::with_unique_name();
170+
let mut file = TestFile::not_empty();
171171
file.write_other_messages(5);
172172

173173
let options = AuthMonitorOptions::default();

src/test_utils/test_file.rs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,14 @@ pub struct TestFile {
2323
}
2424

2525
impl TestFile {
26-
pub fn with_unique_name() -> TestFile {
26+
pub fn not_empty() -> TestFile {
27+
let mut file = Self::empty();
28+
file.write_other_messages(5);
29+
file.write_auth_failed_messages(5);
30+
return file;
31+
}
32+
33+
pub fn empty() -> TestFile {
2734
let filename = format!(
2835
"auth-monitor-test-{}-{}.log",
2936
Self::next_id(),

0 commit comments

Comments
 (0)