Merge pull request #9 from FastComments/memory-management

Memory Management Improvements

Author: winrid

README.md

@@ -253,6 +253,70 @@ Available color customization options:
 | `fastcomments_action_button_color` | Primary | Color of action buttons |
 | `fastcomments_load_more_button_text_color` | Primary | Color of load more button text |
 
+## Memory Management
+
+### Preventing Memory Leaks
+
+To prevent memory leaks when using FastComments views in Activities or Fragments, always call `cleanup()` when the view is no longer needed:
+
+#### In Activities:
+```java
+@Override
+protected void onDestroy() {
+    super.onDestroy();
+    // Clean up FastComments views to prevent memory leaks
+    if (feedView != null) {
+        feedView.cleanup();
+    }
+    if (commentsView != null) {
+        commentsView.cleanup();
+    }
+}
+```
+
+#### In Fragments:
+```java
+@Override
+public void onDestroyView() {
+    super.onDestroyView();
+    // Clean up FastComments views when fragment view is destroyed
+    if (feedView != null) {
+        feedView.cleanup();
+        feedView = null;
+    }
+}
+
+@Override
+public void onDestroy() {
+    super.onDestroy();
+    // Additional cleanup when fragment is destroyed
+    if (feedSDK != null) {
+        feedSDK.cleanup();
+        feedSDK = null;
+    }
+}
+```
+
+#### When Switching Fragments:
+```java
+// Before replacing or removing a fragment containing FastComments views
+Fragment currentFragment = getSupportFragmentManager().findFragmentById(R.id.container);
+if (currentFragment instanceof YourFragmentWithFeedView) {
+    ((YourFragmentWithFeedView) currentFragment).cleanupFeedView();
+}
+
+// Then proceed with fragment transaction
+getSupportFragmentManager().beginTransaction()
+    .replace(R.id.container, newFragment)
+    .commit();
+```
+
+**Important**: Always call `cleanup()` methods to prevent memory leaks, especially when:
+- Activities are destroyed
+- Fragment views are destroyed
+- Switching between fragments
+- Navigating away from screens with FastComments components
+
 ## License
 
 This project is licensed under the MIT License - see the [LICENSE](LICENSE) file for details.

app/src/main/java/com/fastcomments/FeedExampleActivity.java

@@ -266,4 +266,13 @@ public void onImagePickerRequested() {
             }
         });
     }
+    
+    @Override
+    protected void onDestroy() {
+        super.onDestroy();
+        // Clean up the feed view to prevent memory leaks
+        if (feedView != null) {
+            feedView.cleanup();
+        }
+    }
 }

libraries/sdk/src/main/java/com/fastcomments/sdk/FastCommentsFeedSDK.java

@@ -625,6 +625,25 @@ public void cleanup() {
             liveEventSubscription.close();
             liveEventSubscription = null;
         }
+        // Clear listener references to prevent memory leaks
+        this.onPostDeletedListener = null;
+        
+        // Clear collections to help GC
+        if (feedPosts != null) {
+            feedPosts.clear();
+        }
+        if (postsById != null) {
+            postsById.clear();
+        }
+        if (likeCounts != null) {
+            likeCounts.clear();
+        }
+        if (myReacts != null) {
+            myReacts.clear();
+        }
+        if (broadcastIdsSent != null) {
+            broadcastIdsSent.clear();
+        }
     }
 
     /**

libraries/sdk/src/main/java/com/fastcomments/sdk/FastCommentsFeedView.java

@@ -273,22 +273,33 @@ public void onScrolled(@NonNull RecyclerView recyclerView, int dx, int dy) {
      * @param sdk The FastCommentsFeedSDK instance
      */
     public void setSDK(FastCommentsFeedSDK sdk) {
+        // Clean up existing SDK if any
+        if (this.sdk != null) {
+            this.sdk.setOnPostDeletedListener(null);
+        }
+        
         this.sdk = sdk;
         if (adapter == null) {
             initAdapter(getContext());
         }
 
         // Register for post deletion events from live WebSocket
-        sdk.setOnPostDeletedListener(postId -> {
-            handler.post(() -> {
-                // Update adapter with the current list from SDK
-                // This ensures the adapter's list is in sync with the SDK after a post is deleted
-                adapter.updatePosts(sdk.getFeedPosts());
-                
-                // Log for debugging
-                Log.d("FastCommentsFeedView", "Received post deletion event for post ID: " + postId);
+        if (sdk != null) {
+            sdk.setOnPostDeletedListener(postId -> {
+                if (handler != null && adapter != null) {
+                    handler.post(() -> {
+                        // Update adapter with the current list from SDK
+                        // This ensures the adapter's list is in sync with the SDK after a post is deleted
+                        if (sdk != null && adapter != null) {
+                            adapter.updatePosts(sdk.getFeedPosts());
+                        }
+                        
+                        // Log for debugging
+                        Log.d("FastCommentsFeedView", "Received post deletion event for post ID: " + postId);
+                    });
+                }
             });
-        });
+        }
     }
 
     /**
@@ -949,10 +960,43 @@ public boolean onSuccess(APIEmptyResponse response) {
     @Override
     protected void onDetachedFromWindow() {
         super.onDetachedFromWindow();
+        cleanup();
+    }
+    
+    /**
+     * Clean up all resources to prevent memory leaks.
+     * Call this method when the view will no longer be used.
+     */
+    public void cleanup() {
         stopPolling();
+        
+        // Clear adapter data
+        if (adapter != null) {
+            adapter.updatePosts(new ArrayList<>());
+        }
+        
+        // Clear SDK listener reference
         if (sdk != null) {
+            sdk.setOnPostDeletedListener(null);
             sdk.cleanup();
+            sdk = null;
         }
+        
+        // Clear local references
+        listener = null;
+        
+        // Clear collections
+        if (feedPosts != null) {
+            feedPosts.clear();
+        }
+        
+        // Clear handler callbacks
+        if (handler != null && pollStatsRunnable != null) {
+            handler.removeCallbacks(pollStatsRunnable);
+        }
+        
+        // Clear polling runnable
+        pollStatsRunnable = null;
     }
 
     /**

libraries/sdk/src/main/java/com/fastcomments/sdk/FastCommentsView.java

@@ -1728,12 +1728,50 @@ private void updateReplyButtonText(String commentId, boolean isReplying) {
     @Override
     protected void onDetachedFromWindow() {
         super.onDetachedFromWindow();
+        cleanup();
+    }
+    
+    /**
+     * Clean up all resources to prevent memory leaks.
+     * Call this method when the view will no longer be used.
+     */
+    public void cleanup() {
         // Stop the timer when the view is detached to prevent memory leaks
         stopDateUpdateTimer();
-        // Clean up WebSocket connections when the view is detached
+        
+        // Clear SDK and WebSocket connections
         if (sdk != null) {
             sdk.cleanup();
+            sdk = null;
+        }
+        
+        // Clear listeners
+        commentPostListener = null;
+        
+        // Clear back pressed callback
+        if (backPressedCallback != null) {
+            backPressedCallback.setEnabled(false);
+            backPressedCallback = null;
         }
+        
+        // Clear adapter data through SDK
+        if (sdk != null && sdk.commentsTree != null) {
+            sdk.commentsTree.clear();
+            if (adapter != null) {
+                adapter.notifyDataSetChanged();
+            }
+        }
+        
+        // Clear currently replying state
+        currentlyReplyingToCommentId = null;
+        
+        // Clear handler callbacks
+        if (dateUpdateHandler != null) {
+            dateUpdateHandler.removeCallbacksAndMessages(null);
+        }
+        
+        // Clear runnables
+        dateUpdateRunnable = null;
     }
 
     /**