Merge pull request #27 from FastComments/live-chat-memory-leak

Improved LiveChatView cleanup

Author: winrid

app/src/main/java/com/fastcomments/LiveChatExampleActivity.kt

@@ -63,13 +63,18 @@ class LiveChatExampleActivity : AppCompatActivity() {
 
     override fun onResume() {
         super.onResume()
-        // Refresh live events connection when returning to the app
         sdk.refreshLiveEvents()
+        liveChatView.onResume()
+    }
+    
+    override fun onPause() {
+        super.onPause()
+        liveChatView.onPause()
     }
 
     override fun onDestroy() {
         super.onDestroy()
-        // Clean up resources
+        liveChatView.cleanup()
         sdk.cleanup()
     }
 }

libraries/sdk/src/main/java/com/fastcomments/sdk/FastCommentsSDK.java

@@ -53,7 +53,7 @@ public class FastCommentsSDK {
     public String blockingErrorMessage;
 
     private SubscribeToChangesResult liveEventSubscription;
-    private final LiveEventSubscriber liveEventSubscriber;
+    private LiveEventSubscriber liveEventSubscriber;
     private String tenantIdWS;
     private String urlIdWS;
     private String userIdWS;
@@ -1134,14 +1134,19 @@ private void handlePresenceChange(LiveEvent eventData) {
         }
     }
 
-    /**
-     * Cleanup resources, including WebSocket connections
-     */
     public void cleanup() {
         if (liveEventSubscription != null) {
             liveEventSubscription.close();
             liveEventSubscription = null;
         }
+        
+        if (liveEventSubscriber != null) {
+            liveEventSubscriber = null;
+        }
+        
+        tenantIdWS = null;
+        urlIdWS = null;
+        userIdWS = null;
     }
 
     /**

libraries/sdk/src/main/java/com/fastcomments/sdk/LiveChatView.java

@@ -1524,18 +1524,55 @@ public boolean isAutoScrollToBottom() {
      * Should be called when the view is no longer needed, especially when used in fragments.
      */
     public void cleanup() {
-        // Clear back pressed callback
+        stopDateUpdateTimer();
+        
+        if (dateUpdateHandler != null) {
+            dateUpdateHandler.removeCallbacksAndMessages(null);
+            dateUpdateHandler = null;
+        }
+        dateUpdateRunnable = null;
+        
         if (backPressedCallback != null) {
             backPressedCallback.setEnabled(false);
             backPressedCallback = null;
         }
 
-        // Stop any timers
-        stopDateUpdateTimer();
+        if (recyclerView != null) {
+            recyclerView.clearOnScrollListeners();
+        }
+        
+        if (adapter != null) {
+            adapter.setRequestingReplyListener(null);
+            adapter.setUpVoteListener(null);
+            adapter.setDownVoteListener(null);
+            adapter.setCommentMenuListener(null);
+            adapter.setUserClickListener(null);
+            adapter.setGetChildrenProducer(null);
+            adapter = null;
+        }
+        
+        if (bottomCommentInput != null) {
+            bottomCommentInput.setOnCommentSubmitListener(null);
+            bottomCommentInput.setOnReplyStateChangeListener(null);
+        }
+        if (commentForm != null) {
+            commentForm.setOnCommentSubmitListener(null);
+            commentForm.setOnCancelReplyListener(null);
+        }
+        
+        if (btnNextComments != null) {
+            btnNextComments.setOnClickListener(null);
+        }
+        if (btnLoadAll != null) {
+            btnLoadAll.setOnClickListener(null);
+        }
+        
+        commentActionListener = null;
+        userClickListener = null;
 
-        // Clean up SDK
         if (sdk != null) {
             sdk.cleanup();
+            sdk = null;
         }
     }
 
@@ -1551,6 +1588,24 @@ public void setBackPressHandlingEnabled(boolean enabled) {
         }
     }
 
+    /**
+     * Lifecycle method to call when the view/fragment is paused.
+     * Stops timers and disables back press handling to prevent memory leaks.
+     */
+    public void onPause() {
+        stopDateUpdateTimer();
+        setBackPressHandlingEnabled(false);
+    }
+    
+    /**
+     * Lifecycle method to call when the view/fragment is resumed.
+     * Restarts timers and enables back press handling.
+     */
+    public void onResume() {
+        setBackPressHandlingEnabled(true);
+        startDateUpdateTimer();
+    }
+    
     /**
      * Sets up the demo banner if tenant ID is "demo"
      */