Making the API less restrictive.

Author: lemire

src/bloom.h

@@ -60,8 +60,12 @@ class BloomFilter {
 
   // Add multiple items to the filter.
   Status AddAll(const vector<ItemType> data, const size_t start,
-                const size_t end);
+                const size_t end) {
+    return AddAll(data.data(),start,end);
 
+  }
+  Status AddAll(const ItemType* data, const size_t start,
+                const size_t end);
   // Report if the item is inserted, with false positive rate.
   Status Contain(const ItemType &item) const;
 
@@ -107,7 +111,7 @@ void applyBlock(uint32_t *tmp, int block, int len, uint64_t *data) {
 template <typename ItemType, size_t bits_per_item, bool branchless,
           typename HashFamily, int k>
 Status BloomFilter<ItemType, bits_per_item, branchless, HashFamily, k>::AddAll(
-    const vector<ItemType> keys, const size_t start, const size_t end) {
+    const ItemType* keys, const size_t start, const size_t end) {
   int blocks = 1 + arrayLength / blockLen;
   uint32_t *tmp = new uint32_t[blocks * blockLen];
   int *tmpLen = new int[blocks]();

src/simd-block-fixed-fpp.h

@@ -60,7 +60,10 @@ class SimdBlockFilterFixed {
   void Add(const uint64_t key) noexcept;
 
   // Add multiple items to the filter.
-  void AddAll(const vector<uint64_t> data, const size_t start, const size_t end);
+  void AddAll(const vector<uint64_t> & data, const size_t start, const size_t end) {
+    return AddAll(data.data(), start,end);
+  }
+  void AddAll(const uint64_t* data, const size_t start, const size_t end);
 
   bool Find(const uint64_t key) const noexcept;
   uint64_t SizeInBytes() const { return sizeof(Bucket) * bucketCount; }
@@ -147,7 +150,7 @@ void SimdBlockFilterFixed<HashFamily>::ApplyBlock(uint64_t* tmp, int block, int
 
 template<typename HashFamily>
 void SimdBlockFilterFixed<HashFamily>::AddAll(
-    const vector<uint64_t> keys, const size_t start, const size_t end) {
+    const uint64_t* keys, const size_t start, const size_t end) {
     int blocks = 1 + bucketCount / blockLen;
     uint64_t* tmp = new uint64_t[blocks * blockLen];
     int* tmpLen = new int[blocks]();
@@ -314,7 +317,11 @@ class SimdBlockFilterFixed {
   void Add(const uint64_t key) noexcept;
 
   // Add multiple items to the filter.
-  void AddAll(const vector<uint64_t> data, const size_t start, const size_t end);
+  void AddAll(const vector<uint64_t>& data, const size_t start, const size_t end) {
+      return AddAll(data.data(),start,end);
+  }
+
+  void AddAll(const uint64_t* data, const size_t start, const size_t end);
 
   bool Find(const uint64_t key) const noexcept;
   uint64_t SizeInBytes() const { return sizeof(Bucket) * bucketCount; }

src/xorfilter.h

@@ -66,7 +66,11 @@ class XorFilter {
     delete hasher;
   }
 
-  Status AddAll(const vector<ItemType> data, const size_t start, const size_t end);
+  Status AddAll(const vector<ItemType> &data, const size_t start, const size_t end) {
+      return AddAll(data.data(),start,end);
+  }
+
+  Status AddAll(const ItemType* data, const size_t start, const size_t end);
 
   // Report if the item is inserted, with false positive rate.
   Status Contain(const ItemType &item) const;
@@ -120,7 +124,7 @@ int applyBlock2(uint64_t* tmp, int b, int len, t2val_t * t2vals, int* alone, int
 template <typename ItemType, typename FingerprintType,
           typename HashFamily>
 Status XorFilter<ItemType, FingerprintType, HashFamily>::AddAll(
-    const vector<ItemType> keys, const size_t start, const size_t end) {
+    const ItemType* keys, const size_t start, const size_t end) {
 
     int m = arrayLength;
     uint64_t* reverseOrder = new uint64_t[size];

src/xorfilter_plus.h

@@ -193,7 +193,10 @@ class XorFilterPlus {
     }
   }
 
-  Status AddAll(const vector<ItemType> data, const size_t start, const size_t end);
+  Status AddAll(const vector<ItemType>& data, const size_t start, const size_t end) {
+      return AddAll(data.data(), start, end);
+  }
+  Status AddAll(const ItemType * data, const size_t start, const size_t end);
 
   // Report if the item is inserted, with false positive rate.
   Status Contain(const ItemType &item) const;
@@ -212,7 +215,7 @@ class XorFilterPlus {
 template <typename ItemType, typename FingerprintType,
           typename HashFamily>
 Status XorFilterPlus<ItemType, FingerprintType, HashFamily>::AddAll(
-    const vector<ItemType> keys, const size_t start, const size_t end) {
+    const ItemType* keys, const size_t start, const size_t end) {
     int m = arrayLength;
     uint64_t* reverseOrder = new uint64_t[size];
     uint8_t* reverseH = new uint8_t[size];