Skip to content

Commit a5a3630

Browse files
committed
Version update and new policy regarding static analysis
1 parent 4df18c9 commit a5a3630

File tree

3 files changed

+14
-21
lines changed

3 files changed

+14
-21
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
cmake_minimum_required(VERSION 3.10)
22

3-
project(xor_singleheader VERSION 2.0.0 LANGUAGES C)
3+
project(xor_singleheader VERSION 2.1.0 LANGUAGES C)
44

55
include(CTest)
66

README.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,19 @@ It took 0.358220 seconds to build an index over 10000000 values.
184184
...
185185
```
186186

187+
## Policy regarding static analysis
188+
189+
We always encourage bug reports and bug fixes.
190+
If a static analyzer reports a warning, it may
191+
be a bug, but you have to carry the analysis to
192+
show that it is a bug.
193+
194+
It is not a goal of this project to be warning-free when reviewed with all possible
195+
static analyzers.
196+
197+
We will be happy to take in safe non-invasive pull requests to silence some warnings. However,
198+
please do not file in an issue in such cases.
199+
187200
## Implementations of xor and binary fuse filters in other programmming languages
188201

189202
* [Go](https://github.com/FastFilter/xorfilter)

tests/CMakeLists.txt

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,3 @@
11
add_executable(unit unit.c)
22
add_test(unit unit)
33
target_link_libraries(unit PRIVATE xor_singleheader)
4-
5-
6-
# full warnings with sanitizers for tests. Include debug symbols and
7-
# only -O2 to maintain some debugability.
8-
if (MSVC)
9-
# limited support for MSVC, this is not tested
10-
list(APPEND TEST_COMPILE_OPTIONS /W4 /fsanitize=address)
11-
else() # *nix
12-
list(APPEND TEST_COMPILE_OPTIONS -g -O2
13-
-Wall -Wextra)
14-
15-
if (NOT MINGW) # sanitizers are not supported under mingw
16-
list(APPEND TEST_COMPILE_OPTIONS -fsanitize=address,undefined)
17-
# sanitsizers need to be specified at link time as well
18-
target_link_options(unit PRIVATE -fsanitize=address,undefined)
19-
endif()
20-
endif()
21-
22-
target_compile_options(unit PRIVATE ${TEST_COMPILE_OPTIONS})
23-

0 commit comments

Comments
 (0)