Skip to content

Commit 47e39f1

Browse files
committed
Minor change wrt #747
1 parent c85fcd3 commit 47e39f1

File tree

6 files changed

+23
-19
lines changed

6 files changed

+23
-19
lines changed

src/main/java/com/fasterxml/jackson/core/JsonParser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ public enum Feature {
330330
* doubles or if we use {@link com.fasterxml.jackson.core.io.doubleparser}
331331
* instead.
332332
*<p>
333-
* This setting is disabled by default.
333+
* This setting is disabled by default for backwards compatibility.
334334
*
335335
* @since 2.14
336336
*/

src/main/java/com/fasterxml/jackson/core/StreamReadFeature.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,17 @@ public enum StreamReadFeature
9191
*/
9292
INCLUDE_SOURCE_IN_LOCATION(JsonParser.Feature.INCLUDE_SOURCE_IN_LOCATION),
9393

94+
/**
95+
* Feature that determines whether we use the built-in {@link Double#parseDouble(String)} code to parse
96+
* doubles or if we use {@link com.fasterxml.jackson.core.io.doubleparser}
97+
* instead.
98+
*<p>
99+
* This setting is disabled by default.
100+
*
101+
* @since 2.14
102+
*/
103+
USE_FAST_DOUBLE_PARSER(JsonParser.Feature.USE_FAST_DOUBLE_PARSER)
104+
94105
;
95106

96107
/**

src/main/java/com/fasterxml/jackson/core/json/JsonReadFeature.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -182,17 +182,6 @@ public enum JsonReadFeature
182182
*/
183183
@SuppressWarnings("deprecation")
184184
ALLOW_TRAILING_COMMA(false, JsonParser.Feature.ALLOW_TRAILING_COMMA),
185-
186-
/**
187-
* Feature that determines whether we use the built-in {@link Double#parseDouble(String)} code to parse
188-
* doubles or if we use {@link com.fasterxml.jackson.core.io.doubleparser}
189-
* instead.
190-
*<p>
191-
* This setting is disabled by default.
192-
*
193-
* @since 2.14
194-
*/
195-
USE_FAST_DOUBLE_PARSER(false, JsonParser.Feature.USE_FAST_DOUBLE_PARSER)
196185
;
197186

198187
final private boolean _defaultState;

src/test/java/com/fasterxml/jackson/core/read/FastParserNonStandardNumberParsingTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
package com.fasterxml.jackson.core.read;
22

33
import com.fasterxml.jackson.core.JsonFactory;
4+
import com.fasterxml.jackson.core.StreamReadFeature;
45
import com.fasterxml.jackson.core.json.JsonReadFeature;
56

6-
public class FastParserNonStandardNumberParsingTest extends NonStandardNumberParsingTest {
7+
public class FastParserNonStandardNumberParsingTest
8+
extends NonStandardNumberParsingTest
9+
{
710
private final JsonFactory fastFactory =
811
JsonFactory.builder()
912
.enable(JsonReadFeature.ALLOW_LEADING_DECIMAL_POINT_FOR_NUMBERS)
10-
.enable(JsonReadFeature.USE_FAST_DOUBLE_PARSER)
13+
.enable(StreamReadFeature.USE_FAST_DOUBLE_PARSER)
1114
.build();
1215

1316
@Override

src/test/java/com/fasterxml/jackson/core/read/FastParserNumberParsingTest.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
package com.fasterxml.jackson.core.read;
22

33
import com.fasterxml.jackson.core.JsonFactory;
4-
import com.fasterxml.jackson.core.JsonParser;
4+
import com.fasterxml.jackson.core.StreamReadFeature;
55

6-
public class FastParserNumberParsingTest extends NumberParsingTest {
7-
8-
private final JsonFactory fastFactory = new JsonFactory().enable(JsonParser.Feature.USE_FAST_DOUBLE_PARSER);
6+
public class FastParserNumberParsingTest extends NumberParsingTest
7+
{
8+
private final JsonFactory fastFactory = JsonFactory.builder()
9+
.enable(StreamReadFeature.USE_FAST_DOUBLE_PARSER)
10+
.build();
911

1012
@Override
1113
protected JsonFactory jsonFactory() {

src/test/java/com/fasterxml/jackson/core/read/NumberParsingTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
public class NumberParsingTest
2121
extends com.fasterxml.jackson.core.BaseTest
2222
{
23-
2423
protected JsonFactory jsonFactory() {
2524
return sharedStreamFactory();
2625
}

0 commit comments

Comments
 (0)