Skip to content

Commit 8fa89c6

Browse files
authored
Minor test refactoring (#1504)
1 parent 38da105 commit 8fa89c6

File tree

2 files changed

+86
-35
lines changed

2 files changed

+86
-35
lines changed

src/test/java/tools/jackson/core/unittest/tofix/async/AsyncTokenErrorTest.java renamed to src/test/java/tools/jackson/core/unittest/tofix/async/AsyncTokenNonRootErrorTest.java

Lines changed: 1 addition & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
import static org.junit.jupiter.api.Assertions.fail;
1313

14-
class AsyncTokenErrorTest extends AsyncTestBase
14+
class AsyncTokenNonRootErrorTest extends AsyncTestBase
1515
{
1616
private final JsonFactory JSON_F = newStreamFactory();
1717

@@ -52,40 +52,6 @@ private void _doTestInvalidKeyword(String value)
5252
} catch (StreamReadException jex) {
5353
verifyException(jex, EXP_MAIN, EXP_ALT);
5454
}
55-
56-
// Try as root-level value as well:
57-
doc = value + " "; // may need space after for DataInput
58-
try (AsyncReaderWrapper p = _createParser(doc)) {
59-
p.nextToken();
60-
fail("Expected an exception for malformed value keyword");
61-
} catch (StreamReadException jex) {
62-
verifyException(jex, EXP_MAIN, EXP_ALT);
63-
}
64-
}
65-
66-
@JacksonTestFailureExpected
67-
@Test
68-
void mangledRootInts() throws Exception
69-
{
70-
try (AsyncReaderWrapper p = _createParser("123true")) {
71-
JsonToken t = p.nextToken();
72-
fail("Should have gotten an exception; instead got token: "+t+"; number: "+p.getNumberValue());
73-
} catch (StreamReadException e) {
74-
verifyException(e, "expected space");
75-
}
76-
}
77-
78-
@JacksonTestFailureExpected
79-
@Test
80-
void mangledRootFloats() throws Exception
81-
{
82-
// Also test with floats
83-
try (AsyncReaderWrapper p = _createParser("1.5false")) {
84-
JsonToken t = p.nextToken();
85-
fail("Should have gotten an exception; instead got token: "+t+"; number: "+p.getNumberValue());
86-
} catch (StreamReadException e) {
87-
verifyException(e, "expected space");
88-
}
8955
}
9056

9157
@JacksonTestFailureExpected
Lines changed: 85 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
1+
package tools.jackson.core.unittest.tofix.async;
2+
3+
import org.junit.jupiter.api.Test;
4+
5+
import tools.jackson.core.JsonToken;
6+
import tools.jackson.core.exc.StreamReadException;
7+
import tools.jackson.core.json.JsonFactory;
8+
import tools.jackson.core.testutil.AsyncReaderWrapper;
9+
import tools.jackson.core.testutil.failure.JacksonTestFailureExpected;
10+
import tools.jackson.core.unittest.async.AsyncTestBase;
11+
12+
import static org.junit.jupiter.api.Assertions.fail;
13+
14+
class AsyncTokenRootErrorTest extends AsyncTestBase
15+
{
16+
private final JsonFactory JSON_F = newStreamFactory();
17+
18+
@Test
19+
void invalidKeywordsAfterMatching1st() throws Exception
20+
{
21+
_doTestInvalidKeyword("nul");
22+
_doTestInvalidKeyword("nulla");
23+
_doTestInvalidKeyword("fal");
24+
_doTestInvalidKeyword("fals0");
25+
_doTestInvalidKeyword("falsett0");
26+
_doTestInvalidKeyword("tr");
27+
_doTestInvalidKeyword("truE");
28+
_doTestInvalidKeyword("treu");
29+
_doTestInvalidKeyword("trueenough");
30+
}
31+
32+
@Test
33+
void invalidKeywordsAfterNonMatching1st() throws Exception
34+
{
35+
_doTestInvalidKeyword("Null");
36+
_doTestInvalidKeyword("False");
37+
_doTestInvalidKeyword("C");
38+
_doTestInvalidKeyword("xy");
39+
}
40+
41+
private void _doTestInvalidKeyword(String value)
42+
{
43+
final String EXP_MAIN = "Unrecognized token '"+value+"'";
44+
final String EXP_ALT = "Unexpected character ('"+value.charAt(0)+"' (code";
45+
46+
// Try as root-level value as well:
47+
String doc = value + " "; // may need space after for DataInput
48+
try (AsyncReaderWrapper p = _createParser(doc)) {
49+
p.nextToken();
50+
fail("Expected an exception for malformed value keyword");
51+
} catch (StreamReadException jex) {
52+
verifyException(jex, EXP_MAIN, EXP_ALT);
53+
}
54+
}
55+
56+
@JacksonTestFailureExpected
57+
@Test
58+
void mangledRootInts() throws Exception
59+
{
60+
try (AsyncReaderWrapper p = _createParser("123true")) {
61+
JsonToken t = p.nextToken();
62+
fail("Should have gotten an exception; instead got token: "+t+"; number: "+p.getNumberValue());
63+
} catch (StreamReadException e) {
64+
verifyException(e, "expected space");
65+
}
66+
}
67+
68+
@JacksonTestFailureExpected
69+
@Test
70+
void mangledRootFloats() throws Exception
71+
{
72+
// Also test with floats
73+
try (AsyncReaderWrapper p = _createParser("1.5false")) {
74+
JsonToken t = p.nextToken();
75+
fail("Should have gotten an exception; instead got token: "+t+"; number: "+p.getNumberValue());
76+
} catch (StreamReadException e) {
77+
verifyException(e, "expected space");
78+
}
79+
}
80+
81+
private AsyncReaderWrapper _createParser(String doc)
82+
{
83+
return asyncForBytes(JSON_F, 1, _jsonDoc(doc), 1);
84+
}
85+
}

0 commit comments

Comments
 (0)