Skip to content

Commit 0604fab

Browse files
committed
Yet more test stream-lining
1 parent 3eb6534 commit 0604fab

File tree

3 files changed

+27
-15
lines changed

3 files changed

+27
-15
lines changed

src/test/java/com/fasterxml/jackson/databind/deser/filter/NullConversionsForContentTest.java

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -266,31 +266,36 @@ public void testNullsAsEmptyWithArrays() throws Exception
266266
public void testNullsAsEmptyWithPrimitiveArrays() throws Exception
267267
{
268268
final String JSON = a2q("{'values':[null]}");
269+
ObjectReader r = MAPPER.reader()
270+
.without(DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES);
269271

270272
// int[]
271273
{
272-
NullContentAsEmpty<int[]> result = MAPPER.readValue(JSON,
273-
new TypeReference<NullContentAsEmpty<int[]>>() { });
274+
NullContentAsEmpty<int[]> result = r.forType
275+
(new TypeReference<NullContentAsEmpty<int[]>>() { })
276+
.readValue(JSON);
274277
assertEquals(1, result.values.length);
275278
assertEquals(0, result.values[0]);
276279
}
277280

278281
// long[]
279282
{
280-
NullContentAsEmpty<long[]> result = MAPPER.readValue(JSON,
281-
new TypeReference<NullContentAsEmpty<long[]>>() { });
283+
NullContentAsEmpty<long[]> result = r.forType
284+
(new TypeReference<NullContentAsEmpty<long[]>>() { })
285+
.readValue(JSON);
282286
assertEquals(1, result.values.length);
283287
assertEquals(0L, result.values[0]);
284288
}
285289

286290
// boolean[]
287291
{
288-
NullContentAsEmpty<boolean[]> result = MAPPER.readValue(JSON,
289-
new TypeReference<NullContentAsEmpty<boolean[]>>() { });
292+
NullContentAsEmpty<boolean[]> result = r.forType
293+
(new TypeReference<NullContentAsEmpty<boolean[]>>() { })
294+
.readValue(JSON);
290295
assertEquals(1, result.values.length);
291296
assertFalse(result.values[0]);
292297
}
293-
}
298+
}
294299

295300
@Test
296301
public void testNullsAsEmptyWithMaps() throws Exception

src/test/java/com/fasterxml/jackson/databind/deser/jdk/JDKNumberDeserTest.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -158,14 +158,18 @@ public void testTextualNullAsNumber() throws Exception
158158
assertNull(MAPPER.readValue(NULL_JSON, Float.class));
159159
assertNull(MAPPER.readValue(NULL_JSON, Double.class));
160160

161-
assertEquals(Byte.valueOf((byte) 0), MAPPER.readValue(NULL_JSON, Byte.TYPE));
162-
assertEquals(Short.valueOf((short) 0), MAPPER.readValue(NULL_JSON, Short.TYPE));
161+
ObjectMapper nullOksMapper = jsonMapperBuilder()
162+
.disable(DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES)
163+
.build();
164+
165+
assertEquals(Byte.valueOf((byte) 0), nullOksMapper.readValue(NULL_JSON, Byte.TYPE));
166+
assertEquals(Short.valueOf((short) 0), nullOksMapper.readValue(NULL_JSON, Short.TYPE));
163167
// Character is bit special, can't do:
164-
// assertEquals(Character.valueOf((char) 0), MAPPER.readValue(JSON, Character.TYPE));
165-
assertEquals(Integer.valueOf(0), MAPPER.readValue(NULL_JSON, Integer.TYPE));
166-
assertEquals(Long.valueOf(0L), MAPPER.readValue(NULL_JSON, Long.TYPE));
167-
assertEquals(Float.valueOf(0f), MAPPER.readValue(NULL_JSON, Float.TYPE));
168-
assertEquals(Double.valueOf(0d), MAPPER.readValue(NULL_JSON, Double.TYPE));
168+
// assertEquals(Character.valueOf((char) 0), nullOksMapper.readValue(JSON, Character.TYPE));
169+
assertEquals(Integer.valueOf(0), nullOksMapper.readValue(NULL_JSON, Integer.TYPE));
170+
assertEquals(Long.valueOf(0L), nullOksMapper.readValue(NULL_JSON, Long.TYPE));
171+
assertEquals(Float.valueOf(0f), nullOksMapper.readValue(NULL_JSON, Float.TYPE));
172+
assertEquals(Double.valueOf(0d), nullOksMapper.readValue(NULL_JSON, Double.TYPE));
169173

170174
assertNull(MAPPER.readValue(NULL_JSON, BigInteger.class));
171175
assertNull(MAPPER.readValue(NULL_JSON, BigDecimal.class));

src/test/java/com/fasterxml/jackson/databind/deser/jdk/JDKScalarsDeserTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,10 @@ static class VoidBean {
129129
public Void value;
130130
}
131131

132-
private final ObjectMapper MAPPER = newJsonMapper();
132+
// [databind#4858] Changes defaults for 3.0 so ensure configs work for 2.x and 3.x
133+
private final ObjectMapper MAPPER = jsonMapperBuilder()
134+
.disable(DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES)
135+
.build();
133136

134137
/*
135138
/**********************************************************

0 commit comments

Comments
 (0)