fix #5469

Author: JooHyukKim

src/main/java/tools/jackson/databind/DeserializationContext.java

@@ -1354,6 +1354,45 @@ public Object handleWeirdStringValue(Class<?> targetClass, String value,
         throw weirdStringException(value, targetClass, msg);
     }
 
+    /**
+     * Method that deserializers should call if they encounter a null value and
+     * target value type is a Primitive type.
+     *
+     * Default implementation will try to call {@link DeserializationContext#reportInputMismatch(Class, String, Object...)},
+     * which by default would throw {@link MismatchedInputException}
+     *
+     * @param targetClass Type of property into which incoming String should be converted
+     * @param deser Type of {@link ValueDeserializer} calling this method.
+     * @param msg Error message template caller wants to use if exception is to be thrown
+     * @param msgArgs Optional arguments to use for message, if any
+     *
+     * @throws JacksonException To indicate unrecoverable problem, usually based on <code>msg</code>
+     */
+    public Object handleNullForPrimitives(Class<?> targetClass,
+                                          ValueDeserializer<?> deser, String msg, Object... msgArgs)
+            throws JacksonException
+
+    {
+        // but if not handled, just throw exception
+        msg = _format(msg, msgArgs);
+        LinkedNode<DeserializationProblemHandler> h = _config.getProblemHandlers();
+        while (h != null) {
+            // Can bail out if it's handled
+            Object instance = h.value().handleNullForPrimitives(this, deser, msg);
+            if (instance != DeserializationProblemHandler.NOT_HANDLED) {
+                // Sanity check for broken handlers, otherwise nasty to debug:
+                if (_isCompatible(targetClass, instance)) {
+                    return instance;
+                }
+                return reportInputMismatch(deser,
+                        "Cannot map `null` into type %s (set DeserializationConfig.DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES to 'false' to allow)");
+            }
+            h = h.next();
+        }
+        return reportInputMismatch(deser,
+                "Cannot map `null` into type %s (set DeserializationConfig.DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES to 'false' to allow)");
+    }
+
     /**
      * Method that deserializers should call if they encounter a numeric value
      * that cannot be converted to target property type, in cases where some

src/main/java/tools/jackson/databind/deser/DeserializationProblemHandler.java

@@ -7,6 +7,7 @@
 import tools.jackson.core.JsonToken;
 import tools.jackson.databind.*;
 import tools.jackson.databind.jsontype.TypeIdResolver;
+import tools.jackson.databind.util.ClassUtil;
 
 /**
  * This is the class that can be registered (via
@@ -221,6 +222,38 @@ public Object handleUnexpectedToken(DeserializationContext ctxt,
         return NOT_HANDLED;
     }
 
+    /**
+     * Method that deserializers should call if the {@code null} value is encountered and
+     * need to deserialize as a Primitive types (e.g. int, long etc...)  that is, type of token that deserializer
+     * cannot handle). This could occur, for example, if a Number deserializer
+     * encounter {@link JsonToken#START_ARRAY} instead of
+     * {@link JsonToken#VALUE_NUMBER_INT} or {@link JsonToken#VALUE_NUMBER_FLOAT}.
+     *<ul>
+     * <li>Indicate it does not know what to do by returning {@link #NOT_HANDLED}
+     *  </li>
+     * <li>Throw a {@link JacksonException} to indicate specific fail message (instead of
+     *    standard exception caller would throw
+     *  </li>
+     * <li>Handle content to match (by consuming or skipping it), and return actual
+     *    instantiated value (of type <code>targetType</code>) to use as replacement;
+     *    value may be `null` as well as expected target type.
+     *  </li>
+     * </ul>
+     *
+     * @param failureMsg Message that will be used by caller
+     *    to indicate type of failure unless handler produces value to use
+     *
+     * @return Either {@link #NOT_HANDLED} to indicate that handler does not know
+     *    what to do (and exception may be thrown), or value to use (possibly
+     *    <code>null</code>
+     */
+    public Object handleNullForPrimitives(DeserializationContext ctxt,
+              ValueDeserializer<?> deser, String failureMsg)
+        throws JacksonException
+    {
+        return NOT_HANDLED;
+    }
+
     /**
      * Method called when instance creation for a type fails due to an exception.
      * Handler may choose to do one of following things:

src/main/java/tools/jackson/databind/deser/jdk/NumberDeserializers.java

@@ -159,13 +159,14 @@ public AccessPattern getNullAccessPattern() {
             return AccessPattern.CONSTANT;
         }
 
+        @SuppressWarnings("unchecked")
         @Override
         public final T getNullValue(DeserializationContext ctxt) {
             // 01-Mar-2017, tatu: Alas, not all paths lead to `_coerceNull()`, as `SettableBeanProperty`
             //    short-circuits `null` handling. Hence need this check as well.
             if (_primitive && ctxt.isEnabled(DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES)) {
-                ctxt.reportInputMismatch(this,
-                        "Cannot map `null` into type %s (set DeserializationConfig.DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES to 'false' to allow)",
+                return (T) ctxt.handleNullForPrimitives(handledType(), this, "Cannot map `null` into type %s (set DeserializationConfig.DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES to 'false' to allow)",
+                        // Fix
                         ClassUtil.classNameOf(handledType()));
             }
             return _nullValue;

src/main/java/tools/jackson/databind/deser/std/StdDeserializer.java

@@ -1638,8 +1638,9 @@ protected final void _verifyNullForPrimitive(DeserializationContext ctxt)
         throws DatabindException
     {
         if (ctxt.isEnabled(DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES)) {
-            ctxt.reportInputMismatch(this,
-"Cannot coerce `null` to %s (disable `DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES` to allow)",
+            ctxt.handleNullForPrimitives(handledType(),
+                    this,
+                    "Cannot coerce `null` to %s (disable `DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES` to allow)",
                     _coercedTypeDesc());
         }
     }

src/test/java/tools/jackson/databind/deser/filter/DeserializationProblemHandler5469Test.java

@@ -0,0 +1,61 @@
+package tools.jackson.databind.deser.filter;
+
+import org.junit.jupiter.api.Test;
+import tools.jackson.core.JacksonException;
+import tools.jackson.core.JsonParser;
+import tools.jackson.core.JsonToken;
+import tools.jackson.databind.*;
+import tools.jackson.databind.deser.DeserializationProblemHandler;
+import tools.jackson.databind.json.JsonMapper;
+import tools.jackson.databind.testutil.DatabindTestUtil;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+// For [databind#5469] Add callback to signal null for primitive in DeserializationProblemHandler
+public class DeserializationProblemHandler5469Test
+    extends DatabindTestUtil
+{
+    private static int hitCount = 0;
+    static class Person5469 {
+        public String id;
+        public String name;
+        public long age;
+    }
+
+    static class ProblemHandler5469 extends DeserializationProblemHandler
+    {
+        @Override
+        public Object handleNullForPrimitives(DeserializationContext ctxt, ValueDeserializer<?> deser, String failureMsg) throws JacksonException {
+            hitCount++;
+            return 5469L;
+        }
+    }
+
+    @Test
+    public void testIssue5469()
+            throws Exception
+    {
+        // Given
+        assertEquals(0, hitCount);
+        ObjectMapper mapper = JsonMapper.builder()
+                .enable(DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES)
+                .addHandler(new ProblemHandler5469())
+                .build();
+
+        // When
+        Person5469 person = mapper.readValue(
+            "{\"id\":  \"12ab\", \"name\": \"Bob\", " +
+            // Input is NULL, but....
+            "\"age\": null}", Person5469.class);
+
+        // Then
+        assertNotNull(person);
+        assertEquals("12ab", person.id);
+        assertEquals("Bob", person.name);
+        // We get the MAGIC NUMBER as age
+        assertEquals(5469L, person.age);
+        // Sanity check, we hit the code path as we wanted
+        assertEquals(1, hitCount);
+    }
+}