Skip to content

Commit 1463136

Browse files
committed
Further refactoring of tests wrt #3259
1 parent 3482354 commit 1463136

File tree

1 file changed

+18
-7
lines changed

1 file changed

+18
-7
lines changed

src/test/java/com/fasterxml/jackson/databind/deser/std/FromStringDeserializerTest.java renamed to src/test/java/com/fasterxml/jackson/databind/deser/jdk/LocaleDeserTest.java

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.fasterxml.jackson.databind.deser.std;
1+
package com.fasterxml.jackson.databind.deser.jdk;
22

33
import java.io.IOException;
44
import java.util.Locale;
@@ -8,7 +8,8 @@
88
import com.fasterxml.jackson.databind.BaseMapTest;
99
import com.fasterxml.jackson.databind.ObjectMapper;
1010

11-
public class FromStringDeserializerTest extends BaseMapTest
11+
// Tests for `java.util.Locale`
12+
public class LocaleDeserTest extends BaseMapTest
1213
{
1314
private final Locale[] LOCALES = new Locale[]
1415
{Locale.CANADA, Locale.ROOT, Locale.GERMAN, Locale.CHINESE, Locale.KOREA, Locale.TAIWAN};
@@ -23,17 +24,27 @@ public class FromStringDeserializerTest extends BaseMapTest
2324

2425
public void testLocale() throws IOException
2526
{
26-
assertEquals(new Locale("en"), MAPPER.readValue(q("en"), Locale.class));
27-
assertEquals(new Locale("es", "ES"), MAPPER.readValue(q("es_ES"), Locale.class));
28-
assertEquals(new Locale("FI", "fi", "savo"),
29-
MAPPER.readValue(q("fi_FI_savo"), Locale.class));
27+
// Simplest, one part
28+
assertEquals(new Locale("en"),
29+
MAPPER.readValue(q("en"), Locale.class));
30+
31+
// Simple; language+country
32+
assertEquals(new Locale("es", "ES"),
33+
MAPPER.readValue(q("es-ES"), Locale.class));
34+
assertEquals(new Locale("es", "ES"),
35+
MAPPER.readValue(q("es_ES"), Locale.class));
3036
assertEquals(new Locale("en", "US"),
3137
MAPPER.readValue(q("en-US"), Locale.class));
38+
assertEquals(new Locale("en", "US"),
39+
MAPPER.readValue(q("en_US"), Locale.class));
40+
41+
assertEquals(new Locale("FI", "fi", "savo"),
42+
MAPPER.readValue(q("fi_FI_savo"), Locale.class));
3243
}
3344

3445
public void testLocaleKeyMap() throws Exception {
3546
Locale key = Locale.CHINA;
36-
String JSON = "{ \"" + key + "\":4}";
47+
String JSON = "{ \"" + key.toString() + "\":4}";
3748
Map<Locale, Object> result = MAPPER.readValue(JSON, new TypeReference<Map<Locale, Object>>() {
3849
});
3950
assertNotNull(result);

0 commit comments

Comments
 (0)