Fix regression in ObjectNode.with() (#5099)

Author: rschmitt

release-notes/CREDITS-2.x

@@ -1930,3 +1930,7 @@ Joren Inghelbrecht (@jin-harmoney)
 Will Paul (@dropofwill)
  * Contributed #4979: Allow default enums with `@JsonCreator`
   (2.19.0)
+
+Ryan Schmitt (@rschmitt)
+ * Contributed #5099: Fix regression in `ObjectNode.with()`
+  (2.19.0)

src/main/java/com/fasterxml/jackson/databind/node/ObjectNode.java

@@ -87,7 +87,8 @@ public ObjectNode with(String exprOrProperty) {
                 .getClass().getName() + "`)");
         }
         ObjectNode result = objectNode();
-        return _put(exprOrProperty, result);
+        _put(exprOrProperty, result);
+        return result;
     }
 
     @Override

src/test/java/com/fasterxml/jackson/databind/node/ObjectNodeTest.java

@@ -291,11 +291,11 @@ public void testNullKeyChecking()
 
         assertThrows(NullPointerException.class, () -> src.set(null, BooleanNode.TRUE));
         assertThrows(NullPointerException.class, () -> src.replace(null, BooleanNode.TRUE));
-        
+
         assertThrows(NullPointerException.class, () -> src.setAll(Collections.singletonMap(null,
                 MAPPER.createArrayNode())));
     }
-    
+
     @Test
     public void testRemove()
     {
@@ -334,6 +334,25 @@ public void testValidWithObject() throws Exception
         assertEquals("{\"prop\":{}}", MAPPER.writeValueAsString(root));
     }
 
+    // for [databind#5099]
+    @Test
+    public void testValidWith() throws Exception
+    {
+        ObjectNode root = MAPPER.createObjectNode();
+        assertEquals("{}", MAPPER.writeValueAsString(root));
+
+        @SuppressWarnings("deprecation")
+        ObjectNode withResult = root.with( "with" );
+        withResult.put( "key", "value" );
+
+        ObjectNode withObjectResult = root.withObject( "withObject" );
+        withObjectResult.put( "key", "value" );
+
+        assertEquals("{\"key\":\"value\"}", MAPPER.writeValueAsString(withObjectResult));
+        assertEquals("{\"key\":\"value\"}", MAPPER.writeValueAsString(withResult));
+        assertEquals(withResult, withObjectResult);
+    }
+
     @Test
     public void testValidWithArray() throws Exception
     {