guess what? Fixing remaining test case compiler warnings (wrt unused imports, synth accessors)

Author: cowtowncoder

src/test/java/com/fasterxml/jackson/databind/BaseMapTest.java

@@ -11,7 +11,6 @@
 
 import com.fasterxml.jackson.core.*;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.deser.std.StdScalarDeserializer;
 import com.fasterxml.jackson.databind.json.JsonMapper;
 import com.fasterxml.jackson.databind.ser.std.StdScalarSerializer;

src/test/java/com/fasterxml/jackson/databind/MapperViaParserTest.java

@@ -7,7 +7,7 @@
 import com.fasterxml.jackson.core.io.CharacterEscapes;
 import com.fasterxml.jackson.core.io.SerializedString;
 import com.fasterxml.jackson.core.json.JsonWriteFeature;
-import com.fasterxml.jackson.databind.ObjectMapper;
+
 import com.fasterxml.jackson.databind.json.JsonMapper;
 
 public class MapperViaParserTest  extends BaseMapTest

src/test/java/com/fasterxml/jackson/databind/ObjectReaderTest.java

@@ -516,8 +516,8 @@ public boolean handleUnknownProperty(DeserializationContext ctxt, JsonParser p,
         assertEquals("test", aObject.knownField);
     }
 
-    private static class A{
-        private String knownField;
+    private static class A {
+        String knownField;
 
         @JsonCreator
         private A(@JsonProperty("knownField") String knownField) {

src/test/java/com/fasterxml/jackson/databind/TestFormatSchema.java

@@ -8,7 +8,6 @@
 import com.fasterxml.jackson.core.io.IOContext;
 import com.fasterxml.jackson.core.base.ParserBase;
 import com.fasterxml.jackson.core.base.GeneratorBase;
-import com.fasterxml.jackson.databind.ObjectMapper;
 
 /**
  * Basic tests to ensure that {@link FormatSchema} instances are properly

src/test/java/com/fasterxml/jackson/databind/TestRootName.java

@@ -2,7 +2,6 @@
 
 import com.fasterxml.jackson.annotation.*;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.exc.MismatchedInputException;
 import com.fasterxml.jackson.databind.json.JsonMapper;
 

src/test/java/com/fasterxml/jackson/databind/TestVersions.java

@@ -3,8 +3,8 @@
 import com.fasterxml.jackson.core.Version;
 import com.fasterxml.jackson.core.Versioned;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector;
+import com.fasterxml.jackson.databind.json.JsonMapper;
 import com.fasterxml.jackson.databind.cfg.PackageVersion;
 
 /**
@@ -15,7 +15,7 @@ public class TestVersions extends BaseMapTest
 {
     public void testMapperVersions()
     {
-        ObjectMapper mapper = new ObjectMapper();
+        ObjectMapper mapper = new JsonMapper();
         assertVersion(mapper);
         assertVersion(mapper.reader());
         assertVersion(mapper.writer());

src/test/java/com/fasterxml/jackson/databind/deser/TestObjectOrArrayDeserialization.java

@@ -13,8 +13,8 @@ public static class SomeObject {
     }
 
     public static class ArrayOrObject {
-        private final List<SomeObject> objects;
-        private final SomeObject object;
+        final List<SomeObject> objects;
+        final SomeObject object;
 
         @JsonCreator
         public ArrayOrObject(List<SomeObject> objects) {
@@ -29,24 +29,25 @@ public ArrayOrObject(SomeObject object) {
         }
     }
 
+    private final ObjectMapper MAPPER = newJsonMapper();
+
     public void testObjectCase() throws Exception {
-        ArrayOrObject arrayOrObject = new ObjectMapper().readValue("{}", ArrayOrObject.class);
+        ArrayOrObject arrayOrObject = MAPPER.readValue("{}", ArrayOrObject.class);
         assertNull("expected objects field to be null", arrayOrObject.objects);
         assertNotNull("expected object field not to be null", arrayOrObject.object);
     }
 
     public void testEmptyArrayCase() throws Exception {
-        ArrayOrObject arrayOrObject = new ObjectMapper().readValue("[]", ArrayOrObject.class);
+        ArrayOrObject arrayOrObject = MAPPER.readValue("[]", ArrayOrObject.class);
         assertNotNull("expected objects field not to be null", arrayOrObject.objects);
         assertTrue("expected objects field to be an empty list", arrayOrObject.objects.isEmpty());
         assertNull("expected object field to be null", arrayOrObject.object);
     }
 
     public void testNotEmptyArrayCase() throws Exception {
-        ArrayOrObject arrayOrObject = new ObjectMapper().readValue("[{}, {}]", ArrayOrObject.class);
+        ArrayOrObject arrayOrObject = MAPPER.readValue("[{}, {}]", ArrayOrObject.class);
         assertNotNull("expected objects field not to be null", arrayOrObject.objects);
         assertEquals("expected objects field to have size 2", 2, arrayOrObject.objects.size());
         assertNull("expected object field to be null", arrayOrObject.object);
     }
-
 }

src/test/java/com/fasterxml/jackson/databind/deser/creators/DelegatingExternalProperty1003Test.java

@@ -10,7 +10,7 @@ static class HeroBattle {
 
         private final Hero hero;
 
-        private HeroBattle(Hero hero) {
+        HeroBattle(Hero hero) {
             if (hero == null) throw new Error();
             this.hero = hero;
         }

src/test/java/com/fasterxml/jackson/databind/deser/creators/ImplicitNameMatch792Test.java

@@ -54,7 +54,7 @@ static class ReadWriteBean
     {
         private int value;
 
-        private ReadWriteBean(@JsonProperty(value="value",
+        ReadWriteBean(@JsonProperty(value="value",
                 access=JsonProperty.Access.READ_WRITE) int v) {
             value = v;
         }

src/test/java/com/fasterxml/jackson/databind/deser/creators/TestCreators3.java

@@ -115,7 +115,7 @@ public static Product1853 from(String name){
             return new Product1853(false, "DELEG:"+name);
         }
 
-        private Product1853(boolean bogus, String name) {
+        Product1853(boolean bogus, String name) {
             this.name = name;
         }