Skip to content

Commit 568066d

Browse files
committed
Minor comment cleanup
1 parent a5fffe7 commit 568066d

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -435,20 +435,15 @@ protected void collectAll()
435435
// First: gather basic accessors
436436
LinkedHashMap<String, POJOPropertyBuilder> props = new LinkedHashMap<String, POJOPropertyBuilder>();
437437

438-
// 15-Jan-2023, tatu: [databind#3736] Let's avoid detecting fields of Records
439-
// altogether (unless we find a good reason to detect them)
440-
// 17-Apr-2023: Need Records' fields for serialization for cases
441-
// like [databind#3628], [databind#3895] and [databind#3992]
442-
// 22-Jul-2024, tatu: ... and for deserialization sometimes too [databind#4626]
438+
// 14-Nov-2024, tatu: Previously skipped checking fields for Records; with 2.18+ won't
439+
// (see [databind#3628], [databind#3895], [databind#3992], [databind#4626])
443440
_addFields(props); // note: populates _fieldRenameMappings
444441

445442
_addMethods(props);
446443
// 25-Jan-2016, tatu: Avoid introspecting (constructor-)creators for non-static
447444
// inner classes, see [databind#1502]
448-
// 13-May-2023, PJ: Need to avoid adding creators for Records when serializing [databind#3925]
449-
// 18-May-2024, tatu: Serialization side does, however, require access to renaming
450-
// etc (see f.ex [databind#4452]) so let's not skip
451-
if (!_classDef.isNonStaticInnerClass()) { // && !(_forSerialization && isRecord)) {
445+
// 14-Nov-2024, tatu: Similarly need Creators for Records too (2.18+)
446+
if (!_classDef.isNonStaticInnerClass()) {
452447
_addCreators(props);
453448
}
454449

0 commit comments

Comments
 (0)